Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C029155389 for ; Sat, 18 Oct 2025 04:59:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760763566; cv=none; b=jkm7S0RplOnmC9C3utx51leSKCHB+3vIVjDepIPmNqCNtvFEPPDAqilcLvEsX6oQB7d/9g830D3EEL2+96AiydXLRzNUIB6+8Xw3R0jqSxITVvtQ59jeDvgOHGyHwvI/uIOo0yLOn79Ybjr/X/Aq5uNq2zUKLv86OTvDJ6hooYg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760763566; c=relaxed/simple; bh=IUZFOQeuI3yCpqc7n7wK2+nBiCoxcsO0N/ZUQHofi9A=; h=Date:Mime-Version:Message-ID:Subject:From:To:Content-Type; b=FiKc/1jnJiFL+s8zioKDPOL4upWA6t7D5Qu+3MSYghsEdm9bGiJzRy4zA1eCkXuKy/LxxRPCP+ccti4vJhjf0QaKGm4z3IzE//k/AM9CPIXgCMuGbQJEni8I8KF0d5gjSA/HRTi6BIsjOjfL2I4pQgty/6tjJer6cIlzJUpNfME= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=t4Xkd0iH; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="t4Xkd0iH" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-b55283ff3fcso1746411a12.3 for ; Fri, 17 Oct 2025 21:59:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1760763564; x=1761368364; darn=vger.kernel.org; h=to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=vkcjNV+lg/qMB7XR1dlSgtqiUT8Il7EIrwR559XmCkM=; b=t4Xkd0iHTmOOstZf4rOp16HLVWC7AGe016AowcVFa57VJfCYqeUoF64BgAjJXUgC4F Q4t7sdQcCgcfwKX1hA4GOTZ6NJVeDsqazSnEoWR6HoWKXZgh2CWB0IykbWaoHM/gepbF oeSnww6pY+ucVVvJfiFW4EbWADkR4xq5yIwgEtBtHGF7wH42VHjzaocVgk06Bhp0AncU lHf4XVYSjHJ3LUNU8+FpE/zMduls6imZeUa5lpB7sSGmeJ496Scxbp1PHB1zBRuScaAr jccQjKVpeDI7S5sL+CDbve0oTsjLej3CEqxtSbDD2P6pIvJ0VWC9u61M9AGEPnE5W4nn h4nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760763564; x=1761368364; h=to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=vkcjNV+lg/qMB7XR1dlSgtqiUT8Il7EIrwR559XmCkM=; b=JcBJtJ8ONIl5yaYmZp7zdHLEWJKaEOcurfHuMqclAutiIw3oIvP11mhgoJJwnxHhb5 E8QQJ8kimj2qBTzNmEAF6dju2Wa2yMUudtzSydPFhte7pjJ9jQDl98Uo/aDbzysa2XnT BPGxh6GuDtajtPCd4WF92eY3V29CqsXuvR6H2WFjPwGsXVAeqmtIposWySGnimnneba9 fndrqdrLqTjsh7HtffU1T07glKl7HxA3Ha4TViY+uJN3WrRouyohkMlyt8n7Nkdx+TXD 3r9vBzQOqnmkcgYwjpCfVeTw+oBXP7rTYgtcA7hl7oimnHl7zCWoXXF2R1dqWwDosvZ0 gOJg== X-Forwarded-Encrypted: i=1; AJvYcCUQUaXe+qkhQpUFJJ8rMqpCIuEw5POixQKBkyC+AWEAuqlsLG239MQxd/p8t1p6XI5yJhuAQNU5zl2dxjeqtZ5M@vger.kernel.org X-Gm-Message-State: AOJu0Ywv+JZvPu2poDnWEQKTxnqgxhkxmwivylJs8gVUvrZ5850aO1DO zAf8YW4DDtbRAYIuyKf9KdWbd99tse0D7gMvxORh+dBpfA0UfjYWnCRwCDCOYplinfrKNgCwb/S K29qXScT8fg== X-Google-Smtp-Source: AGHT+IFbctGvWW7cWWpUbK4gP5ZmVYuUzv9u9IHygP/MBkIa+mrhQm2gwwrDgcf5CKToet4IvqfjzNTA+2/v X-Received: from pgbcm13.prod.google.com ([2002:a05:6a02:a0d:b0:b55:135:7cb9]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:12cb:b0:334:a322:f326 with SMTP id adf61e73a8af0-334a86070cdmr8832156637.28.1760763564485; Fri, 17 Oct 2025 21:59:24 -0700 (PDT) Date: Fri, 17 Oct 2025 21:59:02 -0700 Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.51.0.858.gf9c4a03a3a-goog Message-ID: <20251018045902.21665-1-irogers@google.com> Subject: [PATCH v1] perf trace: Don't synthesize mmaps unless callchains are enabled From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Stephane Eranian Content-Type: text/plain; charset="UTF-8" Synthesizing mmaps in perf trace is unnecessary unless call chains are being generated. Signed-off-by: Ian Rogers --- tools/perf/builtin-trace.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index c607f39b8c8b..a743bda294bd 100644 --- a/tools/perf/builtin-trace.c +++ b/tools/perf/builtin-trace.c @@ -2005,7 +2005,9 @@ static int trace__symbols_init(struct trace *trace, int argc, const char **argv, err = __machine__synthesize_threads(trace->host, &trace->tool, &trace->opts.target, evlist->core.threads, trace__tool_process, - true, false, 1); + /*needs_mmap=*/callchain_param.enabled, + /*mmap_data=*/false, + /*nr_threads_synthesize=*/1); out: if (err) { perf_env__exit(&trace->host_env); -- 2.51.0.858.gf9c4a03a3a-goog