Received: from mail-oi1-f180.google.com (mail-oi1-f180.google.com [209.85.167.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18CC525F99F for ; Sat, 18 Oct 2025 23:11:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760829090; cv=none; b=rXW7mf3YVFOMsHGptUfd55gd+sBTo5DRkXivc0mXsLEp3GmAt+RmRZmdk1mokVPBUv+g9LHn12wS/SkscqtvMRNMyDev1bK/UtGKHX9EPQVnEdAD1HJyiS8oQJY2lHL1KGPDai3g7or63bBomudurPmn5V2n6jFVpMZ7PtXeFgU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760829090; c=relaxed/simple; bh=nlTGgh1j4rnsma37VDwy3XvjnEutOrYN/Saoiw9k0/M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dGTUrXMo0T/0XWv2AAyZGP1aQnb7wb/HCcYpzxuAoYntKR8olYKCm0QoR7+tUqxomBWWP424lVoCOQkPgNVHA4EjhAPPitbWjcw3D/nDQB9Jc5P/FAZplYDjBfRJDXU0PmtQa92AZXM9d2HDeN6rPc3bx2EOt0ut9N3IXEGle9A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=BZ6S2Xs4; arc=none smtp.client-ip=209.85.167.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="BZ6S2Xs4" Received: by mail-oi1-f180.google.com with SMTP id 5614622812f47-4433456f043so1581482b6e.3 for ; Sat, 18 Oct 2025 16:11:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1760829088; x=1761433888; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nlTGgh1j4rnsma37VDwy3XvjnEutOrYN/Saoiw9k0/M=; b=BZ6S2Xs40U9WQeq7NwydR9GbhQbdvOjDSv4Qbr9KKeCYizlk6xi5vEFooSbU8ymvLl WSBq5lAT1yCWnNc6H16VrjD0JeAdPqqNvYBxmG52hVSP/t1bdV0YhO0yBVZQ+S0wsrpY /QPFLN0zDpppP7ApdEaqJsD1GF7o5OP+bYGjdmMJOGm/Kt6tuFeThxoQFTLzXKtqoWHh CteSEOebSSDXqi99VukwnkUrG/AMT9Obl/oLUprKxkOT9lYdjoQ17DHql8pZX8V6Y37P TrqnH3iTSdnsI1yr9Uoy+JIq0ccrtZoBfQcv+rDIlNoL4H0lhLQyB623WY2d67VJJy9j 0TwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760829088; x=1761433888; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nlTGgh1j4rnsma37VDwy3XvjnEutOrYN/Saoiw9k0/M=; b=WcEKAZCzK1ONyl6pqkXO+aUjwXtCKunS6Xg8wy/tPrQQrlvh3VQsy+r4Ls07b31lbf CU3Rmdhdkf6XAaAuR9Sh5kWUPy7MT/9CQ4Z/xV+WcIw86e4e3+HQxVJ+SqLyMQ3ZmPfq 3YTKl1qHkg0kFNC2097a/ROCmkv8JS8T4E/zhK7eGnn0rP6QAY0fp8C+Vlod0LqyDZG8 HsdCvhofj7c/az7g3TePU8haOZKESBJNUVnyqPCjsXP3s7sp/UhRTHmIpM/nC6FegSRd 987SK67KA23t2Bj6PFZs94hhuuPcG1HGh2fYaeO36QMD116R70GrIfPwJR8siqBn2fdh gVCg== X-Forwarded-Encrypted: i=1; AJvYcCUT9eRlLw3tBmVY7szbYIaUzxdh8BDpLSA0wvgznLiK6LCbhOYBl6TSMygtdEtmPKiSEKk=@vger.kernel.org X-Gm-Message-State: AOJu0YxHkhPzsNccL3ydz+QpM9CwJNa9VmfCXlKLU/uduJY/MUuX0GmT 8UNUccSEyuhnCFBRG2aZmXNoR7F/tGVkgP4NGIiyVcqK8R7pQ0gB0iCX6am2Q+6qU3c= X-Gm-Gg: ASbGncvYELs1BJCSgbECOgMP8shBqakrxUnG10LP8nKbvcNLxfSjXMdo8asIvo3k0JD KxUEVAyY2uuPGj+gvD/KG41zX9OwKE4CSCROzpqeOtRyj/uLbX/Sx90QV1tBWbRV+tD4i8ynCg4 +vsu5OdyxnC/WLWAAYNDM6zU7lecmdAAMFrWaneyyd6Qg/VPEIS5XX5GX1CI2oWdL8g1m4JeE6F Z2NU//UzvOpl/9QhBVt5GiW2lrV6wORSJ0Y4BiXNkIQSx/3Sl1Yef0VhlnILm0TIqbARomZvnnK EcgsmObn9K+mRxtvt9zmKZ+QzsTPNTxhBOxPc8hvqxN+LFxcYmOO8E9t877I7Z7LaUV2rCu3o9b 4A8r0c1D/Khib+UVSxmwXmeK5AAUgWHSgP5a3Sw0XASIf4w2NMBkJRf6qc70O X-Google-Smtp-Source: AGHT+IGjutQW9FOpunwPbl54R4lmphJmatLWLrvDMN3YzWlbvrTlVJ+kuMrXHSfrl8ye5jNWMdw9aw== X-Received: by 2002:a05:6808:2388:b0:43f:5fc5:e04a with SMTP id 5614622812f47-443a30af9cfmr3465468b6e.31.1760829088069; Sat, 18 Oct 2025 16:11:28 -0700 (PDT) Received: from ziepe.ca ([130.41.10.202]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-651d3f8d640sm899440eaf.20.2025.10.18.16.11.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Oct 2025 16:11:27 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1vAG58-00000001dfK-14RB; Sat, 18 Oct 2025 20:11:26 -0300 Date: Sat, 18 Oct 2025 20:11:26 -0300 From: Jason Gunthorpe To: Vipin Sharma Cc: Lukas Wunner , bhelgaas@google.com, alex.williamson@redhat.com, pasha.tatashin@soleen.com, dmatlack@google.com, graf@amazon.com, pratyush@kernel.org, gregkh@linuxfoundation.org, chrisl@kernel.org, rppt@kernel.org, skhawaja@google.com, parav@nvidia.com, saeedm@nvidia.com, kevin.tian@intel.com, jrhilke@google.com, david@redhat.com, jgowans@amazon.com, dwmw2@infradead.org, epetron@amazon.de, junaids@google.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [RFC PATCH 15/21] PCI: Make PCI saved state and capability structs public Message-ID: <20251018231126.GS3938986@ziepe.ca> References: <20251018000713.677779-1-vipinsh@google.com> <20251018000713.677779-16-vipinsh@google.com> <20251018223620.GD1034710.vipinsh@google.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251018223620.GD1034710.vipinsh@google.com> On Sat, Oct 18, 2025 at 03:36:20PM -0700, Vipin Sharma wrote: > Having __packed in my version of struct, I can build validation like > hardcoded offset of members. I can add version number (not added in this > series) for checking compatbility in the struct for serialization and > deserialization. Overall, it is providing some freedom to how to pass > data to next kernel without changing or modifying the PCI state > structs. I keep saying this, and this series really strongly shows why, we need to have a dedicated header directroy for LUO "ABI" structs. Putting this random struct in some random header and then declaring it is part of the luo ABI is really bad. All the information in the abi headers needs to have detailed comments explaining what it is and so on so people can evaluate if it is suitable or not. But, it is also not clear why pci serialization structs should leak out of the PCI layer. The design of luo was to allow each layer to contribute its own tags/etc to the serialization so there is no reason to have vfio piggback on pci structs or something. Jason