Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABCB42D8375 for ; Wed, 22 Oct 2025 17:51:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761155516; cv=none; b=F/5qDuofkC2ebURQ862Ii/KjlkWAajeiuEbdChji/L1bnw+tpfzn0VnElFW0c6v4Jgt8VSEvG53my0cGSGAnbZuQQhqDS2whiyPOQ5niT12u6Gxn1ICuZ0MeWPE5XucKPJxKNwJ2MllKVl1GQP8DS/T59KmIRJpFg3fVu+TU9cM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761155516; c=relaxed/simple; bh=4HaaXDR/LHQu198ef3JyPuMYkr9oqG+YsjWt7cbNCw0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WndEWxNSOXFKAiFwVcNymL6Augqw+P0VxyuAoN5z/LPSbvQEyyTmeCiHwF1BZmXRRStL96W5VN99DL5teDlVjEiU7H2Z8BVWE7aF6B0f491nYFGAOueoxcjDmXk8rTQj7D9hkFys7aa8j9GL65nScYJL+HQlZN8bLVdZzPBQQJM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=Z4S7iqqE; arc=none smtp.client-ip=209.85.222.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="Z4S7iqqE" Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-88f239686f2so887965085a.0 for ; Wed, 22 Oct 2025 10:51:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1761155513; x=1761760313; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=KHWh/jKrHs1DdtC5lcScutvVgEeB0TcBCM9LGz47JlA=; b=Z4S7iqqEOPkzQCY36TDaakKaNk/RODGTCUJka+yI2Flr6m9fnlH+eoN5jSUVEcYNK8 75SUVfLwNl9lnpU1EyHKCH4a/E2O8IKC0nwxtvqsSriqAvG+jTUdL7tj9jbKYekuigsl /SEIO40lx3K/hbib13S0rBefcIE+A9pA4CL2phRX3hw9QoHN/hghEA6n86VPGLB80Orm sSfQjph/VG7FHAydLBiLilfsD7XY0EqeaWs0wM7/Z5BV+YrWg4ZtuavdSk5NytsDxEjp o+R+H87sHKo6/FTc3ancsg0q9fZDFA2M7Rb0TzkxwYIoEVb/4D1011lbElSS479pLAcO gWRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761155513; x=1761760313; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KHWh/jKrHs1DdtC5lcScutvVgEeB0TcBCM9LGz47JlA=; b=KSuIKL0oijbZxR3ecYy/OPVNtYhaqlqXJE9aYAeqMiMgnD4l/SAR/+dSQM8pV1yYxf MxZ5QfVFUClUog39jovuB53h+OS4CUlCzlrQn3een9tlx8VLKtiva8oXTz30bssAABkK YviZk/xdhflG4bbvxx1XVg+mBZvLRDMka6Qx8vwvEhDUNYGzdiYM5/m4hOe9nLdWuu1b MuzQ5Rw51Csoiy1VzHXdicJQh7XjmnPHZY5akAj6QPa2UVtLpa3pBOdKEU+oKdnTXmYm j7si0+/LJ/Y8e+UnoP2VsJCTsRr3IpKlGw1dGHPDMhQWeG05BLOJFJN0zmo2MFX0ZUr5 wdWA== X-Forwarded-Encrypted: i=1; AJvYcCVFeWpw+RyPvqIVtY43lkDyb3Vym3h7MU9/u9hyZtfN2G1tm+6RQ+IYOUJkNUqxcSrR+FM=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2NDapOsmvgZQxIUnzja2KT+n+xlJX5rfNDnIlmBRiK0FQ+xoi hlidGaOPH/nSakhGnJ0dp7mptJ9Ry5xHOdfBYsB5NFOXI4oMRLQ7UsaTLvLCZa15NgY= X-Gm-Gg: ASbGncsECYrTcojAZdpAkRt0g62f1OdPFy+TbCl+DkJTAZUUMyaMtadbkWnfyL5bw9g F+lRqlN/VfcbcK2MxFk8aWXI4lLMT2lmW2oYLbw5WoGDG6rkQb8oSec+tgyxjWFFQkKNRtWEJJ8 TAlb0R5ns7N3hbPDIm9hi19F3/pRiqEkWiz7QJofnFSkdIascLwTcq3dltZiRTtf/bbtLfSc5yL kD9H8Nr0HpINlMqhtCZEjbiqMFCUymGZI/TGZog4M59Tu5UNdvMxB/3rVxFVwPPSCBa+aaep5R5 oVFENj7r3OyRjQzcHPp7Uvhyoh9HvfT83TTBRpk5hBUA3r97UcPVGCIz3kqOBux514ZX5LrE7zS ioYCwpSJg3rRCeD/u085eqPk0/KIoihWBn3kWiKGH2kSu0G9AtQxfY3kbZi0QqP2Wb7BNELLZHx ICeKTMwuwvVxBLVeFTjmc3pv7rX0+BQgMqvNg7Ks/nMWT3XA== X-Google-Smtp-Source: AGHT+IEYALJ+9B/lobgy3w+EObmI4AQjPiv2ADEkieSdC2CNpT2TTJQRK4oxJ8OfChPFR/4y0Hbz2g== X-Received: by 2002:a05:620a:294e:b0:85f:ed51:e920 with SMTP id af79cd13be357-8906e6b279amr2306580185a.4.1761155513429; Wed, 22 Oct 2025 10:51:53 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-47-55-120-4.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.120.4]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4e8ab0ee857sm97295781cf.31.2025.10.22.10.51.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Oct 2025 10:51:52 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1vBd04-00000002rPt-1SQi; Wed, 22 Oct 2025 14:51:52 -0300 Date: Wed, 22 Oct 2025 14:51:52 -0300 From: Jason Gunthorpe To: David Matlack Cc: Vipin Sharma , Lukas Wunner , bhelgaas@google.com, alex.williamson@redhat.com, pasha.tatashin@soleen.com, graf@amazon.com, pratyush@kernel.org, gregkh@linuxfoundation.org, chrisl@kernel.org, rppt@kernel.org, skhawaja@google.com, parav@nvidia.com, saeedm@nvidia.com, kevin.tian@intel.com, jrhilke@google.com, david@redhat.com, jgowans@amazon.com, dwmw2@infradead.org, epetron@amazon.de, junaids@google.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [RFC PATCH 15/21] PCI: Make PCI saved state and capability structs public Message-ID: <20251022175152.GE21554@ziepe.ca> References: <20251018000713.677779-1-vipinsh@google.com> <20251018000713.677779-16-vipinsh@google.com> <20251018223620.GD1034710.vipinsh@google.com> <20251018231126.GS3938986@ziepe.ca> <20251020234934.GB648579.vipinsh@google.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Oct 22, 2025 at 10:45:31AM -0700, David Matlack wrote: > On Mon, Oct 20, 2025 at 4:49 PM Vipin Sharma wrote: > > > > On 2025-10-18 20:11:26, Jason Gunthorpe wrote: > > > On Sat, Oct 18, 2025 at 03:36:20PM -0700, Vipin Sharma wrote: > > > > > > > Having __packed in my version of struct, I can build validation like > > > > hardcoded offset of members. I can add version number (not added in this > > > > series) for checking compatbility in the struct for serialization and > > > > deserialization. Overall, it is providing some freedom to how to pass > > > > data to next kernel without changing or modifying the PCI state > > > > structs. > > > > > > I keep saying this, and this series really strongly shows why, we need > > > to have a dedicated header directroy for LUO "ABI" structs. Putting > > > this random struct in some random header and then declaring it is part > > > of the luo ABI is really bad. > > > > Now that we have PCI, IOMMU, and VFIO series out. What should be the > > strategy for LUO "ABI" structs? I would like some more clarity on how > > you are visioning this. > > > > Are you suggesting that each subsystem create a separate header file for > > their serialization structs or we can have one common header file used > > by all subsystems as dumping ground for their structs? > > I think we should have multiple header files in one directory, that > way we can assign separate MAINTAINERS for each file as needed. > > Jason Miu proposed the first such header for KHO in > https://lore.kernel.org/lkml/CALzav=eqwTdzFhZLi_mWWXGuDBRwWQdBxQrzr4tN28ag8Zr_8Q@mail.gmail.com/. > > Following that example we can add vfio_pci.h and pci.h to that > directory for VFIO and PCI ABI structs respectively. Seems like a good idea to me. Jason