Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3012ECCF9E7 for ; Thu, 23 Oct 2025 04:08:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0196810E86E; Thu, 23 Oct 2025 04:08:08 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="PQCsGlBH"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6E83E10E867; Thu, 23 Oct 2025 04:08:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1761192487; x=1792728487; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=HJ83nfz36gneRRHygtBx1DeusGRSvbwXJ2dujXNY7jM=; b=PQCsGlBHlnlmoJoZfMPwsJrciU16/Uo92KV09cew8KuWkMJ0WDs+QPJK Ew4FzH6oXAw+JQBeIXlUnQ18e+vfk1EohCbz/w9W1HZD3IWsLBU4pWNSX mqb9faiZSkDWNBThOW3WI18GJMmvsSWLr/qkchfOeRD+qCf8jYYdVgP7j gXnUgDeRMx4aXGVG61ljOrOb2oPO/j+GuPk87mvYN4uMDS+NpZeFPlZYL CNXwubj5fIeeY+DzXDcEqswVH3WiS2/tEvo8NDX8Az+6p9SDPCYivN8vM Kv6DpW0CRSM8egIw04Of7kZSnxe9qoeOkZzdCAtNO+e50i3ZDPsvI2NS6 w==; X-CSE-ConnectionGUID: qZQPXNzkSIG/e20AdyYNAQ== X-CSE-MsgGUID: Bf6okDLkSuun2Q1ZIME6mA== X-IronPort-AV: E=McAfee;i="6800,10657,11586"; a="63391291" X-IronPort-AV: E=Sophos;i="6.19,248,1754982000"; d="scan'208";a="63391291" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2025 21:08:05 -0700 X-CSE-ConnectionGUID: HjV165xLRp+oOM5DRxFmOA== X-CSE-MsgGUID: 8YaLWwMQTxa/l9R0Awvm1g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,248,1754982000"; d="scan'208";a="189175762" Received: from lstrano-desk.jf.intel.com ([10.54.39.91]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2025 21:08:05 -0700 From: Matthew Brost To: intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: christian.koenig@amd.com Subject: [RFC PATCH 14/14] drm/xe: Finish disconnect HW fences from module Date: Wed, 22 Oct 2025 21:08:00 -0700 Message-Id: <20251023040800.970283-15-matthew.brost@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251023040800.970283-1-matthew.brost@intel.com> References: <20251023040800.970283-1-matthew.brost@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Be safe when dereferencing fence->xe. Signed-off-by: Matthew Brost --- drivers/gpu/drm/xe/xe_hw_fence.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_hw_fence.c b/drivers/gpu/drm/xe/xe_hw_fence.c index f5fad4426729..8181dfc628e4 100644 --- a/drivers/gpu/drm/xe/xe_hw_fence.c +++ b/drivers/gpu/drm/xe/xe_hw_fence.c @@ -159,9 +159,7 @@ static struct xe_hw_fence_irq *xe_hw_fence_irq(struct xe_hw_fence *fence) static const char *xe_hw_fence_get_driver_name(struct dma_fence *dma_fence) { - struct xe_hw_fence *fence = to_xe_hw_fence(dma_fence); - - return dev_name(fence->xe->drm.dev); + return "xe"; } static const char *xe_hw_fence_get_timeline_name(struct dma_fence *dma_fence) @@ -175,10 +173,13 @@ static bool xe_hw_fence_signaled(struct dma_fence *dma_fence) { struct xe_hw_fence *fence = to_xe_hw_fence(dma_fence); struct xe_device *xe = fence->xe; - u32 seqno = xe_map_rd(xe, &fence->seqno_map, 0, u32); + u32 seqno; + + if (dma_fence->error) + return true; - return dma_fence->error || - !__dma_fence_is_later(dma_fence, dma_fence->seqno, seqno); + seqno = xe_map_rd(xe, &fence->seqno_map, 0, u32); + return !__dma_fence_is_later(dma_fence, dma_fence->seqno, seqno); } static bool xe_hw_fence_enable_signaling(struct dma_fence *dma_fence) -- 2.34.1