Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F410CCF9EB for ; Fri, 24 Oct 2025 10:08:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 86CF610EA4C; Fri, 24 Oct 2025 10:08:32 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="GDtkPI0f"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0069510EA49; Fri, 24 Oct 2025 10:08:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1761300511; x=1792836511; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5LbeSLZet3VwJiQPM8av40Zq+mWXTZExlgNHkrAZ1LY=; b=GDtkPI0fMWeVfaV+uqa5ykITeYbksQkppymYbRwvR/oUSTwUvQgd8iN2 qhFm8oIduMtI6Yo6tasgKFwFXq8fiIdPDylFQLY80NZMlwKxVDVEmaTNz FZFhEO8ukrLxKQiutUglK51i73lQe5kaYgHhOAdkJGdhY85/1O3/QCvTJ uhgG945xcJs2Lf36/WQGfvedg/UIqKrhArZ3rG3rGXWXUujq0z4SM9wTN 5yeUiPwUqWvn3bWSLdC2lDPbDRRXLwOfShNxOOuGFIroOq3LPyiv1dVnh BMbrblq4kOUgfti8sbBa9IJnzA7ej8pxlh/V4KU1nFC8E7XPmPlpRNPw1 Q==; X-CSE-ConnectionGUID: c9TEviEhS12fcDbn9glp+Q== X-CSE-MsgGUID: x+lR8mmFSzWep98uI4EVKw== X-IronPort-AV: E=McAfee;i="6800,10657,11586"; a="67346873" X-IronPort-AV: E=Sophos;i="6.19,252,1754982000"; d="scan'208";a="67346873" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2025 03:08:30 -0700 X-CSE-ConnectionGUID: 2B6r/CapRsiYeAw5rEXFMw== X-CSE-MsgGUID: teS5lLJrQZ64hJ0DiLljjg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,252,1754982000"; d="scan'208";a="208039344" Received: from kandpal-x299-ud4-pro.iind.intel.com ([10.190.239.10]) by fmviesa002.fm.intel.com with ESMTP; 24 Oct 2025 03:08:28 -0700 From: Suraj Kandpal To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: ankit.k.nautiyal@intel.com, arun.r.murthy@intel.com, uma.shankar@intel.com, gustavo.sousa@intel.com, lucas.demarchi@intel.com, Suraj Kandpal Subject: [PATCH v2 25/26] drm/i915/ltphy: Modify the step that need to be skipped Date: Fri, 24 Oct 2025 15:37:11 +0530 Message-Id: <20251024100712.3776261-26-suraj.kandpal@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251024100712.3776261-1-suraj.kandpal@intel.com> References: <20251024100712.3776261-1-suraj.kandpal@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Bspec has changed the non tbt pll enable sequence now we skip steps 5-17 if no config change has occurred. Signed-off-by: Suraj Kandpal Reviewed-by: Arun R Murthy --- drivers/gpu/drm/i915/display/intel_lt_phy.c | 63 +++++++++++---------- 1 file changed, 33 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_lt_phy.c b/drivers/gpu/drm/i915/display/intel_lt_phy.c index c926b984c52f..11070aaf320d 100644 --- a/drivers/gpu/drm/i915/display/intel_lt_phy.c +++ b/drivers/gpu/drm/i915/display/intel_lt_phy.c @@ -1660,40 +1660,43 @@ void intel_lt_phy_pll_enable(struct intel_encoder *encoder, XE3PLPD_MACCLK_TURNON_LATENCY_US, 2, NULL)) drm_warn(display->drm, "PHY %c PLL MacCLK Ack assertion Timeout after %dus.\n", phy_name(phy), XE3PLPD_MACCLK_TURNON_LATENCY_US); + + /* + * 13. Ungate the forward clock by setting + * PORT_CLOCK_CTL[Forward Clock Ungate] = 1. + */ + intel_de_rmw(display, XELPDP_PORT_CLOCK_CTL(display, port), + XELPDP_FORWARD_CLOCK_UNGATE, + XELPDP_FORWARD_CLOCK_UNGATE); + + /* 14. SW clears PORT_BUF_CTL2 [PHY Pulse Status]. */ + intel_de_rmw(display, XELPDP_PORT_BUF_CTL2(display, port), + lane_phy_pulse_status, + lane_phy_pulse_status); + /* + * 15. Clear the PHY VDR register 0xCC4[Rate Control VDR Update] over + * PHY message bus for Owned PHY Lanes. + */ + rate_update = intel_lt_phy_read(encoder, INTEL_LT_PHY_LANE0, LT_PHY_RATE_UPDATE); + rate_update &= ~LT_PHY_RATE_CONTROL_VDR_UPDATE; + intel_lt_phy_write(encoder, owned_lane_mask, LT_PHY_RATE_UPDATE, + rate_update, MB_WRITE_COMMITTED); + + /* 16. Poll for PORT_BUF_CTL2 register PHY Pulse Status = 1 for Owned PHY Lanes. */ + if (intel_de_wait_custom(display, XELPDP_PORT_BUF_CTL2(display, port), + lane_phy_pulse_status, lane_phy_pulse_status, + XE3PLPD_RATE_CALIB_DONE_LATENCY_US, 2, NULL)) + drm_warn(display->drm, "PHY %c PLL rate not changed after %dus.\n", + phy_name(phy), XE3PLPD_RATE_CALIB_DONE_LATENCY_US); + + /* 17. SW clears PORT_BUF_CTL2 [PHY Pulse Status]. */ + intel_de_rmw(display, XELPDP_PORT_BUF_CTL2(display, port), + lane_phy_pulse_status, + lane_phy_pulse_status); } else { intel_de_write(display, DDI_CLK_VALFREQ(encoder->port), crtc_state->port_clock); } - /* 13. Ungate the forward clock by setting PORT_CLOCK_CTL[Forward Clock Ungate] = 1. */ - intel_de_rmw(display, XELPDP_PORT_CLOCK_CTL(display, port), - XELPDP_FORWARD_CLOCK_UNGATE, - XELPDP_FORWARD_CLOCK_UNGATE); - - /* 14. SW clears PORT_BUF_CTL2 [PHY Pulse Status]. */ - intel_de_rmw(display, XELPDP_PORT_BUF_CTL2(display, port), - lane_phy_pulse_status, - lane_phy_pulse_status); - /* - * 15. Clear the PHY VDR register 0xCC4[Rate Control VDR Update] over PHY message bus for - * Owned PHY Lanes. - */ - rate_update = intel_lt_phy_read(encoder, INTEL_LT_PHY_LANE0, LT_PHY_RATE_UPDATE); - rate_update &= ~LT_PHY_RATE_CONTROL_VDR_UPDATE; - intel_lt_phy_write(encoder, owned_lane_mask, LT_PHY_RATE_UPDATE, - rate_update, MB_WRITE_COMMITTED); - - /* 16. Poll for PORT_BUF_CTL2 register PHY Pulse Status = 1 for Owned PHY Lanes. */ - if (intel_de_wait_custom(display, XELPDP_PORT_BUF_CTL2(display, port), - lane_phy_pulse_status, lane_phy_pulse_status, - XE3PLPD_RATE_CALIB_DONE_LATENCY_US, 2, NULL)) - drm_warn(display->drm, "PHY %c PLL rate not changed after %dus.\n", - phy_name(phy), XE3PLPD_RATE_CALIB_DONE_LATENCY_US); - - /* 17. SW clears PORT_BUF_CTL2 [PHY Pulse Status]. */ - intel_de_rmw(display, XELPDP_PORT_BUF_CTL2(display, port), - lane_phy_pulse_status, - lane_phy_pulse_status); - /* * 18. Follow the Display Voltage Frequency Switching - Sequence After Frequency Change. * We handle this step in bxt_set_cdclk() -- 2.34.1