Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6960CCF9F1 for ; Tue, 28 Oct 2025 23:50:11 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vDtQc-0001fD-UZ; Tue, 28 Oct 2025 19:48:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vDtQa-0001ds-IY for qemu-devel@nongnu.org; Tue, 28 Oct 2025 19:48:36 -0400 Received: from p-east1-cluster6-host3-snip4-10.eps.apple.com ([57.103.90.161] helo=outbound.ci.icloud.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vDtQQ-0004j2-Bg for qemu-devel@nongnu.org; Tue, 28 Oct 2025 19:48:36 -0400 Received: from outbound.ci.icloud.com (unknown [127.0.0.2]) by p00-icloudmta-asmtp-us-central-1k-20-percent-0 (Postfix) with ESMTPS id 8D8EE1801388; Tue, 28 Oct 2025 23:48:12 +0000 (UTC) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr; s=sig1; bh=BXosR+QmiYPxKcgmH8B1gUotbAyslFwkosNixTIrXb4=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:x-icloud-hme; b=EuEXYFDGlTRzKAX2LO2gwhClHmUPzkcl6LBhcy3n+TkdvK7NBlJItcUsFGFZ7/PW2+piIZmI21IC2X3CKf60MO+D9CjEIdbAaLjGn6vtw4rikSHCPARV+tw8w0apauCTVrgytOmttT48iRcGed4x1h+tBdyfPUh8t6N5b/QryXGx2y8G6dfj984ZmDxASuFgBshVxY1u68zcAlW9jQJ7cgvgneucn/keHLgtozGO9rh1R/tiP4drX3c618LPVk+tdaYmPXQyR8kb4axM+Q9fhPKEDKxeneIXNF0BGK85kLsW0IVrSNFf7oyL6mVawuNUIOs1eijyPwWC5GcovwKsuw== mail-alias-created-date: 1752046281608 Received: from localhost.localdomain (unknown [17.57.156.36]) by p00-icloudmta-asmtp-us-central-1k-20-percent-0 (Postfix) with ESMTPSA id 02A0F18034EA; Tue, 28 Oct 2025 23:48:09 +0000 (UTC) From: Mohamed Mediouni To: mohamed@unpredictable.fr, qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alexander Graf , Phil Dennis-Jordan , Peter Maydell , Paolo Bonzini , qemu-arm@nongnu.org, Richard Henderson , Pedro Barbuda Subject: [PATCH v9 00/27] WHPX support for Arm Date: Wed, 29 Oct 2025 00:47:30 +0100 Message-ID: <20251028234757.39609-1-mohamed@unpredictable.fr> X-Mailer: git-send-email 2.50.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: KHXbkstpAnkfOWt9WCknBwmk1h5L8SYq X-Authority-Info: v=2.4 cv=CL0nnBrD c=1 sm=1 tr=0 ts=6901563d cx=c_apl:c_pps a=2G65uMN5HjSv0sBfM2Yj2w==:117 a=2G65uMN5HjSv0sBfM2Yj2w==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=NEAV23lmAAAA:8 a=O9Axi1gB8CqH0_GV9tkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cPQSjfK2_nFv0Q5t_7PE:22 X-Proofpoint-GUID: KHXbkstpAnkfOWt9WCknBwmk1h5L8SYq X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDI4MDIwMiBTYWx0ZWRfX4sTtx0b+fzSF GwOoRKfKCUdTMDvoJ/AJwLYH99hsjtT347Sx5gkfZAdjSUSrZURcNSNenVOeS4O0egcOLnwGcQm C21nBAal63t0UT4w6/QIECImW4forAAwl9i8leuGL4dKFbxdYdOG0Nn4bMGkaytr17Zt5dRkkqd /Bi46OXuV9sMk8IhEBB8AwmVus8OzkfpGtouspZVE0TVGDrfvc/UPyUaUZolLwXW9oIotV1NAeg zgTCQOj1PmNNk7vcG9Ykvv0ziAUSt4bPd+TXj/s/SZS//eP7aqOarnRKnIO/sN1IUWLCaqrYGsi OzdczRnKAOXSkZqI795 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-28_09,2025-10-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 clxscore=1030 suspectscore=0 phishscore=0 adultscore=0 mlxscore=0 malwarescore=0 mlxlogscore=999 classifier=spam authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2509250000 definitions=main-2510280202 X-JNJ: AAAAAAABwKWiRzlH6Zse8PyJqRA85P76bYEdLVfYVTUtbemGgYrMYs8bCSJAnVqMAXZrZYrQKgm5yw83qPyFjIicEyYHF2H81dBvs+GSf31J7IBK3fZ7JrsENEFIIQS3/uxKb3nU+ynH8i7Ax7a2tS/MhiY9mNHcFwfoXiwW0VXS4ZdR6M7ncq/D9jj3UVDRdhZ3+TrnSWqFZvI/y16uH0qpqp58Ma5U7qDxAVnOlCClgIXtd8yPJ9c3sy6UN/PJmutNPLt17VWUL5ZMJfmd3hZAGegBIydJQFC7PbYk2luPPmuGeqyi10CEjtcTBp3qJMjjiJ6HMk7vsSmUJFizWJYJ5TZihAmDrKc72GPT9ZP34obj28YTeTeacwJskmsW2dzPRyR0casKp8tGrqdHKZlOxkIIxb7kZ8h3EpCdI/FDokxx/zjYg5pYMlD12J87P4HPtoc7E2/LO5mJbfIYi+KJDLJngVgqzED6p8YM0UZbwBWtwuXYk3X+1aWbN2vl9UKzfgu4hi6npqv2H8xTfML+fOWKoUjY2tSPNlCA2BzEKqjdR4Gj6Lt7F1OGTXeWGvnB6UzgAP1ZLlpARklNpve6rgp1Atemp5de7KUBfS/1kwgOkU4xGhHtVQ6mKz+w2uVIdbZsBdAqR0ENfyp/9tShcaAc7LHaYgRpwSdLkiKeKNcAhPu08Zo0s5brf890wyDHLOXD3JO8gbU+N1TdOu3KY2SCPzPun55k/4R2asit/bRc86Tjmcvv5rf7G/A= Received-SPF: pass client-ip=57.103.90.161; envelope-from=mohamed@unpredictable.fr; helo=outbound.ci.icloud.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Link to branch: https://github.com/mediouni-m/qemu whpx (tag for this submission: whpx-v10) Missing features: - PSCI state sync with Hyper-V - Interrupt controller save-restore: As such, save/restore of VM state is currently blocked. - SVE register sync: I didn't have the time to test this on pre-release hardware with SVE2 support yet. Known bugs: - reboots are currently broken - U-Boot still doesn't work (hangs when trying to parse firmware) but EDK2 does. Note: "target/arm/kvm: add constants for new PSCI versions" taken from the mailing list. "accel/system: Introduce hwaccel_enabled() helper" taken from the mailing list, added here as part of this series to make it compilable as a whole. "hw/arm: virt: add GICv2m for the case when ITS is not available" present in both the HVF vGIC and this series. And another note: Seems that unlike HVF there isn't direct correspondence between WHv registers and the actual register layout, so didn't do changes there to a sysreg.inc. And yet another note: Would it be acceptable to have reboots handled as shutdowns for the initial merge? Looks to me that due to Qemu changes, reboots regressed further and don't work even for single-core VMs now... Updates since v9: - v9 and v8 were not submitted properly because of my MTA not behaving, sorry for that. - v10 introduces a new argument, -M msi=, to handle MSI-X configuration more granularly. - That surfaced what I think is a bug (?), with vms->its=1 on GICv2 configurations... or I did understand everything wrong. Updates since v8: - Oopsie due to email provider ratelimiting. Updates since v7: - Oops, fixing bug in "hw/arm: virt: cleanly fail on attempt to use the platform vGIC together with ITS". Other commits are unchanged. Updates since v6: - Rebasing - Fixing a bug in the GICv3+GICv2m case for ACPI table generation - getting rid of the slots infrastructure for memory management - Place the docs commit right after the "cleanly fail on attempt to run GICv3+GICv2m on an unsupported config" one as that's what switches ITS to a tristate. - Fixing a build issue when getting rid of the arch-specific arm64 hvf-stub. Updates since v5: - Rebasing - Address review comments - Rework ITS enablement to a tristate - On x86: move away from deprecated APIs to get/set APIC state Updates since v4: - Taking into account review comments - Add migration blocker in the vGICv3 code due to missing interrupt controller save/restore - Debug register sync Updates since v3: - Disabling SVE on WHPX - Taking into account review comments incl: - fixing x86 support - reduce the amount of __x86_64__ checks in common code to the minimum (winhvemulation) which can be reduced even further down the road. - generalize get_physical_address_range into something common between hvf and whpx Updates since v2: - Fixed up a rebase screwup for whpx-internal.h - Fixed ID_AA64ISAR1_EL1 and ID_AA64ISAR2_EL1 feature probe for -cpu host - Switched to ID_AA64PFR1_EL1/ID_AA64DFR0_EL1 instead of their non-AA64 variant Updates since v1: - Shutdowns and reboots - MPIDR_EL1 register sync - Fixing GICD_TYPER_LPIS value - IPA size clamping - -cpu host now implemented Mohamed Mediouni (25): qtest: hw/arm: virt: skip ACPI test for ITS off hw/arm: virt: add GICv2m for the case when ITS is not available tests: data: update AArch64 ACPI tables whpx: Move around files before introducing AArch64 support whpx: reshuffle common code whpx: ifdef out winhvemulation on non-x86_64 whpx: common: add WHPX_INTERCEPT_DEBUG_TRAPS define hw, target, accel: whpx: change apic_in_platform to kernel_irqchip whpx: interrupt controller support whpx: add arm64 support whpx: change memory management logic target/arm: cpu: mark WHPX as supporting PSCI 1.3 hw/arm: virt: cleanly fail on attempt to use the platform vGIC together with ITS hw: arm: virt: rework MSI-X configuration hw: arm: virt-acpi-build: add hack docs: arm: update virt machine model description whpx: arm64: clamp down IPA size hw/arm, accel/hvf, whpx: unify get_physical_address_range between WHPX and HVF whpx: arm64: implement -cpu host target/arm: whpx: instantiate GIC early whpx: arm64: gicv3: add migration blocker whpx: enable arm64 builds MAINTAINERS: update maintainers for WHPX whpx: apic: use non-deprecated APIs to control interrupt controller state whpx: arm64: check for physical address width after WHPX availability Philippe Mathieu-Daudé (1): accel/system: Introduce hwaccel_enabled() helper Sebastian Ott (1): target/arm/kvm: add constants for new PSCI versions MAINTAINERS | 11 +- accel/hvf/hvf-all.c | 7 +- accel/meson.build | 1 + accel/whpx/meson.build | 7 + {target/i386 => accel}/whpx/whpx-accel-ops.c | 6 +- accel/whpx/whpx-common.c | 548 +++++++++ docs/system/arm/virt.rst | 10 +- hw/arm/virt-acpi-build.c | 16 +- hw/arm/virt.c | 132 ++- hw/i386/x86-cpu.c | 4 +- hw/intc/arm_gicv3_common.c | 3 + hw/intc/arm_gicv3_whpx.c | 249 ++++ hw/intc/meson.build | 1 + include/hw/arm/virt.h | 8 +- include/hw/boards.h | 3 +- include/hw/intc/arm_gicv3_common.h | 3 + include/system/hvf_int.h | 2 + include/system/hw_accel.h | 13 + .../whpx => include/system}/whpx-accel-ops.h | 4 +- include/system/whpx-all.h | 20 + include/system/whpx-common.h | 26 + .../whpx => include/system}/whpx-internal.h | 23 +- include/system/whpx.h | 4 +- meson.build | 20 +- target/arm/cpu.c | 3 + target/arm/cpu64.c | 19 +- target/arm/hvf-stub.c | 20 - target/arm/hvf/hvf.c | 6 +- target/arm/hvf_arm.h | 3 - target/arm/kvm-consts.h | 2 + target/arm/meson.build | 2 +- target/arm/whpx/meson.build | 5 + target/arm/whpx/whpx-all.c | 1018 +++++++++++++++++ target/arm/whpx/whpx-stub.c | 15 + target/arm/whpx_arm.h | 17 + target/i386/cpu-apic.c | 2 +- target/i386/hvf/hvf.c | 11 + target/i386/whpx/meson.build | 1 - target/i386/whpx/whpx-all.c | 569 +-------- target/i386/whpx/whpx-apic.c | 48 +- tests/data/acpi/aarch64/virt/APIC.its_off | Bin 164 -> 188 bytes 41 files changed, 2212 insertions(+), 650 deletions(-) create mode 100644 accel/whpx/meson.build rename {target/i386 => accel}/whpx/whpx-accel-ops.c (96%) create mode 100644 accel/whpx/whpx-common.c create mode 100644 hw/intc/arm_gicv3_whpx.c rename {target/i386/whpx => include/system}/whpx-accel-ops.h (92%) create mode 100644 include/system/whpx-all.h create mode 100644 include/system/whpx-common.h rename {target/i386/whpx => include/system}/whpx-internal.h (89%) delete mode 100644 target/arm/hvf-stub.c create mode 100644 target/arm/whpx/meson.build create mode 100644 target/arm/whpx/whpx-all.c create mode 100644 target/arm/whpx/whpx-stub.c create mode 100644 target/arm/whpx_arm.h -- 2.50.1 (Apple Git-155)