Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B11EACCF9E3 for ; Fri, 7 Nov 2025 08:32:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4BE0F10EA3D; Fri, 7 Nov 2025 08:32:16 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="ZxVkFu98"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id E866610EA3D for ; Fri, 7 Nov 2025 08:32:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1762504335; x=1794040335; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=pRichPbMbq/rKFXraVP7Db3S2TkkCGxQgI22uTa0JVc=; b=ZxVkFu987TL7dq+54wGNOqx/AlPCMZCW3RZBeaNLKbzKTwC/EJdb+A2k oj+qvOp7vxVxZHmrXODA4fMEKICHkOkd5EWwi5fVuWpaBPq0oyOhqAEQD lQTLLhYMtddW/vWcbOS+9k+9EqbNsp/a7ffZ8tp7r7HLWdYTqSnUUJN+B oQC05TuD4NBxZV73r4mI9G7BLZomeETtRZKUwJMrCWOymT2TAHNUyIVlk 2uXaM25r6rnoVt46ViX7qXB3pDR29g5L4DUfpPE7S6HUxdfZvi9lUfkqo Y/bSLw6GSPgXqFGewzoPU6dEqcYBgtk0cZxaZzvya0JB/q6dMOozIzpOI A==; X-CSE-ConnectionGUID: lgFB7kjITDesJ7tzwVi5sw== X-CSE-MsgGUID: 44Q1/PPKSYO/9hTyRDSpOw== X-IronPort-AV: E=McAfee;i="6800,10657,11605"; a="63860050" X-IronPort-AV: E=Sophos;i="6.19,286,1754982000"; d="scan'208";a="63860050" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Nov 2025 00:32:15 -0800 X-CSE-ConnectionGUID: /MQ0sB6KTl6iZEk995fZmA== X-CSE-MsgGUID: Z8nbpe9QSeuBGXt0h9ZEdg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,286,1754982000"; d="scan'208";a="211427675" Received: from dut2943pvc.iind.intel.com ([10.190.215.39]) by fmviesa002.fm.intel.com with ESMTP; 07 Nov 2025 00:32:13 -0800 From: nishit.sharma@intel.com To: igt-dev@lists.freedesktop.org, zbigniew.kempczynski@intel.com, nishit.sharma@intel.com Subject: [PATCH i-g-t v13 1/3] lib/intel_compute: loop_kernel_duration in Pipeline Date: Fri, 7 Nov 2025 08:32:08 +0000 Message-ID: <20251107083210.65425-2-nishit.sharma@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251107083210.65425-1-nishit.sharma@intel.com> References: <20251107083210.65425-1-nishit.sharma@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" From: Nishit Sharma Incase of multi-ccs it is expected that all ccs engines will be busy. There's no existing code which keeps GPU busy for a specified duration, So we need to terminate loop kernel from CPU after the desired time has elapsed. Introduce the loop_kernel_duration variable to control kernel execution duration in compute pipelines. Currently this is supported in xe2lg and xe3lpg pipelines. Signed-off-by: Nishit Sharma Reviewed-by: Zbigniew KempczyƄski --- lib/intel_compute.c | 26 +++++++++++++++++++++++++- lib/intel_compute.h | 2 ++ 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/lib/intel_compute.c b/lib/intel_compute.c index 147dd2916..8d632269c 100644 --- a/lib/intel_compute.c +++ b/lib/intel_compute.c @@ -849,6 +849,9 @@ static void compute_exec(int fd, const unsigned char *kernel, uint16_t devid = intel_get_drm_devid(fd); int entries = ARRAY_SIZE(bo_dict); + if (user && (user->kernel || user->loop_kernel_duration)) + igt_skip("Pipeline doesn't support loop_kernel\n"); + bo_execenv_create(fd, &execenv, eci, user); /* Set dynamic sizes */ @@ -1131,6 +1134,9 @@ static void xehp_compute_exec(int fd, const unsigned char *kernel, uint64_t bind_output_addr = (user && user->output_addr) ? user->output_addr : ADDR_OUTPUT; int entries = ARRAY_SIZE(bo_dict); + if (user && (user->kernel || user->loop_kernel_duration)) + igt_skip("Pipeline doesn't support loop_kernel\n"); + bo_execenv_create(fd, &execenv, eci, user); /* Set dynamic sizes */ @@ -1343,6 +1349,9 @@ static void xehpc_compute_exec(int fd, const unsigned char *kernel, uint64_t bind_output_addr = (user && user->output_addr) ? user->output_addr : ADDR_OUTPUT; int entries = ARRAY_SIZE(bo_dict); + if (user && (user->kernel || user->loop_kernel_duration)) + igt_skip("Pipeline doesn't support loop_kernel\n"); + bo_execenv_create(fd, &execenv, eci, user); /* Set dynamic sizes */ @@ -1731,6 +1740,9 @@ static void xelpg_compute_exec(int fd, const unsigned char *kernel, uint64_t bind_output_addr = (user && user->output_addr) ? user->output_addr : ADDR_OUTPUT; int entries = ARRAY_SIZE(bo_dict); + if (user && (user->kernel || user->loop_kernel_duration)) + igt_skip("Pipeline doesn't support loop_kernel\n"); + bo_execenv_create(fd, &execenv, eci, user); /* Set dynamic sizes */ @@ -1818,6 +1830,7 @@ static void xe2lpg_compute_exec(int fd, const unsigned char *kernel, uint64_t bind_input_addr = (user && user->input_addr) ? user->input_addr : ADDR_INPUT; uint64_t bind_output_addr = (user && user->output_addr) ? user->output_addr : ADDR_OUTPUT; int entries = ARRAY_SIZE(bo_dict); + int64_t timeout_one_ns = 1; bo_execenv_create(fd, &execenv, eci, user); @@ -1849,7 +1862,18 @@ static void xe2lpg_compute_exec(int fd, const unsigned char *kernel, OFFSET_KERNEL, 0, false, execenv.array_size); - bo_execenv_exec(&execenv, ADDR_BATCH); + if (user && user->loop_kernel_duration) { + bo_execenv_exec_async(&execenv, ADDR_BATCH); + igt_measured_usleep(user->loop_kernel_duration); + /* Check that the loop kernel has not completed yet */ + igt_assert_neq(0, __xe_wait_ufence(fd, &execenv.bo_sync->sync, USER_FENCE_VALUE, + execenv.exec_queue, &timeout_one_ns)); + ((int *)bo_dict[4].data)[0] = MAGIC_LOOP_STOP; + bo_execenv_sync(&execenv); + user->skip_results_check = 1; + } else { + bo_execenv_exec(&execenv, ADDR_BATCH); + } if (!user || (user && !user->skip_results_check)) bo_check_square(input_data, output_data, execenv.array_size); diff --git a/lib/intel_compute.h b/lib/intel_compute.h index 412791d07..54a1c7f82 100644 --- a/lib/intel_compute.h +++ b/lib/intel_compute.h @@ -63,6 +63,8 @@ struct user_execenv { uint64_t input_addr; /** @output_addr: override default address of the output array if provided */ uint64_t output_addr; + /** @loop_kernel_duration: duration till kernel should execute in gpu **/ + uint64_t loop_kernel_duration; }; enum execenv_alloc_prefs { -- 2.43.0