Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC20A29BD95 for ; Wed, 12 Nov 2025 12:03:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762948990; cv=none; b=GwEybNwEWhWYE/q0QA/NiuzC5YaqVCf867P/whSmQiTU6fyySGcilnAr56LTjC7LMDFVcFK75IORD8z+a3hwTrwe1CFbNM7xpBcddA1XY83D66kue+Cj5u37UDwAAjHlY75D0IjkjZi+MxwwaaVGrXOy2sph1ncyj1D5eCuktcQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762948990; c=relaxed/simple; bh=dmywMDxYR3I/zwmn8fb6UkL+Z5wEfHZ3kih2ppTvlI8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=OcBlxrM6iumFgQXrWWFgPnpkO89c92f7GPgxrdgMCM5zYJFSpRbOK7/GkUzRdPv1BUi+OFJTJRWs1HasRxmA6YpBXshMg4FNRzm7nldoDtZ+7LkSrIVmZywsHMkhnH2OVrrqvjjuUYv94/pzidjraJm1EWwfRtgXjJzE7p4naZI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WOo9g99c; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WOo9g99c" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-7aa9be9f03aso714062b3a.2 for ; Wed, 12 Nov 2025 04:03:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762948988; x=1763553788; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=otVWZ64buPz8pDhvcNsi4ASjJ/PcM+ziHnstNNH1WqQ=; b=WOo9g99cEqZ+pHEMAqPPipeiCL84lfSDjNbXn0eqRMc7JMLZk5X/2zq1NSt3xke2k6 cvQOKQK7sy0+uw6clivFQBKoP+bK8EP778bTvvowhPPQnc2oyQ8pM1vdHomT5f0n+nYS 095FMQ9jniny5Wq90n9/aKz3/ZqtZiW6C2PZHip7y4nRHmrUO522s6BVx1WrVLM2vqTq G4axJieNwSCeyTNG84aFaPosah08Q6iYvXPpRQx9nGY9jy+SXMhSEt5vzVaeNE34dV/l kF+5M28kalanNo5ZrzJFQRyATqTdT4MZJaQrvj4LRJcNUP57J+EHg35yGd+8nDyhVM50 dcAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762948988; x=1763553788; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=otVWZ64buPz8pDhvcNsi4ASjJ/PcM+ziHnstNNH1WqQ=; b=fRFBo3ZaAI6VeFNH932fcPjRLnqatg/Xw5rZvipG0OJQYYQAcEV1xgP87iReZczb9O 067LBV+onj2wFoBkGsdCadmoBpRi7vYExlsHFx5+VyOeaxO9a2ioDPF0dxo2wAHLYqHr 3n2o75ke8sA5Ohqk79PvP2xCSPVOlHpVMKThNXBx137qFTRWM59tLxBbAZlcpfaLdpuT lON7yebxLvuI5WWvc8F6LNh2ZYvxx1rYENRhQOqiO8G9RZ4lzUKxsX2/pI1yY5batdo+ 9srMaCu5gvbfv740lYm0Sp+EqBuuQiBxpsi/ffSMDeBRefTsvRM0t/q5nkA6Y5vAfILW kNgw== X-Gm-Message-State: AOJu0Yw5l2j0khDJi1I57TtYfIfiDDF3sqwjuyidwr7IIkI+A6WU/el6 bNkHdvwMrdb8rWgg5Nvc2wkQNG4ZT4Iv2+w6Qwtt8zxy9aMmakqKpTLp X-Gm-Gg: ASbGncvis8jHJb9oYCKoROihiDSeCWIJ7cqEYN7uPpz113CX1RgPpbO+NIE9b+EdHax zLDnggnROHHEEjkwruZHOjglVr83ZvqMjSe7jprpBLhwxwCvxwELxChg5IRPFevQF3bXaeXeVUQ DbvF0AD7jSXdw5sLbh4xNQcq6JMZfN9jAs/mmktv9zS7SI/f0T9CocuIfmRW3x7ZxF7TC0sjUSD FlrmjlMoRW1EB4wijzuD1SPwil6MDxmU6DXyIf78qnIRCT2QWvZIYaM1Yn+Bx7Rik1E1WHeB4Sk 6d2qK99d7S+bK/8xLo1mBTtUG9yrWMhBf1HosXGsi8rN21BX+i15/L38+BETfbddTYgVWeeH0Av WIWUQ/yZUjUadljSWJ5g6WAipbexHz8jy810gC42IxGgKZU5jUndPXH31mQ+VBn4CgQ== X-Google-Smtp-Source: AGHT+IF4hw2zR9LkezHiZj+TQdW5+kwzMar8ofxTlchBLpk94hK/dhLo2AjVNSCvpazqsVsABOfrRA== X-Received: by 2002:a05:6a00:4b4e:b0:781:157b:3d2e with SMTP id d2e1a72fcca58-7b7a4afa3afmr2857131b3a.21.1762948988116; Wed, 12 Nov 2025 04:03:08 -0800 (PST) Received: from oslab.. ([2402:f000:4:1006:809:ffff:fffe:18ea]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7b0cc17a688sm18738044b3a.40.2025.11.12.04.03.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Nov 2025 04:03:07 -0800 (PST) From: Tuo Li To: krzysztof.czurylo@intel.com, tatyana.e.nikolova@intel.com, jgg@ziepe.ca, leon@kernel.org Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Tuo Li Subject: [PATCH] RDMA/irdma: Remove redundant NULL check of udata in irdma_create_user_ah() Date: Wed, 12 Nov 2025 20:02:53 +0800 Message-ID: <20251112120253.68945-1-islituo@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The variable udata cannot be NULL because irdma_create_user_ah() always receives it. Therefore, the if() check can be safely removed. Thank Leon Romanovsky for helpful advice. Signed-off-by: Tuo Li --- drivers/infiniband/hw/irdma/verbs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/irdma/verbs.c b/drivers/infiniband/hw/irdma/verbs.c index c883c9ea5a83..a9ae5a38d03d 100644 --- a/drivers/infiniband/hw/irdma/verbs.c +++ b/drivers/infiniband/hw/irdma/verbs.c @@ -5204,7 +5204,7 @@ static int irdma_create_user_ah(struct ib_ah *ibah, struct irdma_ah *parent_ah; int err; - if (udata && udata->outlen < IRDMA_CREATE_AH_MIN_RESP_LEN) + if (udata->outlen < IRDMA_CREATE_AH_MIN_RESP_LEN) return -EINVAL; err = irdma_setup_ah(ibah, attr); -- 2.43.0