Received: from 004.mia.mailroute.net (004.mia.mailroute.net [199.89.3.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0169B353881 for ; Thu, 13 Nov 2025 17:42:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=199.89.3.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763055746; cv=none; b=gOb9KVsl8/32DWIrc8aQJUSypjIvupcUMUiYgI9AJ4gch49QioFpkGx8r5qptZw/pk3HSW+91TDvn2hJb62Mzlz2hvIg3/AgWrz/tIxSQoJPr37PN2GwLBXZbQl0Fdt1dQa4GdAAmVISqQR2SHl2dKK9KtR7Zy7u8Db26JCKQ8o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763055746; c=relaxed/simple; bh=7JLb1b743rxHeHlT4NEIStGTJuc6Og7ZjZ0ejWFSGKM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=f+V0DZFO0Ntrr9wg2sJ2a2q3DG8m6UpHwBkeBUnVrga+4ozgXO6P8u9s4mA7wbmrB3YfrxPqasauOHY5SB0Rj/7PnO7S22BnIm9lRJCTYUjahslTN73Shj3FdcjrXMx+WuxXrTudXSwc2IBk26ebQp9+RFrKCDggkev5e+CNWew= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org; spf=pass smtp.mailfrom=acm.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b=ceYyPuhL; arc=none smtp.client-ip=199.89.3.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=acm.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b="ceYyPuhL" Received: from localhost (localhost [127.0.0.1]) by 004.mia.mailroute.net (Postfix) with ESMTP id 4d6nf24BGmzm17G1; Thu, 13 Nov 2025 17:42:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:mime-version:x-mailer:message-id:date :date:subject:subject:from:from:received:received; s=mr01; t= 1763055736; x=1765647737; bh=8w2tOLObOdOs7dzUA2qSFLiJsGnqIr2Otis RlphmbA0=; b=ceYyPuhLP2+EwMHKDoQhVfD29aY2UBOWeQJn66wmKlDIkVG5qMR +5k6Usqt7woVQMrYnQdabdGDkEWIjffRIzCWNfpVuL7Xw1CGQmvz3OtExSLNgFiO 2Rm8bAkG6D2KJ2FGH1v34sv+mRoMPQ3ZMNa7wnSQp9BAB/jnlUFmI0HjA+y3vtzm 0i9df6lTGcIBgovnKXFWDxFtiG0X781esXV6DTT0JaE+1QvMLUlIIRmVha+9qu6U eT9dC75fw03UytitbTXqtY5JuaWoAs+QJtJaZwM808ouh8WcsfhBvOnmZDNP/roj Nxd2S5WrBI3lC2FnCN6zoMYpsI/FGCKogGg== X-Virus-Scanned: by MailRoute Received: from 004.mia.mailroute.net ([127.0.0.1]) by localhost (004.mia [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id 265ilpYtZG3u; Thu, 13 Nov 2025 17:42:16 +0000 (UTC) Received: from bvanassche.mtv.corp.google.com (unknown [104.135.180.219]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 004.mia.mailroute.net (Postfix) with ESMTPSA id 4d6ndv6kRDzm17x3; Thu, 13 Nov 2025 17:42:11 +0000 (UTC) From: Bart Van Assche To: "Martin K . Petersen" Cc: linux-scsi@vger.kernel.org, Bart Van Assche , Douglas Gilbert , Damien Le Moal , Christoph Hellwig , Ming Lei , "James E.J. Bottomley" Subject: [PATCH] scsi: scsi_debug: Support injecting unaligned write errors Date: Thu, 13 Nov 2025 09:41:51 -0800 Message-ID: <20251113174151.1095574-1-bvanassche@acm.org> X-Mailer: git-send-email 2.51.2.1041.gc1ab5b90ca-goog Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Allow user space software, e.g. a blktests test, to inject unaligned write errors. Acked-by: Douglas Gilbert Reviewed-by: Damien Le Moal Cc: Martin K. Petersen Cc: Christoph Hellwig Cc: Ming Lei Signed-off-by: Bart Van Assche --- drivers/scsi/scsi_debug.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c index 03e1a93d90e9..33ff6c46df8e 100644 --- a/drivers/scsi/scsi_debug.c +++ b/drivers/scsi/scsi_debug.c @@ -230,6 +230,7 @@ struct tape_block { #define SDEBUG_OPT_NO_CDB_NOISE 0x4000 #define SDEBUG_OPT_HOST_BUSY 0x8000 #define SDEBUG_OPT_CMD_ABORT 0x10000 +#define SDEBUG_OPT_UNALIGNED_WRITE 0x20000 #define SDEBUG_OPT_ALL_NOISE (SDEBUG_OPT_NOISE | SDEBUG_OPT_Q_NOISE | \ SDEBUG_OPT_RESET_NOISE) #define SDEBUG_OPT_ALL_INJECTING (SDEBUG_OPT_RECOVERED_ERR | \ @@ -237,7 +238,8 @@ struct tape_block { SDEBUG_OPT_DIF_ERR | SDEBUG_OPT_DIX_ERR | \ SDEBUG_OPT_SHORT_TRANSFER | \ SDEBUG_OPT_HOST_BUSY | \ - SDEBUG_OPT_CMD_ABORT) + SDEBUG_OPT_CMD_ABORT | \ + SDEBUG_OPT_UNALIGNED_WRITE) #define SDEBUG_OPT_RECOV_DIF_DIX (SDEBUG_OPT_RECOVERED_ERR | \ SDEBUG_OPT_DIF_ERR | SDEBUG_OPT_DIX_ERR) =20 @@ -4933,6 +4935,14 @@ static int resp_write_dt0(struct scsi_cmnd *scp, s= truct sdebug_dev_info *devip) u8 *cmd =3D scp->cmnd; bool meta_data_locked =3D false; =20 + if (unlikely(sdebug_opts & SDEBUG_OPT_UNALIGNED_WRITE && + atomic_read(&sdeb_inject_pending))) { + atomic_set(&sdeb_inject_pending, 0); + mk_sense_buffer(scp, ILLEGAL_REQUEST, LBA_OUT_OF_RANGE, + UNALIGNED_WRITE_ASCQ); + return check_condition_result; + } + switch (cmd[0]) { case WRITE_16: ei_lba =3D 0;