Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5521778F3A for ; Thu, 18 Dec 2025 13:57:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766066256; cv=none; b=MmHGf+O/zK34GSJcbek9QhCKmmyds8IeLHRyu2RrEGl9aEkqcYCIOdue0u44xiRtx395RjvyyG1AizwqQS3BnqkDLO+gHL+KUUwQ7ookOVgOF/VB/XYTaa3Vk1BteD/dYVhBN3ezglJJ0pJ6zNtPHQM2BERhRb21YxXmJ0UHFrI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766066256; c=relaxed/simple; bh=TUi1XLXqFkbPSlOVui7RodZpmNn+OnG5S5kzEqNvMrI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LLQrmbJxrkZW1uMCEuqtfXc7FbxSRyQgZwP4eDYXvhfnGFKXulDpyZc5WUAEps3iXIVCD7ENwOcAc6CjuPEgEb0J+2em9PY7szmMn6hx4zs6vVEPdqszIMSw7yTJXW5qEFy9ut/MY584RZhC6O2NRJL2QNwIYqkOQ8nXoTRnFz8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=oSXRkYg1; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=zIsJ7e+j; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=oSXRkYg1; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=zIsJ7e+j; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="oSXRkYg1"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="zIsJ7e+j"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="oSXRkYg1"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="zIsJ7e+j" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2B4C0336EE; Thu, 18 Dec 2025 13:57:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1766066251; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Md/pNfEVJkh+eR3NYlgXhoFWh0V2+Lat75ohvo7my3k=; b=oSXRkYg1L/2d3QBR27I5MTqN6QJdlC1El8KgTJXYLuZhJXtauhz8Uslgt0jQ763zyfAN2y x9PesbpIEfzV1iERzB20YqTIcKyvOfiRTNAi+36L2ffPO9TDoOpYZCAryUWPnNQSg8pZWM XwjMtPB/QJewu3Zoh28ayvOP4Xrhkz8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1766066251; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Md/pNfEVJkh+eR3NYlgXhoFWh0V2+Lat75ohvo7my3k=; b=zIsJ7e+jm27gyYzaxcIL8MNxjikoNUOE/+k32YdXwkpg+b5v2lO/BGCLhrkqP8InFMTsbe bVpuNwmu8llaxEAQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=oSXRkYg1; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=zIsJ7e+j DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1766066251; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Md/pNfEVJkh+eR3NYlgXhoFWh0V2+Lat75ohvo7my3k=; b=oSXRkYg1L/2d3QBR27I5MTqN6QJdlC1El8KgTJXYLuZhJXtauhz8Uslgt0jQ763zyfAN2y x9PesbpIEfzV1iERzB20YqTIcKyvOfiRTNAi+36L2ffPO9TDoOpYZCAryUWPnNQSg8pZWM XwjMtPB/QJewu3Zoh28ayvOP4Xrhkz8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1766066251; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Md/pNfEVJkh+eR3NYlgXhoFWh0V2+Lat75ohvo7my3k=; b=zIsJ7e+jm27gyYzaxcIL8MNxjikoNUOE/+k32YdXwkpg+b5v2lO/BGCLhrkqP8InFMTsbe bVpuNwmu8llaxEAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 1CD733EA63; Thu, 18 Dec 2025 13:57:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id eVbXBksIRGmkCgAAD6G6ig (envelope-from ); Thu, 18 Dec 2025 13:57:31 +0000 Date: Thu, 18 Dec 2025 14:57:25 +0100 From: David Sterba To: Zhen Ni Cc: clm@fb.com, dsterba@suse.com, wqu@suse.com, linux-btrfs@vger.kernel.org Subject: Re: [PATCH] btrfs: remove assertions after btrfs_bio struct changes Message-ID: <20251218135725.GO3195@suse.cz> Reply-To: dsterba@suse.cz References: <20251218122215.1044381-1-zhen.ni@easystack.cn> Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251218122215.1044381-1-zhen.ni@easystack.cn> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) X-Spamd-Result: default: False [-4.21 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; HAS_REPLYTO(0.30)[dsterba@suse.cz]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.998]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; DKIM_TRACE(0.00)[suse.cz:+]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_TWO(0.00)[2]; REPLYTO_ADDR_EQ_FROM(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; REPLYTO_DOM_NEQ_TO_DOM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.cz:mid,suse.cz:dkim,suse.cz:replyto] X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spam-Level: X-Rspamd-Queue-Id: 2B4C0336EE X-Spam-Flag: NO X-Spam-Score: -4.21 On Thu, Dec 18, 2025 at 08:22:15PM +0800, Zhen Ni wrote: > Commit 81cea6cd7041 ("btrfs: remove btrfs_bio::fs_info by extracting it > from btrfs_bio::inode") modified the btrfs_bio structure to make the > inode field mandatory, making these assertions redundant: > > - btrfs_check_read_bio(): inode is validated by btrfs_bio_init() > - btrfs_submit_bbio(): condition always passes since inode is never NULL > > Remove these obsolete checks. The assertions may be redundant and their purpose is to catch accidental changes to code or explicitly list some critical assumptions. We'd like to have more rather than fewer of them.