Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E0DAE92FE3 for ; Tue, 30 Dec 2025 00:04:43 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vaNE1-00065X-Kb; Mon, 29 Dec 2025 19:04:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vaNDx-00064W-Tn for qemu-arm@nongnu.org; Mon, 29 Dec 2025 19:04:30 -0500 Received: from p-east2-cluster5-host2-snip4-5.eps.apple.com ([57.103.79.18] helo=outbound.st.icloud.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vaNDv-0003aU-2G for qemu-arm@nongnu.org; Mon, 29 Dec 2025 19:04:29 -0500 Received: from outbound.st.icloud.com (unknown [127.0.0.2]) by p00-icloudmta-asmtp-us-east-1a-60-percent-9 (Postfix) with ESMTPS id 10A301800107; Tue, 30 Dec 2025 00:04:18 +0000 (UTC) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr; s=sig1; bh=42tWLS+YYV+vLQu7KWW9+nxPqmlnDgndNrIXu1tAnj8=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:x-icloud-hme; b=dbSHrrwsKu6cbZ5X0Dd7FvHFhybYXfEQoXJYPsLOWRzCUsrqwm3nINT6BkT6GZlDN4X663KKmCkql/GbgkiwucT9XfbUG1d94M6JbRZ1GnBdVfSJfpNt1XPynwHzi10eDounY5T9F/07s1xJVT22AgOg8tEYh8Sk9JlbfLPk68AGe4256Un4iGr4Feppm6SACjPZGpwNnh0nhEEpE0jKlL37y1XjOXQSrsSf5TYSyLa0ZEh4Cj7lbzMX0WtLsYkcXxnfKmaRTj523wE2ukNoqzlmPnmBgIt0lR4vzSqKrV8Zewd3s/hijJstb6hHWuEYQ/8bmg/dIj3Mz83DHQpiDQ== mail-alias-created-date: 1752046281608 Received: from localhost.localdomain (unknown [17.42.251.67]) by p00-icloudmta-asmtp-us-east-1a-60-percent-9 (Postfix) with ESMTPSA id 556641800444; Tue, 30 Dec 2025 00:04:14 +0000 (UTC) From: Mohamed Mediouni To: mohamed@unpredictable.fr, qemu-devel@nongnu.org Cc: Yanan Wang , =?UTF-8?q?Alex=20Benn=C3=A9e?= , "Michael S. Tsirkin" , Akihiko Odaki , Eduardo Habkost , Mads Ynddal , Roman Bolshakov , Peter Xu , Shannon Zhao , Pedro Barbuda , Peter Maydell , Cameron Esfahani , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Igor Mammedov , Zhao Liu , Phil Dennis-Jordan , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Ani Sinha , Paolo Bonzini , Alexander Graf , Marcel Apfelbaum , Richard Henderson , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH v13 00/28] WHPX support for Arm Date: Tue, 30 Dec 2025 01:03:32 +0100 Message-ID: <20251230000401.72124-1-mohamed@unpredictable.fr> X-Mailer: git-send-email 2.50.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI5MDIyMiBTYWx0ZWRfX7OxenBxQMXYb 3iR95YBMPS5BvW76DUzhFhW6VckefPtdXCDfLp67QMXN2WJGcppmkY2LHu25p4vQWi/+GC1SPlA dIUPwG5gah4Shr6PyqOOgCDfieCkWvzZxGhD//3k1dxsFyDU8VdTHoayk1ngHjNvSeX93yPwDKI Whpz21sjT2hUo+McGFCZhangXpkqcRcMLdteSb/1T8HEUsjlPUisiKQJdHzBvvDkcD03qlCkYFP 4upHZwU/D5za6KVgSnPU/1+FRSXsabOkQMoteO2gFm0RvsaDcynoWdDL7ZW08zHCK+mU5TpgsAX rOt0NTV81gDUsAdT7b/ X-Authority-Info: v=2.4 cv=O600fR9W c=1 sm=1 tr=0 ts=69531705 cx=c_apl:c_pps a=YrL12D//S6tul8v/L+6tKg==:117 a=YrL12D//S6tul8v/L+6tKg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=VkNPw1HP01LnGYTKEx00:22 a=NEAV23lmAAAA:8 a=2CSUmbMKgiS_FIm3Z54A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: f15JX9kcK0MGQCtGPnOsV06FeGo1_efU X-Proofpoint-ORIG-GUID: f15JX9kcK0MGQCtGPnOsV06FeGo1_efU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-29_07,2025-12-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 malwarescore=0 spamscore=0 mlxscore=0 mlxlogscore=999 bulkscore=0 clxscore=1030 adultscore=0 classifier=spam authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512290222 X-JNJ: AAAAAAAB1AAY3F3hAL+BkYlwbNaSbpascQwbMprt9zNKEF34E4TAZS+P2YY8B7wyxAvi6xS58tZBAWzJm2vhijEL7n6VzpdNu9eC3XrtVrwt6pqL+p0qssDZIG5XLHUECpfCtEwX+bUb2ilJo1/Vu4i3fa11ruqxIAn85nSLmoLhNjDDKs0+IxNr6e+LeQq+T7Ljn5qez2ZARTFHb/2bvJgoop0uSqJ+4yIO6/Q/fIkmDNZYSgvqv4sOab4bDGqyxU+t2khMiBDssu7oOctRG+zDmklaYNzxfYk08hpkuWibTLMQzFCJgp8Mre5a5JjicuNB3TEnwEoeoE9P68fd9TWyI6v9DIjIPOAUbHHo36uMfSiXtTJ1MOJC+M8KGQPxxfF/2LHTKUk4l+2M7RcwJESqHFOPHvmIelv6MXM9YUghkxuE7QieMg1mI2aAkycA/nw5N/ogXfRwzGssJLlUdU/nxIlt+VLfmrtOe40axQVqA1t37ybvXz1wcQBxn7YrRAf8SVGaW+BgYD/LrbnVSAtiJN6JPDkkuyIGPRi2L04VfYeLYHjr7pToRc7wcvAplciH2S5Q87qc+XlQXN1Bx2gAwUJ8eM7DtrjcG2+fyVrNfbv34gyTuSd+J1mdyXKBgjri+z0+wKbnv+FX7srk5kB2LrD8YRDH8ZRZLCmaNFzyCDe+9QWmcMe9/L/YPkBCIlWdV1lFNl6fu09Yf116Qasep3jhm7xyN+xOVgkOJ0bSwLJhS9vGORMp8tZQO4TopxpGp00rFUSkc2SAwSX6FNozxfmnG+o8UOxT3mf0erk3y7GRZpkKzoS4O86o8mGWEhad15J32mtDLypZWqmnM88mJ4zrQlBOjJE9hUzt2FFCvnu7uY9Obcz+dfQHzrrbnvn7k4lDCRQGVFTjOwvw2Sdka43Zn5uV18ccNd1VnU47pdy+caa7oPJX1IKl9sEP4dkjrA== Received-SPF: pass client-ip=57.103.79.18; envelope-from=mohamed@unpredictable.fr; helo=outbound.st.icloud.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Link to branch: https://github.com/mediouni-m/qemu whpx (tag for this submission: whpx-v13) Missing features: - VM save-restore: interrupt controller state notably - SVE register sync: I didn't have the time to test this on pre-release hardware with SVE2 support yet. So SVE2 is currently masked for VMs when running this. Known bugs: - U-Boot still doesn't work (hangs when trying to parse firmware) but EDK2 does. Note: "target/arm/kvm: add constants for new PSCI versions" taken from the mailing list. "accel/system: Introduce hwaccel_enabled() helper" taken from the mailing list, added here as part of this series to make it compilable as a whole. "hw/arm: virt: add GICv2m for the case when ITS is not available" present in both the HVF vGIC and this series. "hw: arm: virt-acpi-build: add temporary hack to match existing behavior" is for ACPI stability but what is the right approach to follow there? And another note: Seems that unlike HVF there isn't direct correspondence between WHv registers and the actual register layout, so didn't do changes there to a sysreg.inc. Updates since v12: - Address review comments and make sure that checkpatch shows no errors, make test also ran - Tested the Windows x86_64 build too in addition to Windows arm64 and macOS arm64 - Hopefully the last revision, should be ready to merge. Updates since v11: - Address review comments - Rebase up to latest staging - Switch to assuming Qemu 11.0 as the newest machine model Updates since v10: - Bring forward to latest Qemu - Fix a typo in the GICv3+GICv2m PR Updates since v9: - Adding partition reset on the reboot side of things... Updates since v8: - v9 and v8 were not submitted properly because of my MTA not behaving, sorry for that. - v10 introduces a new argument, -M msi=, to handle MSI-X configuration more granularly. - That surfaced what I think is a bug (?), with vms->its=1 on GICv2 configurations... or I did understand everything wrong. - Oopsie due to email provider ratelimiting. Updates since v7: - Oops, fixing bug in "hw/arm: virt: cleanly fail on attempt to use the platform vGIC together with ITS". Other commits are unchanged. Updates since v6: - Rebasing - Fixing a bug in the GICv3+GICv2m case for ACPI table generation - getting rid of the slots infrastructure for memory management - Place the docs commit right after the "cleanly fail on attempt to run GICv3+GICv2m on an unsupported config" one as that's what switches ITS to a tristate. - Fixing a build issue when getting rid of the arch-specific arm64 hvf-stub. Updates since v5: - Rebasing - Address review comments - Rework ITS enablement to a tristate - On x86: move away from deprecated APIs to get/set APIC state Updates since v4: - Taking into account review comments - Add migration blocker in the vGICv3 code due to missing interrupt controller save/restore - Debug register sync Updates since v3: - Disabling SVE on WHPX - Taking into account review comments incl: - fixing x86 support - reduce the amount of __x86_64__ checks in common code to the minimum (winhvemulation) which can be reduced even further down the road. - generalize get_physical_address_range into something common between hvf and whpx Updates since v2: - Fixed up a rebase screwup for whpx-internal.h - Fixed ID_AA64ISAR1_EL1 and ID_AA64ISAR2_EL1 feature probe for -cpu host - Switched to ID_AA64PFR1_EL1/ID_AA64DFR0_EL1 instead of their non-AA64 variant Updates since v1: - Shutdowns and reboots - MPIDR_EL1 register sync - Fixing GICD_TYPER_LPIS value - IPA size clamping - -cpu host now implemented Mohamed Mediouni (26): qtest: hw/arm: virt: skip ACPI test for ITS off hw/arm: virt: add GICv2m for the case when ITS is not available tests: data: update AArch64 ACPI tables hw/arm: virt: cleanly fail on attempt to use the platform vGIC together with ITS hw: arm: virt: rework MSI-X configuration hw: arm: virt-acpi-build: add temporary hack to match existing behavior docs: arm: update virt machine model description whpx: Move around files before introducing AArch64 support whpx: reshuffle common code whpx: ifdef out winhvemulation on non-x86_64 whpx: common: add WHPX_INTERCEPT_DEBUG_TRAPS define hw, target, accel: whpx: change apic_in_platform to kernel_irqchip whpx: interrupt controller support whpx: add arm64 support whpx: change memory management logic target/arm: cpu: mark WHPX as supporting PSCI 1.3 whpx: arm64: clamp down IPA size hw/arm, accel/hvf, whpx: unify get_physical_address_range between WHPX and HVF whpx: arm64: implement -cpu host target/arm: whpx: instantiate GIC early whpx: arm64: gicv3: add migration blocker whpx: enable arm64 builds whpx: apic: use non-deprecated APIs to control interrupt controller state whpx: arm64: check for physical address width after WHPX availability whpx: arm64: add partition-wide reset on the reboot path MAINTAINERS: update the list of maintained files for WHPX Philippe Mathieu-Daudé (1): accel/system: Introduce hwaccel_enabled() helper Sebastian Ott (1): target/arm/kvm: add constants for new PSCI versions MAINTAINERS | 6 + accel/hvf/hvf-all.c | 7 +- accel/meson.build | 1 + accel/stubs/whpx-stub.c | 1 + accel/whpx/meson.build | 7 + {target/i386 => accel}/whpx/whpx-accel-ops.c | 6 +- accel/whpx/whpx-common.c | 536 +++++++++ docs/system/arm/virt.rst | 13 +- hw/arm/virt-acpi-build.c | 16 +- hw/arm/virt.c | 140 ++- hw/i386/x86-cpu.c | 4 +- hw/intc/arm_gicv3_common.c | 3 + hw/intc/arm_gicv3_whpx.c | 249 ++++ hw/intc/meson.build | 1 + include/hw/arm/virt.h | 8 +- include/hw/core/boards.h | 3 +- include/hw/intc/arm_gicv3_common.h | 3 + include/system/hvf_int.h | 5 + include/system/hw_accel.h | 13 + .../whpx => include/system}/whpx-accel-ops.h | 4 +- include/system/whpx-all.h | 20 + include/system/whpx-common.h | 26 + .../whpx => include/system}/whpx-internal.h | 25 +- include/system/whpx.h | 5 +- meson.build | 20 +- target/arm/cpu.c | 3 + target/arm/cpu64.c | 17 +- target/arm/hvf-stub.c | 20 - target/arm/hvf/hvf.c | 6 +- target/arm/hvf_arm.h | 3 - target/arm/kvm-consts.h | 2 + target/arm/meson.build | 2 +- target/arm/whpx/meson.build | 5 + target/arm/whpx/whpx-all.c | 1020 +++++++++++++++++ target/arm/whpx/whpx-stub.c | 15 + target/arm/whpx_arm.h | 17 + target/i386/cpu-apic.c | 2 +- target/i386/hvf/hvf.c | 11 + target/i386/whpx/meson.build | 1 - target/i386/whpx/whpx-all.c | 569 +-------- target/i386/whpx/whpx-apic.c | 48 +- tests/data/acpi/aarch64/virt/APIC.its_off | Bin 164 -> 188 bytes 42 files changed, 2215 insertions(+), 648 deletions(-) create mode 100644 accel/whpx/meson.build rename {target/i386 => accel}/whpx/whpx-accel-ops.c (96%) create mode 100644 accel/whpx/whpx-common.c create mode 100644 hw/intc/arm_gicv3_whpx.c rename {target/i386/whpx => include/system}/whpx-accel-ops.h (92%) create mode 100644 include/system/whpx-all.h create mode 100644 include/system/whpx-common.h rename {target/i386/whpx => include/system}/whpx-internal.h (88%) delete mode 100644 target/arm/hvf-stub.c create mode 100644 target/arm/whpx/meson.build create mode 100644 target/arm/whpx/whpx-all.c create mode 100644 target/arm/whpx/whpx-stub.c create mode 100644 target/arm/whpx_arm.h -- 2.50.1 (Apple Git-155)