Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D98A3101A8 for ; Wed, 31 Dec 2025 12:41:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767184865; cv=none; b=KTHgYpP/OJbPzuW3OhP75bQwTZiaW9wu95NQBPd6PSUeZkBi55OVrXVclev8LTf1OnpN5vbLHziq1JlhSDqWPelQwK3i4HM+LwTgJ+tOZnw7s0t88YUTrsQd5T6AXtrdgoIlcczyuV4ElPswcZi64QuvOeWiUyXMLcBCZY2cPlM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767184865; c=relaxed/simple; bh=DnZtX8FMWL3xUvEx9ZwEljqS0Zqi/7F7spPDPYn9XhI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LaRkHpEVl2KCkIyuOpa9MtaUveVNYDTPFUFdNxT/Iirn3drQIOxR8u3IGr9yFRVrTihYDcLwwgDUctIAbdYr67P3HpWRZOaEje9pfi4cny9c/ArMiEsvVJVK7DTJtQhD7kM9Jv+7YNfUZYGJugwJ9ETgk+voUrmsqze18XsvE14= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FPWBGUW/; arc=none smtp.client-ip=209.85.128.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FPWBGUW/" Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-78fb9a67b06so82989047b3.1 for ; Wed, 31 Dec 2025 04:41:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767184863; x=1767789663; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ASzrwnWe1LPCoc7Xrbs0jLsSOmeBARD1j4LP7Uc0+4E=; b=FPWBGUW/DWr+I0SRVc0J57YjydlAoqbCoP9CaX3NWNLMaEjrU+8JHydrcMvPeJHQfn vU8jfx48e2UWzvFJOm3lGqdhHUbJ59+VaavKwLihWV5TNqkkHglWEdk6TR/Gnfnvkzxi s8vIFCLAAWBDbwH8L04WcP1j3/qFvj7bbYcpg+4jpQQ3Uzo+weYvboFahvrlsNrfRUmB 5QWOKabGfNU3SJABnB5ymawv/PifpXoKqp7f7ZPUVa8daAf8/FCk0hzfH6XzlSI9FzBp bp+SFxEplM6/YM89WxAdCPtUQziTEGEzgw26t4HdLcYX8yfRrOIRxedPBYx8QFUiawiP lrjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767184863; x=1767789663; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ASzrwnWe1LPCoc7Xrbs0jLsSOmeBARD1j4LP7Uc0+4E=; b=YcsGPGjT3BwJh9WSAuH7BzUzCUTHXWf60/Y9Zfr+LACRa0949omyDkRJmApvsK5URG yoXa4Ktl+yxdjFQ7pqPAqYjSyHT+cYqZJz91zs8NsjLu6wucggzyz955qzrPGpV//DoE cQM3yp614tU7q8zVRjxrGa+H0upUiOr2oUJ6n+9vqozzzFxtlNPOGEf1QTXvst9+JFH0 HMVUS9tCVY8wQlyWNNAfR397epf/fCowbce3VWg8xOHtCtps0YwhPeXfPXJx1omKQxUr 3pEQ0p2CL6EsS38Wo27gBMwNipdQDZBcYMBTfemEY0FFsy/MpsvI03mI0AhNJVyVzlZg REnw== X-Forwarded-Encrypted: i=1; AJvYcCWyVkkb2jHpmsmo40CiXDHisp5I7Hu10SbKLry4WFH37OXQwPGAeROSSbSYFglsGpR5/k8ifM7jR9gNNw==@vger.kernel.org X-Gm-Message-State: AOJu0Yws0AENu68J/M/8mVo522gahb2tD0qv4l3KRJFAU4VSkUoKu40J EXDcqR3DYKe20Lc8Jr7nyWJkic5CriTWmSJy7osNNao+NpJ06rUF027ApiEKJS/Mof9onQ== X-Gm-Gg: AY/fxX7mkqQ3jizG0bsBba4DNbYgN/ggr+WjAQbBsT0Md+cYNBbBD7/jcqWAyFKdQj1 vvkeC3Ai0ZlDhTBqwrLZg/LB9fBDIfBn125VzEEkIqG2AkgHtOJ15ey7/bX+pyJ9PLvFV5wdIdj v6DDtPpHjxDZS8Y/LgrT6GsNh7JKf7vMedE1fCYnj1GWlemE1aYxxiQd/Ixvz0dfAZiCVjXmXqx hLUgSF/ZI7Ht5wR5FaiLOcPVfchzuxM7SxI2Dz82kuFb28HKhWCUxQd5ebr62FTl4gjeREa0/e6 HkwgfN+GP8XgF1nw4EulberWZpg9kyc0zhlkWAq+s7cBjZjXpZAWaWHdN70kxiaXPeWpvsnxEw3 6rrZCKTWEwR1wmOxrMy3TYS2Fyj3wr056z00Oa8g+Ie2a/ySQbds/GJxl/KKZoj3TmL0tgu95LY 4rsmeXBvHeogjs4pkcXLfO748LTA/hwYFTtwZ51FDnIy3l1lymxe+NGd97udlKjvaDOIRXzo7ux T2XjDI= X-Google-Smtp-Source: AGHT+IEFy0/xAx2AeDnYaJrJhM8NAx65XdkRXLMsI+QKt1RJUDYhZDfCV41A4Srcws0GZCL6Gfr8LA== X-Received: by 2002:a05:690c:6307:b0:786:a3fa:cb92 with SMTP id 00721157ae682-78fb3ec89b0mr240437437b3.9.1767184863093; Wed, 31 Dec 2025 04:41:03 -0800 (PST) Received: from ubuntu-linux-2404.. (108-214-96-168.lightspeed.sntcca.sbcglobal.net. [108.214.96.168]) by smtp.gmail.com with ESMTPSA id 00721157ae682-78fb43b2690sm137555257b3.18.2025.12.31.04.40.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Dec 2025 04:41:02 -0800 (PST) From: Sun Jian To: luca.ceresoli@bootlin.com Cc: linux-staging@lists.linux.dev, thierry.reding@gmail.com, jonathanh@nvidia.com, skomatineni@nvidia.com, mchehab@kernel.org, linux-tegra@vger.kernel.org, linux-media@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Sun Jian Subject: [PATCH v2 2/2] staging: media: tegra-video: move tegra20_vip_soc declaration to vip.h Date: Wed, 31 Dec 2025 20:39:55 +0800 Message-ID: <20251231123955.277384-3-sun.jian.kdev@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251231123955.277384-1-sun.jian.kdev@gmail.com> References: <20251229070125.98741-1-sun.jian.kdev@gmail.com> <20251231123955.277384-1-sun.jian.kdev@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit tegra20_vip_soc is shared across translation units but is currently declared via an extern in vip.c. Move the declaration to vip.h so users get it via the header and we avoid extern declarations in .c files, matching the pattern already used by tegra20_vi_soc and tegra210_vi_soc. Link: https://lore.kernel.org/linux-staging/DFCAOR6T9DPE.2MOL0K9O3HP1N@bootlin.com/T/ Suggested-by: Luca Ceresoli Signed-off-by: Sun Jian --- drivers/staging/media/tegra-video/vip.c | 4 ---- drivers/staging/media/tegra-video/vip.h | 4 ++++ 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/tegra-video/vip.c b/drivers/staging/media/tegra-video/vip.c index 5ec717f3afd5..80cd3b113125 100644 --- a/drivers/staging/media/tegra-video/vip.c +++ b/drivers/staging/media/tegra-video/vip.c @@ -263,10 +263,6 @@ static void tegra_vip_remove(struct platform_device *pdev) pm_runtime_disable(&pdev->dev); } -#if defined(CONFIG_ARCH_TEGRA_2x_SOC) -extern const struct tegra_vip_soc tegra20_vip_soc; -#endif - static const struct of_device_id tegra_vip_of_id_table[] = { #if defined(CONFIG_ARCH_TEGRA_2x_SOC) { .compatible = "nvidia,tegra20-vip", .data = &tegra20_vip_soc }, diff --git a/drivers/staging/media/tegra-video/vip.h b/drivers/staging/media/tegra-video/vip.h index 32ceaaccbba2..fdded00447e4 100644 --- a/drivers/staging/media/tegra-video/vip.h +++ b/drivers/staging/media/tegra-video/vip.h @@ -50,6 +50,10 @@ struct tegra_vip_soc { const struct tegra_vip_ops *ops; }; +#if defined(CONFIG_ARCH_TEGRA_2x_SOC) +extern const struct tegra_vip_soc tegra20_vip_soc; +#endif + /** * struct tegra_vip - NVIDIA Tegra VIP device structure * -- 2.43.0