Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64B1CCEFD0C for ; Tue, 6 Jan 2026 23:19:59 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vdGKy-0005GR-QU; Tue, 06 Jan 2026 18:19:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vdGKj-00057e-TH for qemu-arm@nongnu.org; Tue, 06 Jan 2026 18:19:26 -0500 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vdGKg-00010Z-HU for qemu-arm@nongnu.org; Tue, 06 Jan 2026 18:19:24 -0500 Received: by mail-wr1-x444.google.com with SMTP id ffacd0b85a97d-432755545fcso831572f8f.1 for ; Tue, 06 Jan 2026 15:19:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767741561; x=1768346361; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5MSw6pM1Isj343x+S0mtnkdkQ6xtf+8KOtUuCijJ/iM=; b=PzNDPchUgvW134bzM3ckY+qeoHrqdn/y5ajzMreWVujfLLDWwmnLsUyNICcFrSbXyV YSfI6sIcIEkGqnnvplNEC3PzdSB15WwYxGbYgTj5J3uUvR30VuRFd1WDuvAaAddUSWQQ 9GXBVoo8QxGOspsRR62JrmQY69IIKbrTmI1foGIJALXEk8svnFOEID+2G97+PX5uqZXr 53mAq/rmmbeWVOLHOP4dJGJfPSwDnFwSLOh9Gon4ChxZReKDxYnRfTkE2io2+ByYeu+V +y/UTogdPVu4Otm9bxlgVWXGfoTVwa7FDrF2iyPM2zcLVk0+IiwWcb1siua4VjoAL5Pv I+mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767741561; x=1768346361; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5MSw6pM1Isj343x+S0mtnkdkQ6xtf+8KOtUuCijJ/iM=; b=IaBPEbAOAvbmYpe+VuKwbmKOeZQDWHeR9RuSls+g1+UXpPYTN2Nhr7xXBV0T5AOCPG 62f4qJ80OpwP1W66ZLs8Up26ZveY1V/ypgiTx3b6vPDXa/YQGRFyK1DsKb9azd3qIU+8 vYVE37RS9hquL77BiNEtijFW3x1oKrotX/+uAyJZBd18hmV3HhuUFt7PnDPqM8JGxiuQ t580bMJyxFZD0L32lbYxWTGmKriphtreMJ61hTP+oYcaom4Ox6FN6eCYZW2YG7PBraUP RZtBf+AcitvPtY0e3Kv6I+ZOwvBAE9oSvz5RvSBvQ95PM/+MfPcTajJSCdaVpI70tmJG S5YQ== X-Forwarded-Encrypted: i=1; AJvYcCXDosNgXpCdV8VAAHNRzUTg5wlpzMxvwKCcSme6mYkCZ17BQzcrjfdRUPRZ5rT3GyXwR6MZGDgVEA==@nongnu.org X-Gm-Message-State: AOJu0YzCe1TeHUg4FPVbuLK9Ap1Gc+3VBWK7JSo2cVqR7wxPezQiE5YD +AKeG1VfT28wsKlDznDbi5mmeMipvR1moVj5l3JiIQX4wlf1YzyZZqP2AY++VhTevVs= X-Gm-Gg: AY/fxX7VSOFK9DdeLWbN4YzIFNbIZMxdWbXt4Ye9UHYhRpUfF80/H9CKP6l1ord+z/t bfQ2YTm7OZDLSk8/LXEwN7vpt+6Y3Xo+v0znuO6ATem+Yj0seE/+4rgULRC+KIcVww931vHUoN2 cslV+nG5SJlj6AKj5M4yUGQ/gznlwOZ5ASzY0O3w3DlOyyrL2XPKF68ndpCFUMCcwnDQ85Zxpdd lYyJ7Dr+sZFOrEam0k/5TbddoM/6/h4BYZVjuhedbBI3rmP3nA3W1LdOlOycDs8FGCGiNu+uwLs YzPob0IdsQgze8HHd5PG3L9h4ZIJZ9aEh2Zvo0h+5loOFZhLf/CPY9WBVDjol8dcvo8UcHzt5iW WpMwg0PGYgzLdbcmpCubOnkhIRIDziqlZDr1JNIyfl7TvL8VZhQYl3fZohU9ac0y+1afRXEHE1d svReIIr1eNJ2TVKEDxY2eTLhDaVmV5sCD9Hf2ALpsHbLVUQWdPmxSdYlKWBG7D X-Google-Smtp-Source: AGHT+IFhOTFzCPaSSO0jICAUELJTem7A365yBYeKRFZ6R0EZuKOxmdBZJj7PGcudVsIGaP1SPOx2kA== X-Received: by 2002:a05:6000:2dc6:b0:431:1d4:3a8a with SMTP id ffacd0b85a97d-432c3628301mr754519f8f.7.1767741560904; Tue, 06 Jan 2026 15:19:20 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5df91fsm7184522f8f.23.2026.01.06.15.19.19 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 06 Jan 2026 15:19:20 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Richard Henderson , qemu-ppc@nongnu.org, Pierrick Bouvier , qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Zhao Liu Subject: [PATCH 1/5] target/i386: Restrict WatchPoint API to TCG Date: Wed, 7 Jan 2026 00:19:03 +0100 Message-ID: <20260106231908.16756-2-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260106231908.16756-1-philmd@linaro.org> References: <20260106231908.16756-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::444; envelope-from=philmd@linaro.org; helo=mail-wr1-x444.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Watchpoints are specific to the TCG accelerator. Restrict the cpu_watchpoint_remove_all() call. Signed-off-by: Philippe Mathieu-Daudé --- target/i386/cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 37803cd7249..9831e2bc210 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -9184,7 +9184,9 @@ static void x86_cpu_reset_hold(Object *obj, ResetType type) env->dr[6] = DR6_FIXED_1; env->dr[7] = DR7_FIXED_1; cpu_breakpoint_remove_all(cs, BP_CPU); - cpu_watchpoint_remove_all(cs, BP_CPU); + if (tcg_enabled()) { + cpu_watchpoint_remove_all(cs, BP_CPU); + } cr4 = 0; xcr0 = XSTATE_FP_MASK; -- 2.52.0