Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 828693164A1 for ; Wed, 7 Jan 2026 12:46:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767789963; cv=none; b=d8xCGwvFxLVFLRV85VSxo6d+t90IPXY7qHg/jtCXT04Xx66ATrbfwrKW41BxRhNkxQyRlthdrQrN6i0zLDZ0gyCJmU9f8DjATNdGDiwxlCpmxgQdQHyNeZXGkIjNhyrFMvkiYuKsJZf0gQGq/L+1kjkl73DPs/cTw99P8utRTO0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767789963; c=relaxed/simple; bh=jlOYhHRK9R/tiUBFn/5aMiOVbVgYLgaW8WWuQuDHDyo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tVKRTIk7cm2klcoeSLH3a5cTsQVm52uzC2i8WExd5nURHcB9EWjJUt1DokL67WjJGvuclnomv6lxQschAUZK/Wen1ppCmzgCVdqWeCRumejh+bqYDvu+9t/gCO6pE9akzhbovpwwTZw9NCCms2MyEIm+IN1T+tQhXVTgWwqzI+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=D6Dk9rfN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="D6Dk9rfN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43D2AC4CEF7; Wed, 7 Jan 2026 12:46:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767789963; bh=jlOYhHRK9R/tiUBFn/5aMiOVbVgYLgaW8WWuQuDHDyo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=D6Dk9rfNyBY2aKla6SPPDhkI/YMc4hqHjhZae0c7zCr16KlXRgNxV39Y1LpF2Nm1h Wc6tutntwGTkEq8tLbsUq6xL9NQeUafEeJpXRtdU8c2EVh6hdCFcH7p4yX8UZZ6L97 DacJKAjBRoaGmlKATr58DMKrdUwOyrmNax32/64SkdrdO0HNb1Ha4WDEKyw+NG9gsz IBtAJ3a+e5yvBw3ovqWqx1w1oB81iP5i0JF8SeFJ1eG0e94H1x6YGPlpMYNpajBAUh VXK4XU8Idps5XRYx66BGsnkb4FZRFIYaxH1Vh9mfScqxziQok0dXEULVBjCO0Ab/Rz vWgJka2156PRQ== From: Sasha Levin To: stable@vger.kernel.org Cc: Johan Hovold , CK Hu , AngeloGioacchino Del Regno , Chun-Kuang Hu , Sasha Levin Subject: [PATCH 5.15.y] drm/mediatek: Fix probe memory leak Date: Wed, 7 Jan 2026 07:46:00 -0500 Message-ID: <20260107124600.3997704-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <2026010516-unfrosted-serotonin-e7b7@gregkh> References: <2026010516-unfrosted-serotonin-e7b7@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Johan Hovold [ Upstream commit 5e49200593f331cd0629b5376fab9192f698e8ef ] The Mediatek DRM driver allocates private data for components without a platform driver but as the lifetime is tied to each component device, the memory is never freed. Tie the allocation lifetime to the DRM platform device so that the memory is released on probe failure (e.g. probe deferral) and when the driver is unbound. Fixes: c0d36de868a6 ("drm/mediatek: Move clk info from struct mtk_ddp_comp to sub driver private data") Cc: stable@vger.kernel.org # 5.12 Cc: CK Hu Signed-off-by: Johan Hovold Reviewed-by: AngeloGioacchino Del Regno Link: https://patchwork.kernel.org/project/dri-devel/patch/20250923152340.18234-3-johan@kernel.org/ Signed-off-by: Chun-Kuang Hu Signed-off-by: Sasha Levin --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c index 22d23668b484..82e727c21774 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c @@ -487,7 +487,7 @@ int mtk_ddp_comp_init(struct device_node *node, struct mtk_ddp_comp *comp, type == MTK_DISP_RDMA) return 0; - priv = devm_kzalloc(comp->dev, sizeof(*priv), GFP_KERNEL); + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); if (!priv) return -ENOMEM; -- 2.51.0