Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B841E26D4CA for ; Mon, 12 Jan 2026 09:59:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768212004; cv=none; b=umQVqStjOpZ4sQZ8uHNdhk7SsjTtg5K/mAf/gMWl+iQABMUTzT5d2owYlaWcufQJkJaak5duFlaSahrFugcaYwPOlFh9jQ27o3al5ilvCvUCtnCPLlvNPanx/YmVunNMo4o+GN168v83UVkWGJjcKUjxxzL9SzqgFfXXnjA4Xss= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768212004; c=relaxed/simple; bh=8bUsmSlc+wC6Xcp36c6O6MX67eC8vPQ3c6nf8LrohHs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Tj4VrM5CP6jQl+gtBH7e+Px+TN1QaFFUCbVnCQYNyd7bqr4NS6uZoy9aPnZxQW3CUBAltHIa9Se1HrqT/c9+mqUvxcfYkFrO8sT7xRSM1IS+ygx4BIUF6b1GC0kl9qTh8+0+++2XcdLCx9MdzOWkFqiVNjDrv9c9ox1c76tbbHk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=hOcIGDlv; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="hOcIGDlv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1768211999; x=1799747999; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=8bUsmSlc+wC6Xcp36c6O6MX67eC8vPQ3c6nf8LrohHs=; b=hOcIGDlvd+cPLHkWqMBOhCorsY3z0kinokfkUQ1x8G3oClHjCTYgpMbJ 53iCfAbuo71IBVHP+w3HiRd8IdwWAvk2+vd0qrvStiNI6S1fa311Rd2tM h+fCuAt+UykYKPkbr9Za1MeEahpWz6/0p0TZ5cNgwP7tivTbymHj4yqTO 6B/bEXohXp5uYpi9PJ2kPRRjYBf7C/qHl9yj8LoCBXZVRdQOR7BjiL2hw /krldpCA2/2MUixuUdF/fTuj/967GWRAW0rDhQaBuJv59ZHDrxM5t+zWB ThUbBgXKdrBF7PtT58pVAVSr/J2ol47EZxSTSUztfFlpT3kY970j+YyiL A==; X-CSE-ConnectionGUID: b+SZdIrsQPC0as1N0Oy6pQ== X-CSE-MsgGUID: 84ZNnTqxRFWL6yUGJE5/AA== X-IronPort-AV: E=McAfee;i="6800,10657,11668"; a="69218789" X-IronPort-AV: E=Sophos;i="6.21,219,1763452800"; d="scan'208";a="69218789" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2026 01:59:58 -0800 X-CSE-ConnectionGUID: m9vZwBC2QZal0OcP0H8J9A== X-CSE-MsgGUID: udoQLzpsR1mWq5pTD2QERg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,219,1763452800"; d="scan'208";a="234743130" Received: from zzombora-mobl1 (HELO kekkonen.fi.intel.com) ([10.245.245.52]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2026 01:59:56 -0800 Received: from punajuuri.localdomain (unknown [192.168.240.130]) by kekkonen.fi.intel.com (Postfix) with ESMTP id 2F6E0121F7F; Mon, 12 Jan 2026 11:59:50 +0200 (EET) Received: from sailus by punajuuri.localdomain with local (Exim 4.98.2) (envelope-from ) id 1vfEiE-0000000011Q-0Cad; Mon, 12 Jan 2026 11:59:50 +0200 Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo From: Sakari Ailus To: linux-media@vger.kernel.org Cc: Bingbu Cao , Hans de Goede , mehdi.djait@intel.com Subject: [PATCH v2 06/23] media: i2c: ov01a10: Fix test-pattern disabling Date: Mon, 12 Jan 2026 11:59:32 +0200 Message-ID: <20260112095949.3851-7-sakari.ailus@linux.intel.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260112095949.3851-1-sakari.ailus@linux.intel.com> References: <20260112095949.3851-1-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Hans de Goede When the test-pattern control gets set to 0 (Disabled) 0 should be written to the test-pattern register, rather then doing nothing. Fixes: 0827b58dabff ("media: i2c: add ov01a10 image sensor driver") Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede Tested-by: Mehdi Djait # Dell XPS 9315 Reviewed-by: Mehdi Djait Reviewed-by: Bingbu Cao Signed-off-by: Sakari Ailus --- drivers/media/i2c/ov01a10.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/media/i2c/ov01a10.c b/drivers/media/i2c/ov01a10.c index dd2b6d381175..3ad516e4d369 100644 --- a/drivers/media/i2c/ov01a10.c +++ b/drivers/media/i2c/ov01a10.c @@ -249,9 +249,8 @@ static const struct ov01a10_reg sensor_1280x800_setting[] = { static const char * const ov01a10_test_pattern_menu[] = { "Disabled", "Color Bar", - "Top-Bottom Darker Color Bar", - "Right-Left Darker Color Bar", - "Color Bar type 4", + "Left-Right Darker Color Bar", + "Bottom-Top Darker Color Bar", }; static const s64 link_freq_menu_items[] = { @@ -406,10 +405,8 @@ static int ov01a10_update_digital_gain(struct ov01a10 *ov01a10, u32 d_gain) static int ov01a10_test_pattern(struct ov01a10 *ov01a10, u32 pattern) { - if (!pattern) - return 0; - - pattern = (pattern - 1) | OV01A10_TEST_PATTERN_ENABLE; + if (pattern) + pattern |= OV01A10_TEST_PATTERN_ENABLE; return ov01a10_write_reg(ov01a10, OV01A10_REG_TEST_PATTERN, 1, pattern); } -- 2.47.3