Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DFED9D31A28 for ; Wed, 14 Jan 2026 08:33:22 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfwJc-0007gs-L9; Wed, 14 Jan 2026 03:33:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfwJY-0007bO-JU for qemu-trivial@nongnu.org; Wed, 14 Jan 2026 03:33:17 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfwJX-0006eQ-CH for qemu-trivial@nongnu.org; Wed, 14 Jan 2026 03:33:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768379594; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=wfssziJG2rNWSpwbyWUkGDi+9K0T813TnKrCIIVFFvo=; b=Vh5ApNsUPgiKJkoQRs5roG98jTlGKOSUwC1zKZpDXYrAAhYGPlY/3EDZsC59W7S5dHf4EI 8BA4ZSCWXbsG91GuY0xTbPM1XUhiVZHayIeX4m4eJ+EWYUmuCldxTmO+yEZrAo8gkrsXRM R84Y+PgMVwpdIumguAanOiYD0g97KK0= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-138-RPnIn6zVPPinFg7st-bIuQ-1; Wed, 14 Jan 2026 03:33:11 -0500 X-MC-Unique: RPnIn6zVPPinFg7st-bIuQ-1 X-Mimecast-MFC-AGG-ID: RPnIn6zVPPinFg7st-bIuQ_1768379590 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 314D519560AD; Wed, 14 Jan 2026 08:33:10 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.32.254]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4F1AA1956048; Wed, 14 Jan 2026 08:33:07 +0000 (UTC) From: Thomas Huth To: Paolo Bonzini , qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-trivial@nongnu.org Subject: [PATCH] configure: Set $PYTHON in the configuration of the optionroms Date: Wed, 14 Jan 2026 09:33:06 +0100 Message-ID: <20260114083306.18172-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-trivial-bounces+qemu-trivial=archiver.kernel.org@nongnu.org Sender: qemu-trivial-bounces+qemu-trivial=archiver.kernel.org@nongnu.org From: Thomas Huth pc-bios/optionrom/Makefile uses $(PYTHON) for running a Python script, but this variable is never initialized here. So the script gets run via its shebang line - which fails if the "python3" binary is not available on the system. To fix this, write the PYTHON configuration to the config.mak file of the optionroms. Signed-off-by: Thomas Huth --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 55e0bd34256..f7e8d7ad4c8 100755 --- a/configure +++ b/configure @@ -1643,6 +1643,7 @@ probe_target_compiler() { } write_target_makefile() { + echo "PYTHON=$python" echo "EXTRA_CFLAGS=$target_cflags" if test -z "$target_cc" && test -z "$target_as"; then test -z "$container_image" && error_exit "Internal error: could not find cross compiler for $1?" -- 2.52.0