Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 972E948AE36 for ; Wed, 21 Jan 2026 12:40:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768999239; cv=none; b=jmdh8uoZVaWlEZOxGdXZz50UnmTf3mbjyYPgaCLvoknIt9Hel88pQFXvldkrJU5tOyohfm8QGPcgu4T2b/BaYsd2qkV1CCdLrZtG6vo7B6+UiUbaM/Ksh6cvQjLE/7Mr8XLyhFS1DOTfH5ExYfrCbW8LsqDaffPcJmd3L/DeuHE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768999239; c=relaxed/simple; bh=/VSvcxWfgJOHpR5+RUIxgCOzfhoA+nLilDKID5PJM8M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=j9i+qUCqd2MpKc4ABMu+tK4vv5b2tOq1bdknof5qCOpl0PbElJdFztq+1VUtlFUQznxQ1C/B1S+uwuavAYYbdiJQOkoMAxVupw94ZiNTqrERKQeQJzX9WtS3KSEWqr1yRLIZN7MsXNw6Nc6a3I86wv13hVEDScSJZAbcYc32wOA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Y7mNaaY+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Y7mNaaY+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87A44C116D0; Wed, 21 Jan 2026 12:40:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768999239; bh=/VSvcxWfgJOHpR5+RUIxgCOzfhoA+nLilDKID5PJM8M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Y7mNaaY+oh2bR6Oki0L54fphhETm54WwU9bi/XsEw3X7z5OTLPY22wYewx38O+XAD QBWSbNhVJzP+kYwADXN1QbPxstpzNc72G05QjakPX3E1nKuohgrrgKZn8BtOmssQWD WbOYwEmuPNs0QhbPbLq+DiI7SJ9i7VAZNMeyRMMtNIjydEeHJCTrPO7LINhlH3QB55 pSxp6ER66HUXHX2T4OcNCx7dBwlyunM6KeSB0q6qdnXkXzIjOL+nTVSCc2Z/3Xthk2 XrAPIFnN0Ixixdd9Jpq1aEewmwESwRhrSGUgtRSoQ5/0tdxItxfy4MCm5Bo5ddYYoy YozhyS/637rEQ== From: Sasha Levin To: stable@vger.kernel.org Cc: Johan Hovold , Pierre-Yves MORDRET , Amelie Delaunay , Vinod Koul , Sasha Levin Subject: [PATCH 5.10.y] dmaengine: stm32: dmamux: fix OF node leak on route allocation failure Date: Wed, 21 Jan 2026 07:40:36 -0500 Message-ID: <20260121124036.1533446-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <2026012006-slacks-unfrozen-a0c6@gregkh> References: <2026012006-slacks-unfrozen-a0c6@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Johan Hovold [ Upstream commit b1b590a590af13ded598e70f0b72bc1e515787a1 ] Make sure to drop the reference taken to the DMA master OF node also on late route allocation failures. Fixes: df7e762db5f6 ("dmaengine: Add STM32 DMAMUX driver") Cc: stable@vger.kernel.org # 4.15 Cc: Pierre-Yves MORDRET Signed-off-by: Johan Hovold Reviewed-by: Amelie Delaunay Link: https://patch.msgid.link/20251117161258.10679-12-johan@kernel.org Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/stm32-dmamux.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/dma/stm32-dmamux.c b/drivers/dma/stm32-dmamux.c index f04bcffd3c24a..c95694856df52 100644 --- a/drivers/dma/stm32-dmamux.c +++ b/drivers/dma/stm32-dmamux.c @@ -140,7 +140,7 @@ static void *stm32_dmamux_route_allocate(struct of_phandle_args *dma_spec, ret = pm_runtime_resume_and_get(&pdev->dev); if (ret < 0) { spin_unlock_irqrestore(&dmamux->lock, flags); - goto error; + goto err_put_dma_spec_np; } spin_unlock_irqrestore(&dmamux->lock, flags); @@ -160,6 +160,8 @@ static void *stm32_dmamux_route_allocate(struct of_phandle_args *dma_spec, return mux; +err_put_dma_spec_np: + of_node_put(dma_spec->np); error: clear_bit(mux->chan_id, dmamux->dma_inuse); -- 2.51.0