Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81EB648B373 for ; Wed, 21 Jan 2026 15:15:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769008528; cv=none; b=oAviKxmHvha3N7HNfnENOXXlIIG24g9w8Mk8p86zC5OW4Rpn4mXyzxRf7/hIfwAqrp7n2FloIIqXLPgFqMGy9+DTRtn4ejHMFyBbe/YsjEGT1rjzagWRYZLRRuYvabefFwZ295fB7zwt5socZd8DeXCW9xQ3ZdLDqAT6tzN/ocw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769008528; c=relaxed/simple; bh=GTDYEFiega8YxWihJVfzhrRVHZNr2+ykLR1wXxa9TVc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=A5fNbLRVHjB9zIE1kdtwCwkv0y9gcjcpEd2QrEq0VE4B1s7/284/Y1WtvZxarUhI5hqqqbSILHngtr0hN2T3p+QzBF44cxpQ7buH1Xv1l9FIfp6ax2c5VnhPjUeV2nUm3F90BmLsmiDjYMMcQh4CB1prP3w6HPsqNVIMGVgJW98= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iIVrbQlJ; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iIVrbQlJ" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-47edd9024b1so46844895e9.3 for ; Wed, 21 Jan 2026 07:15:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769008525; x=1769613325; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=W91/nThu/hrkiQ9f4tK/HK4NnadCCD9MyZ0A6Cw7s6o=; b=iIVrbQlJ8IRL4p92YCZExrCKxYZhahtuE+EvuDoA81fggK3To6zpphtJRvyOsdfm8t +TJQ5X42sYmiIuElcuyubG+NBL4TqrkEmOnqQeAOh5PEOCGau3XoDks55zFquBG8fDlv h+9xsofcdtb3Jk107JovolPGJnEgElNZjuCbnes0auBToB6vONv5c6o+RXOnqYY4w+PD +DqH0n3lBp4NkSbOJbed/VX3m0Aw230HkyvHvNUOPNNqsXpVtMI8xNUGvKCEfY9Rx0fD 0DAreSwEDO+utU8hX93t/9PUBCGdkg3MmrgZIeqXjZIMGJVxyqFDRhqZa0pWURF1ScsO nzkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769008525; x=1769613325; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=W91/nThu/hrkiQ9f4tK/HK4NnadCCD9MyZ0A6Cw7s6o=; b=cF3FfScv5NBpSqdMuzWMqux/aBXZUjZlWSTr6dMKM7oR3N3qwFPrBMg8l2As7wqpiB s9Yid7GHKUN2Pg9S9qZX7cK5Vd82wT1Tl+B45DhzOr1EN4GQTrG1IK182B9bsXsgbaNX wYMyR4MfXRHZ495Dspaz8OpAPAMHZuJ7id9WRC3c4Cm0m3C3+yvJ43GtND1NpDvMWwHt 3rphTXMrWgJK214u9x6Q2nbgmOUzprRscD3EOCd5zrcEP/f6/za61y1O7VlmimD3PQJ1 +27yb1OHkBDmc7JGmzIAIMmWEJdQkd0VXHh6IjxQju1xfpVx77mWLfIXDmRp2praUdjq dA+g== X-Forwarded-Encrypted: i=1; AJvYcCUYGevS5F7eziC1j1ToN9lDARdl+OXbSTTNALRuhfShTDZOSzAZkdJJbcdXUT7O0s4xWelzy/zfBiJ/@vger.kernel.org X-Gm-Message-State: AOJu0YwChHY0aUTlcChNsw4uJoo91O9TSCvav1NrD+D3A5cmvjFERxK6 GcGRl8Aflpf1zhFry4ZLwwLmjqVj9ZddGomDyXRmP7P7IySe5P5a/gut X-Gm-Gg: AZuq6aJxjzkyg5TVaqRp5SVrRcCdq2/QhHI00cxdQiV0kMmaZV3S1TJChCMpzWM8HsQ yFKoYqEW8fcThrm6pNiDcYe3igD7iGzXss+31/ITfrDAJSkk5QAI7nGWXGK+HAfnmTE4FP611T2 8g251kR53lusSsPRF+9I/KI3QF+vQK6ARp6M2yzwWhRN/2EctacWVxS2F4Br2ntrGBY+LIyuC4i 5AOXLXHiAcj7wh8RfwYnLme4MfAr6o5EqpcAqDWuGwx5vKwuMt3VmKmrkaPxKLJmm8urt/YIzjv 2pspf2c5ftv4EFRKBGOK+7pMlemPaecselCN67ynJhKtS0+lTzdRbOCAjigCkLl8Wr4r5n7MZ9S bRQQqqq2xVRmV//LLdWNrkRaBkbgxj9y9vqjwXiHPcavRfEyd1frv8Jn+V9JyPoMWM4kIgDl79p h9MUoRIA/wl4w= X-Received: by 2002:a05:600c:608a:b0:477:2f7c:314f with SMTP id 5b1f17b1804b1-48025ccb812mr216647125e9.10.1769008524782; Wed, 21 Jan 2026 07:15:24 -0800 (PST) Received: from nas.local ([2001:912:1ac0:1e00:c662:37ff:fe09:93df]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435924ae6f1sm10534349f8f.33.2026.01.21.07.15.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jan 2026 07:15:24 -0800 (PST) From: Damien Dejean To: andrew@lunn.ch, krzk+dt@kernel.org Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, edumazet@google.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, hkallweit1@gmail.com, Damien Dejean Subject: [PATCH v2 4/4] net: phy: realtek: add RTL8224 polarity support Date: Wed, 21 Jan 2026 16:15:06 +0100 Message-ID: <20260121151506.813783-4-dam.dejean@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260121151506.813783-1-dam.dejean@gmail.com> References: <20260121151506.813783-1-dam.dejean@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The RTL8224 has a register to configure the polarity of every pair of each port. It provides device designers more flexbility when wiring the chip. Unfortunately, the register is left in an unknown state after a reset. Thus on devices where the bootloader don't initialize it, the driver has to do it to detect and use a link. The MDI polarity swap can be set in the device tree using the property realtek,mdi-cfg-polarity. The u32 value is a bitfield where bit[0..3] control the polarity of pairs A..D. Signed-off-by: Damien Dejean --- drivers/net/phy/realtek/realtek_main.c | 39 +++++++++++++++++++++++++- 1 file changed, 38 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/realtek/realtek_main.c b/drivers/net/phy/realtek/realtek_main.c index 85b0eea936e4..d2dc4f7a1971 100644 --- a/drivers/net/phy/realtek/realtek_main.c +++ b/drivers/net/phy/realtek/realtek_main.c @@ -164,6 +164,7 @@ #define RTL8224_SRAM_RTCT_LEN(pair) (0x8028 + (pair) * 4) #define RTL8224_VND1_MDI_PAIR_SWAP 0xa90 +#define RTL8224_VND1_MDI_POLARITY_SWAP 0xa94 #define RTL8366RB_POWER_SAVE 0x15 #define RTL8366RB_POWER_SAVE_ON BIT(12) @@ -1719,9 +1720,45 @@ static int rtl8224_mdi_config_order(struct phy_device *phydev) RTL8224_VND1_MDI_PAIR_SWAP, val); } +static int rtl8224_mdi_config_polarity(struct phy_device *phydev) +{ + struct device_node *np = phydev->mdio.dev.of_node; + u8 port_offset = phydev->mdio.addr & 3; + u32 polarity, val; + int ret; + + ret = of_property_read_u32(np, "realtek,mdi-cfg-polarity", &polarity); + + /* Do nothing if the property is not present */ + if (ret == -EINVAL) + return 0; + + if (!ret) + return ret; + + if (polarity & ~0xf) + return -EINVAL; + + val = __phy_package_read_mmd(phydev, 0, MDIO_MMD_VEND1, + RTL8224_VND1_MDI_POLARITY_SWAP); + if (val < 0) + return val; + + val &= ~(0xf << port_offset); + val |= polarity << port_offset; + return __phy_package_write_mmd(phydev, 0, MDIO_MMD_VEND1, + RTL8224_VND1_MDI_POLARITY_SWAP, val); +} + static int rtl8224_config_init(struct phy_device *phydev) { - return rtl8224_mdi_config_order(phydev); + int ret; + + ret = rtl8224_mdi_config_order(phydev); + if (!ret) + return ret; + + return rtl8224_mdi_config_polarity(phydev); } static int rtl8224_probe(struct phy_device *phydev) -- 2.47.3