Received: from n169-110.mail.139.com (n169-110.mail.139.com [120.232.169.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D91A2DA769 for ; Wed, 28 Jan 2026 11:06:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=120.232.169.110 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769598425; cv=none; b=b0ezpTFto97+cWP0jvkUcZWYKpNVt6fuYZmqvv/puspbJVV9lFl7jpgzcOD6SOiJblOaqFqdX+f1/EeI5bak6IYTM4SXvpbqaDeAwIzh3321jdekRLgEqGkE4dhk1KXqxfuSGGIw6DtDgvt+mNMVv+KL35bRQSMrQTMielUNHlM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769598425; c=relaxed/simple; bh=LTa8BcT6huDN6R3UM6Ee1vroyYdbUgzCwztoxqOp8Cs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=o4hFcLqvZ7PpHvDsPWcH3ufeCGYVcRbqqJdHvak5puVE26Din6bjQaol+DE1vRZtw6Z0XOqrOmPo2zoOVV8jVD2INoQkRIsxV/yJNyhMDTlluHpp/R16USArURiK6KrjPfFHX+X/zDOaVTdhV1Cphu9vWGUL27loDrRv2pcDL+0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=139.com; spf=pass smtp.mailfrom=139.com; dkim=pass (1024-bit key) header.d=139.com header.i=@139.com header.b=N46p8G60; arc=none smtp.client-ip=120.232.169.110 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=139.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=139.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=139.com header.i=@139.com header.b="N46p8G60" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=139.com; s=dkim; l=0; h=from:subject:message-id:to:cc:mime-version; bh=47DEQpj8HBSa+/TImW+5JCeuQeRkm5NMpJWZG3hSuFU=; b=N46p8G60SQ95aRWBg4p3g3KLSVu8NbU/v2msxqyQM16Wif/WRiT77JtyfE2GFa8L+p4PePPSsTpnr UR0wOpUXNZZ1AU8q6EAFZQjeT/M008HlGTu8jseCTGKtzQhDDQuxs93tTPbJI/QKnNzVFTyHbnONH9 z2eRa1kX67d3kPDs= X-RM-TagInfo: emlType=0 X-RM-SPAM: X-RM-SPAM-FLAG:00000000 Received:from ubuntu24.corp.ad.wrs.com (unknown[120.244.194.8]) by rmsmtp-lg-appmail-04-12082 (RichMail) with SMTP id 2f326979ede6c3a-647c0; Wed, 28 Jan 2026 19:07:27 +0800 (CST) X-RM-TRANSID:2f326979ede6c3a-647c0 From: Bin Lan To: stable@vger.kernel.org Cc: Sabrina Dubroca , Simon Horman , Steffen Klassert , Bin Lan Subject: [PATCH 5.15.y] espintcp: fix skb leaks Date: Wed, 28 Jan 2026 11:06:35 +0000 Message-ID: <20260128110635.4109-1-lanbincn@139.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Sabrina Dubroca [ Upstream commit 63c1f19a3be3169e51a5812d22a6d0c879414076 ] A few error paths are missing a kfree_skb. Fixes: e27cca96cd68 ("xfrm: add espintcp (RFC 8229)") Signed-off-by: Sabrina Dubroca Reviewed-by: Simon Horman Signed-off-by: Steffen Klassert [ Minor context change fixed. ] Signed-off-by: Bin Lan --- net/ipv4/esp4.c | 4 +++- net/ipv6/esp6.c | 4 +++- net/xfrm/espintcp.c | 4 +++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/net/ipv4/esp4.c b/net/ipv4/esp4.c index e578d065d904..53170ecb2de0 100644 --- a/net/ipv4/esp4.c +++ b/net/ipv4/esp4.c @@ -196,8 +196,10 @@ static int esp_output_tcp_finish(struct xfrm_state *x, struct sk_buff *skb) sk = esp_find_tcp_sk(x); err = PTR_ERR_OR_ZERO(sk); - if (err) + if (err) { + kfree_skb(skb); goto out; + } bh_lock_sock(sk); if (sock_owned_by_user(sk)) diff --git a/net/ipv6/esp6.c b/net/ipv6/esp6.c index a4b8c70ae527..cbe575ade34d 100644 --- a/net/ipv6/esp6.c +++ b/net/ipv6/esp6.c @@ -214,8 +214,10 @@ static int esp_output_tcp_finish(struct xfrm_state *x, struct sk_buff *skb) sk = esp6_find_tcp_sk(x); err = PTR_ERR_OR_ZERO(sk); - if (err) + if (err) { + kfree_skb(skb); goto out; + } bh_lock_sock(sk); if (sock_owned_by_user(sk)) diff --git a/net/xfrm/espintcp.c b/net/xfrm/espintcp.c index 24ca49ecebea..ebb9ee8906f4 100644 --- a/net/xfrm/espintcp.c +++ b/net/xfrm/espintcp.c @@ -170,8 +170,10 @@ int espintcp_queue_out(struct sock *sk, struct sk_buff *skb) { struct espintcp_ctx *ctx = espintcp_getctx(sk); - if (skb_queue_len(&ctx->out_queue) >= READ_ONCE(netdev_max_backlog)) + if (skb_queue_len(&ctx->out_queue) >= READ_ONCE(netdev_max_backlog)) { + kfree_skb(skb); return -ENOBUFS; + } __skb_queue_tail(&ctx->out_queue, skb); -- 2.43.0