Received: from orbyte.nwl.cc (orbyte.nwl.cc [151.80.46.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1953721D3C5 for ; Thu, 29 Jan 2026 14:07:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=151.80.46.58 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769695638; cv=none; b=VyGA7pIYq/MtpJmB6Pnsse2H59mvdiW7Md3zYa/QnqEDDFQcm6RQgxjyXGEUJ5krZYweHKWSwxet6PiS4m4vtqz5U7U5o3UNVNstVp0GD7iplad5akaP2g641L4pZml4iBkL4yZ7dNkD3GwWEXApUGIV92dbl9kVyiliYco4nSU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769695638; c=relaxed/simple; bh=KxFmhi3OvX+vFqEjc+4fiMGG7EJOZRtA/Zc/KHkKfOE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=IoFpEbt/eUAxGHhLQMtScujf32FhfPUR8Wa5EyVTd5ePEWNoQYDDr1AyFpY+tiHVbNsqpqpJhWufIpAWZ1OCLYPJVdhjZvIUQWVeuF9cFKjIbMsfY42feQaa5VXBLdyxbRGd3d5rKJUKOkOacnzUKtrJy8qLG8f0EyODWXMQ3Tk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nwl.cc; spf=pass smtp.mailfrom=nwl.cc; dkim=pass (2048-bit key) header.d=nwl.cc header.i=@nwl.cc header.b=EI4J+Miv; arc=none smtp.client-ip=151.80.46.58 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nwl.cc Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nwl.cc Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nwl.cc header.i=@nwl.cc header.b="EI4J+Miv" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nwl.cc; s=mail2022; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=p/fXXall3QpLds8Te05nVYNn2aGsPopw6XjuaYg1mFE=; b=EI4J+MivCiojrD3CVpNw5Trt4R zsh0LoWK8tClbn+B1A98Hg64gU/xqbc9VHTorUMb/duIzm+ynwOTUzgxq0gwFx9fiFQ7WDyodzTl2 Tlt9vrkaWH18XzN4aLgOd3ynEeSNy1UBHullVYoxi9EF48tKhGF60L3T9HHXxXoqZpbDl6k7+DWuv FhVpC9FOZgLpiDiT0LFb6CFvyjWUVP/ivcEkFyGrCFS6ewbATWDHnw3xrhMAjR9PV7tNknRPMH2N+ ogo2BRqqAPxLEwH4X+1SbmAmMr22pkPkzHztTdKjoqqvjbVIrkgw5pvaYs1/M+2WapvZ+dLqf+gbe +PamUN+w==; Authentication-Results: mail.nwl.cc; iprev=pass (localhost) smtp.remote-ip=::1 Received: from localhost ([::1] helo=xic) by orbyte.nwl.cc with esmtp (Exim 4.98.2) (envelope-from ) id 1vlSfx-000000001M2-0QTR; Thu, 29 Jan 2026 15:07:13 +0100 From: Phil Sutter To: Pablo Neira Ayuso Cc: netfilter-devel@vger.kernel.org, Florian Westphal Subject: [libnftnl PATCH 1/2] Revert "udata: Store u32 udata values in Big Endian" Date: Thu, 29 Jan 2026 15:07:06 +0100 Message-ID: <20260129140707.10025-1-phil@nwl.cc> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This reverts commit f20dfa7824860a9ac14425a3f7ca970a6c981597. This change to payload (interpretation) is problematic with package updates at run-time: The new version might trip over userdata in the running ruleset, avoid this. Signed-off-by: Phil Sutter --- src/udata.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/udata.c b/src/udata.c index 8cf4e7ca61e2f..a1956571ef5fd 100644 --- a/src/udata.c +++ b/src/udata.c @@ -8,7 +8,6 @@ #include #include -#include #include #include #include @@ -101,9 +100,7 @@ EXPORT_SYMBOL(nftnl_udata_put_u32); bool nftnl_udata_put_u32(struct nftnl_udata_buf *buf, uint8_t type, uint32_t data) { - uint32_t data_be = htonl(data); - - return nftnl_udata_put(buf, type, sizeof(data_be), &data_be); + return nftnl_udata_put(buf, type, sizeof(data), &data); } EXPORT_SYMBOL(nftnl_udata_type); @@ -131,7 +128,7 @@ uint32_t nftnl_udata_get_u32(const struct nftnl_udata *attr) memcpy(&data, attr->value, sizeof(data)); - return ntohl(data); + return data; } EXPORT_SYMBOL(nftnl_udata_next); -- 2.51.0