Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7332E6BF37 for ; Fri, 30 Jan 2026 20:13:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5B44610E380; Fri, 30 Jan 2026 20:13:03 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Uwhwu4bK"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 88D7010E380 for ; Fri, 30 Jan 2026 20:13:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769803981; x=1801339981; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=nnkUYCDF30DLSbMw8i1lzDK5N83lBF6+HU1Vo2MYSQI=; b=Uwhwu4bK+4luzQlU19XvZFKaLcENmolRnO63hDJr8muU1ufNESHTHkNS 4myFYrOWyd7ZHCKSMXGESjiU+oqFyhxWn/NjuJK2txfprirOcO205T6HB 1TXHSNuX+XZndLNTjl7KQgOdeifU/mCUNlaOiugE2iC/MmLPZTo/8CeJf xveDNvvMkKiShCXci02Sp9WsWpws2axQW2/UewPNIBg4c9itQz12+kDr2 I4NOU+niMUMVuFc99MSqo0q9nARQsn/P0ab40j3I1Kx2nrnZwLO5Ak3te 46kATpHzDGzkjVHieU6vjLdH/zxxQolabdSiFWoUpj1HsB49WB7ei1VEs A==; X-CSE-ConnectionGUID: 1voprHLdTm+xqz9NQ0+0vA== X-CSE-MsgGUID: zKkDx/+ERjOROKRuTB5h8A== X-IronPort-AV: E=McAfee;i="6800,10657,11687"; a="82484799" X-IronPort-AV: E=Sophos;i="6.21,263,1763452800"; d="scan'208";a="82484799" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2026 12:13:00 -0800 X-CSE-ConnectionGUID: 9JcKGSFPTDWbqIpAJJxBdQ== X-CSE-MsgGUID: 87gGoD/FT9mf/VKY51oEuw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,263,1763452800"; d="scan'208";a="213845749" Received: from dut6094bmgfrd.fm.intel.com ([10.80.55.45]) by fmviesa004.fm.intel.com with ESMTP; 30 Jan 2026 12:13:00 -0800 From: Jia Yao To: igt-dev@lists.freedesktop.org Cc: Jia Yao , Xin Wang Subject: [PATCH v4] tests/intel/xe_exec_system_allocator: Expect UC PAT madvise rejection Date: Fri, 30 Jan 2026 20:12:57 +0000 Message-ID: <20260130201257.572902-1-jia.yao@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260129003146.340181-1-jia.yao@intel.com> References: <20260129003146.340181-1-jia.yao@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" UC PAT index with CPU cached memory (system allocator) is now rejected by kernel to prevent security issues where GPU could bypass CPU cache and read stale sensitive data from DRAM. Modify UC PAT index tests to verify kernel correctly rejects the madvise call with -EINVAL, instead of attempting to execute batch buffers. v2(Xin Wang) - Put madvise rejection in a function v3: - Add multi-vma check in the function v4(Xin Wang) - Implement reject function inside test_exec Cc: Xin Wang Signed-off-by: Jia Yao --- tests/intel/xe_exec_system_allocator.c | 47 ++++++++++++++++++++++---- 1 file changed, 41 insertions(+), 6 deletions(-) diff --git a/tests/intel/xe_exec_system_allocator.c b/tests/intel/xe_exec_system_allocator.c index 412ad0384..6a15089b3 100644 --- a/tests/intel/xe_exec_system_allocator.c +++ b/tests/intel/xe_exec_system_allocator.c @@ -1193,7 +1193,7 @@ xe_vm_madvise_migrate_pages(int fd, uint32_t vm, uint64_t addr, uint64_t range) DRM_XE_MIGRATE_ALL_PAGES, 0); } -static void +static bool xe_vm_parse_execute_madvise(int fd, uint32_t vm, struct test_exec_data *data, size_t bo_size, struct drm_xe_engine_class_instance *eci, @@ -1289,10 +1289,39 @@ xe_vm_parse_execute_madvise(int fd, uint32_t vm, struct test_exec_data *data, if (flags & MADVISE_PAT_INDEX) { uint32_t num_ranges; struct drm_xe_mem_range_attr *mem_attrs; + uint8_t pat_idx = pat_value(fd); + bool is_uc_pat = (pat_idx == intel_get_pat_idx_uc(fd) || + pat_idx == intel_get_pat_idx_uc_comp(fd)); + int err; if (bo_size) bo_size = ALIGN(bo_size, SZ_4K); + if (is_uc_pat) { + /* UC PAT should be rejected by kernel for CPU cached memory */ + if (flags & MADVISE_MULTI_VMA) { + err = __xe_vm_madvise(fd, vm, to_user_pointer(data) + bo_size, + bo_size / 2, 0, DRM_XE_MEM_RANGE_ATTR_PAT, + pat_idx, 0, 0); + igt_assert_eq(err, -EINVAL); + + err = __xe_vm_madvise(fd, vm, to_user_pointer(data), bo_size, + 0, DRM_XE_MEM_RANGE_ATTR_PAT, + pat_idx, 0, 0); + igt_assert_eq(err, -EINVAL); + + err = __xe_vm_madvise(fd, vm, to_user_pointer(data) + bo_size / 2, + bo_size / 4, 0, DRM_XE_MEM_RANGE_ATTR_PAT, + pat_idx, 0, 0); + igt_assert_eq(err, -EINVAL); + } else { + err = __xe_vm_madvise(fd, vm, to_user_pointer(data), bo_size, + 0, DRM_XE_MEM_RANGE_ATTR_PAT, pat_idx, 0, 0); + igt_assert_eq(err, -EINVAL); + } + return true; /* Skip exec for UC PAT tests */ + } + if (flags & MADVISE_MULTI_VMA) { xe_vm_madvixe_pat_attr(fd, vm, to_user_pointer(data) + bo_size, bo_size / 2, pat_value(fd)); @@ -1308,7 +1337,7 @@ xe_vm_parse_execute_madvise(int fd, uint32_t vm, struct test_exec_data *data, mem_attrs = xe_vm_get_mem_attr_values_in_range(fd, vm, addr, bo_size, &num_ranges); if (!mem_attrs) { igt_debug("Failed to get memory attributes\n"); - return; + return false; } for (uint32_t i = 0; i < num_ranges; i++) @@ -1316,6 +1345,7 @@ xe_vm_parse_execute_madvise(int fd, uint32_t vm, struct test_exec_data *data, free(mem_attrs); } + return false; } static void @@ -1535,8 +1565,9 @@ test_exec(int fd, struct drm_xe_engine_class_instance *eci, addr = to_user_pointer(data); if (flags & MADVISE_OP) - xe_vm_parse_execute_madvise(fd, vm, data, bo_size, eci, addr, flags, sync, - pat_value); + if (xe_vm_parse_execute_madvise(fd, vm, data, bo_size, eci, addr, flags, sync, + pat_value)) + goto cleanup; if (flags & BO_UNMAP) { bo_flags = DRM_XE_GEM_CREATE_FLAG_NEEDS_VISIBLE_VRAM; @@ -1946,8 +1977,11 @@ cleanup: gem_close(fd, bo); } - munmap(bind_ufence, SZ_4K); - gem_close(fd, bind_sync); + if (bind_ufence) + munmap(bind_ufence, SZ_4K); + + if (bind_sync) + gem_close(fd, bind_sync); if (flags & BUSY) igt_assert_eq(unbind_system_allocator(), -EBUSY); @@ -2633,6 +2667,7 @@ int igt_main() !xe_has_vram(fd)) { igt_skip("Skipping compression-related PAT index\n"); } + xe_for_each_engine(fd, hwe) test_exec(fd, hwe, 1, 1, SZ_4M, 0, 0, NULL, NULL, s->flags, s->fn); } -- 2.43.0