Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D59E219D093 for ; Fri, 20 Feb 2026 22:21:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771626112; cv=none; b=NCE9MMAWC4yEZnqM+rQVviigZQxawY0cs5bXP3tjdRGUi1PFkJeNoEHoekWagQvDZaduchsDZojdBmFMNRBb7SK6yogC7qWcnfjUC5JeESpNs1RB0VBM6RCFviW06t6OuMbSnUy9tJwtblES/KonSMaObaVy2oUSPd1qiq0KTgs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771626112; c=relaxed/simple; bh=Wrmt7v9ScSt9b7z43FGS0Au1fnVb951jWi08/sgn/+M=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=coXG7NZf/LK/YglpnNOHEGZKGwSTQNqCuHS4iqOoGwd2VvAXBoyZmO0b7tlkGmSbO8FIQI9a64VBV1lsicmAK4UPq2vC3NamM6mNtIZYZTVRF38/bQzCv1v0G4Cx69LDw86CrFSsVkeNJdoQmmo2GVdh0v3P2YHOQhLcjXaDhjA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=b4wYOtnH; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="b4wYOtnH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771626110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=lv7FOvvZ2nqB5JyI2hl4/kR3EM7vATzMlCuaNJhPNlo=; b=b4wYOtnHgGuLQdlfZeaqm8XBKrQBshj5DmuvE1e+9ICSsAjhuzyIpyub6B2alxUylI+iAA xIPytxPNOfLye+oeGbMGFoGIzSdPIUkdRhW3AFRLRaaBZ9IoTCQVpEzGVGXqD5yyPDEPIr CZRHxkIbj6Jo9IO/A8nS0pkNPNw+0tU= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-213-QtvkncIvMqG5D7FbJKKt7Q-1; Fri, 20 Feb 2026 17:21:46 -0500 X-MC-Unique: QtvkncIvMqG5D7FbJKKt7Q-1 X-Mimecast-MFC-AGG-ID: QtvkncIvMqG5D7FbJKKt7Q_1771626105 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 47DEA18003F5; Fri, 20 Feb 2026 22:21:45 +0000 (UTC) Received: from lima-fedora.redhat.com (unknown [10.22.64.50]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4152A3000C26; Fri, 20 Feb 2026 22:21:44 +0000 (UTC) From: Kamal Heib To: linux-rdma@vger.kernel.org Cc: Abhijit Gangurde , Jason Gunthorpe , Leon Romanovsky , Kamal Heib Subject: [PATCH] RDMA/ionic: Fix potential NULL pointer dereference in ionic_query_port Date: Fri, 20 Feb 2026 17:21:26 -0500 Message-ID: <20260220222125.16973-2-kheib@redhat.com> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 The function ionic_query_port() calls ib_device_get_netdev() without checking the return value which could lead to NULL pointer dereference, Fix it by checking the return value and return -ENODEV if the 'ndev' is NULL. Fixes: 2075bbe8ef03 ("RDMA/ionic: Register device ops for miscellaneous functionality") Signed-off-by: Kamal Heib --- drivers/infiniband/hw/ionic/ionic_ibdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/infiniband/hw/ionic/ionic_ibdev.c b/drivers/infiniband/hw/ionic/ionic_ibdev.c index 164046d00e5d..bd4c73e530d0 100644 --- a/drivers/infiniband/hw/ionic/ionic_ibdev.c +++ b/drivers/infiniband/hw/ionic/ionic_ibdev.c @@ -81,6 +81,8 @@ static int ionic_query_port(struct ib_device *ibdev, u32 port, return -EINVAL; ndev = ib_device_get_netdev(ibdev, port); + if (!ndev) + return -ENODEV; if (netif_running(ndev) && netif_carrier_ok(ndev)) { attr->state = IB_PORT_ACTIVE; -- 2.52.0