Date: Sat, 21 Feb 2026 04:55:17 +0800
From: kernel test robot <lkp@intel.com>
To: Benjamin Berg <benjamin@sipsolutions.net>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: Re: [RFC PATCH 2/8] wifi: mac80211: change public RX API to use link
 stations
Message-ID: <202602210405.02r1qFBA-lkp@intel.com>
References: <20260220151929.61ef722ac889.I4a2d45609e94b52654b10ec572e59a45d09c41f4@changeid>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260220151929.61ef722ac889.I4a2d45609e94b52654b10ec572e59a45d09c41f4@changeid>

Hi Benjamin,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on wireless-next/main]
[also build test ERROR on wireless/main linus/master v6.19 next-20260220]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Benjamin-Berg/wifi-iwlwifi-use-link_sta-internally-to-the-driver/20260220-222422
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
patch link:    https://lore.kernel.org/r/20260220151929.61ef722ac889.I4a2d45609e94b52654b10ec572e59a45d09c41f4%40changeid
patch subject: [RFC PATCH 2/8] wifi: mac80211: change public RX API to use link stations
config: x86_64-rhel-9.4-rust (https://download.01.org/0day-ci/archive/20260221/202602210405.02r1qFBA-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
rustc: rustc 1.88.0 (6b00bc388 2025-06-23)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260221/202602210405.02r1qFBA-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202602210405.02r1qFBA-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/net/wireless/mediatek/mt76/mac80211.c:1522:25: error: incompatible pointer types passing 'struct ieee80211_sta *' to parameter of type 'struct ieee80211_link_sta *' [-Werror,-Wincompatible-pointer-types]
    1522 |                 ieee80211_rx_list(hw, sta, skb, &list);
         |                                       ^~~
   include/net/mac80211.h:5221:37: note: passing argument to parameter 'link_sta' here
    5221 |                        struct ieee80211_link_sta *link_sta,
         |                                                   ^
   drivers/net/wireless/mediatek/mt76/mac80211.c:1531:26: error: incompatible pointer types passing 'struct ieee80211_sta *' to parameter of type 'struct ieee80211_link_sta *' [-Werror,-Wincompatible-pointer-types]
    1531 |                         ieee80211_rx_list(hw, sta, skb, &list);
         |                                               ^~~
   include/net/mac80211.h:5221:37: note: passing argument to parameter 'link_sta' here
    5221 |                        struct ieee80211_link_sta *link_sta,
         |                                                   ^
   2 errors generated.
--
>> drivers/net/wireless/ath/ath11k/dp_rx.c:2503:28: error: incompatible pointer types passing 'struct ieee80211_sta *' to parameter of type 'struct ieee80211_link_sta *' [-Werror,-Wincompatible-pointer-types]
    2503 |         ieee80211_rx_napi(ar->hw, pubsta, msdu, napi);
         |                                   ^~~~~~
   include/net/mac80211.h:5250:37: note: passing argument to parameter 'link_sta' here
    5250 |                        struct ieee80211_link_sta *link_sta,
         |                                                   ^
   1 error generated.


vim +1522 drivers/net/wireless/mediatek/mt76/mac80211.c

d71ef28636e435 Felix Fietkau    2018-01-27  1506  
9d9d738b4b54c8 Felix Fietkau    2018-01-24  1507  void mt76_rx_complete(struct mt76_dev *dev, struct sk_buff_head *frames,
81e850ef2625cb Lorenzo Bianconi 2018-07-31  1508  		      struct napi_struct *napi)
17f1de56df0512 Felix Fietkau    2017-11-21  1509  {
9c68a57bc22d8c Felix Fietkau    2018-01-24  1510  	struct ieee80211_sta *sta;
bfc394dd65ef47 Felix Fietkau    2019-10-11  1511  	struct ieee80211_hw *hw;
3298b1f866fb41 Felix Fietkau    2020-07-25  1512  	struct sk_buff *skb, *tmp;
3298b1f866fb41 Felix Fietkau    2020-07-25  1513  	LIST_HEAD(list);
9d9d738b4b54c8 Felix Fietkau    2018-01-24  1514  
c3d7c82a8bb017 Felix Fietkau    2018-04-25  1515  	spin_lock(&dev->rx_lock);
9d9d738b4b54c8 Felix Fietkau    2018-01-24  1516  	while ((skb = __skb_dequeue(frames)) != NULL) {
cc4b3c139ad308 Lorenzo Bianconi 2020-10-11  1517  		struct sk_buff *nskb = skb_shinfo(skb)->frag_list;
cc4b3c139ad308 Lorenzo Bianconi 2020-10-11  1518  
3c1032e1221723 Felix Fietkau    2022-06-23  1519  		mt76_check_ccmp_pn(skb);
cc4b3c139ad308 Lorenzo Bianconi 2020-10-11  1520  		skb_shinfo(skb)->frag_list = NULL;
bfc394dd65ef47 Felix Fietkau    2019-10-11  1521  		mt76_rx_convert(dev, skb, &hw, &sta);
3298b1f866fb41 Felix Fietkau    2020-07-25 @1522  		ieee80211_rx_list(hw, sta, skb, &list);
cc4b3c139ad308 Lorenzo Bianconi 2020-10-11  1523  
cc4b3c139ad308 Lorenzo Bianconi 2020-10-11  1524  		/* subsequent amsdu frames */
cc4b3c139ad308 Lorenzo Bianconi 2020-10-11  1525  		while (nskb) {
cc4b3c139ad308 Lorenzo Bianconi 2020-10-11  1526  			skb = nskb;
cc4b3c139ad308 Lorenzo Bianconi 2020-10-11  1527  			nskb = nskb->next;
cc4b3c139ad308 Lorenzo Bianconi 2020-10-11  1528  			skb->next = NULL;
cc4b3c139ad308 Lorenzo Bianconi 2020-10-11  1529  
cc4b3c139ad308 Lorenzo Bianconi 2020-10-11  1530  			mt76_rx_convert(dev, skb, &hw, &sta);
cc4b3c139ad308 Lorenzo Bianconi 2020-10-11  1531  			ieee80211_rx_list(hw, sta, skb, &list);
cc4b3c139ad308 Lorenzo Bianconi 2020-10-11  1532  		}
9d9d738b4b54c8 Felix Fietkau    2018-01-24  1533  	}
c3d7c82a8bb017 Felix Fietkau    2018-04-25  1534  	spin_unlock(&dev->rx_lock);
3298b1f866fb41 Felix Fietkau    2020-07-25  1535  
3298b1f866fb41 Felix Fietkau    2020-07-25  1536  	if (!napi) {
3298b1f866fb41 Felix Fietkau    2020-07-25  1537  		netif_receive_skb_list(&list);
3298b1f866fb41 Felix Fietkau    2020-07-25  1538  		return;
3298b1f866fb41 Felix Fietkau    2020-07-25  1539  	}
3298b1f866fb41 Felix Fietkau    2020-07-25  1540  
3298b1f866fb41 Felix Fietkau    2020-07-25  1541  	list_for_each_entry_safe(skb, tmp, &list, list) {
3298b1f866fb41 Felix Fietkau    2020-07-25  1542  		skb_list_del_init(skb);
3298b1f866fb41 Felix Fietkau    2020-07-25  1543  		napi_gro_receive(napi, skb);
3298b1f866fb41 Felix Fietkau    2020-07-25  1544  	}
9d9d738b4b54c8 Felix Fietkau    2018-01-24  1545  }
9d9d738b4b54c8 Felix Fietkau    2018-01-24  1546  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki