Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00B7F2D7810; Wed, 25 Feb 2026 06:58:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772002737; cv=none; b=eKX9VnjJQLSLSEaEZSaxmZ66NwvvELBcRSfOQnOZxSbyFXS2jr/8iinj11UjrA7d7IPiCZExyAkbZKlkvU8quOg/JovRMg7EeE0I5I/aGXVBD0TzumQHp0VM7zTiHRclUj5yx79zSfKECiCfko6LNbIcif0wzMpW1s4yfgbhg+4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772002737; c=relaxed/simple; bh=gLwKBwoklJ+HsAT01+yE9pHFhRNr7MSHvhf6tI5eA34=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Hrf/RK2ukNTgn5LfOEkHjN1x+NhAE01muO7WG3zihVUW6WY0Weo4+qIN06ahpL5mcCuWDH6e56Gf1QL0wm5HD1beCIxu3MJobTqEakPDjT/XeTUe0i5Km42xlguXnpaP4Sxz/gkMDZMWjMVMdzHacg/8ylYb83Mn6RPV9MLS+ZM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=m+Gnalhv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="m+Gnalhv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB707C116D0; Wed, 25 Feb 2026 06:58:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1772002736; bh=gLwKBwoklJ+HsAT01+yE9pHFhRNr7MSHvhf6tI5eA34=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=m+GnalhvbNEMsqKo2HQtfBZu/1TiKagN23rbHHQtN4aqQvo4AgBkgMYI3Y7WyRqaZ Pw6wJy7xJz5j5x88C4p24bINliV9ANvA9GVE1zoogLvClLXTkcVowpX++cqR0UHGVc 66XUBLfpfNE46mF4UcM3gLt4KB2IHntvmfFee+/I= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Eric Dumazet , Kuniyuki Iwashima , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.18 552/641] icmp: prevent possible overflow in icmp_global_allow() Date: Tue, 24 Feb 2026 17:24:38 -0800 Message-ID: <20260225012401.900067736@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260225012348.915798704@linuxfoundation.org> References: <20260225012348.915798704@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Eric Dumazet [ Upstream commit 034bbd806298e9ba4197dd1587b0348ee30996ea ] Following expression can overflow if sysctl_icmp_msgs_per_sec is big enough. sysctl_icmp_msgs_per_sec * delta / HZ; Fixes: 4cdf507d5452 ("icmp: add a global rate limitation") Signed-off-by: Eric Dumazet Reviewed-by: Kuniyuki Iwashima Link: https://patch.msgid.link/20260216142832.3834174-2-edumazet@google.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/ipv4/icmp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c index 9323ee0a6ac48..3e19a5d465b83 100644 --- a/net/ipv4/icmp.c +++ b/net/ipv4/icmp.c @@ -248,7 +248,8 @@ bool icmp_global_allow(struct net *net) if (delta < HZ / 50) return false; - incr = READ_ONCE(net->ipv4.sysctl_icmp_msgs_per_sec) * delta / HZ; + incr = READ_ONCE(net->ipv4.sysctl_icmp_msgs_per_sec); + incr = div_u64((u64)incr * delta, HZ); if (!incr) return false; -- 2.51.0