Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDA5C26560B; Wed, 25 Feb 2026 01:38:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771983501; cv=none; b=BbKYrlpjUYSvxslErcb18z0OPtlMw08lJ0qPk0TLJTWMGjt3R3H+2EJMD4XSNY4FrWqu7PI4u7JFNPUSxnjlbdiTfthwPOwwO/AKt76gaNOk2K3QeTWdsckU9xo1hgJmZyqOZkHMc/qEAIWpngPs1R8IoOp5JLzHNTDnfCYzclc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771983501; c=relaxed/simple; bh=XHtD13x39PgmmrIne7hgFe3+Wnme8NtsfVM0CsR3p74=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Txlx4vC6tVZiitztgYsFP55g9Dp9gPIh4iuA+GYligwHlLAYnkQqN4Pr8WnNUq5WHSdHUHBAAjrf+Ezqx+4utzpRQ6JUib38eOd1fvcZ9tlOSGSuk5KNMEBdmDQw0RhQuI/5OGSccsVc6KF+OhPbFuz0POe1cwSO2pdCeZ2KM4o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Q5DSEdsS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Q5DSEdsS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7578DC116D0; Wed, 25 Feb 2026 01:38:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1771983501; bh=XHtD13x39PgmmrIne7hgFe3+Wnme8NtsfVM0CsR3p74=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Q5DSEdsSgmexPqQ6oG5RqcVezPQdJMlJFNi6rZjZL7xjpbyU80kebyh0gHqXDYX4S d/JpP1bTAn1XbDTrVNUwQqfEHHAmmVinv7OaCE118GwKeHBAcCI61qrNiU3QTss/16 R/qVVW6/prIO+jCgvKtLx4AhAwOaTvgQ2gQWvSKo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jared Kangas , Frank Li , Vinod Koul , Sasha Levin Subject: [PATCH 6.19 610/781] dmaengine: fsl-edma: dont explicitly disable clocks in .remove() Date: Tue, 24 Feb 2026 17:21:59 -0800 Message-ID: <20260225012414.757240771@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260225012359.695468795@linuxfoundation.org> References: <20260225012359.695468795@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jared Kangas [ Upstream commit 666c53e94c1d0bf0bdf14c49505ece9ddbe725bc ] The clocks in fsl_edma_engine::muxclk are allocated and enabled with devm_clk_get_enabled(), which automatically cleans these resources up, but these clocks are also manually disabled in fsl_edma_remove(). This causes warnings on driver removal for each clock: edma_module already disabled WARNING: CPU: 0 PID: 418 at drivers/clk/clk.c:1200 clk_core_disable+0x198/0x1c8 [...] Call trace: clk_core_disable+0x198/0x1c8 (P) clk_disable+0x34/0x58 fsl_edma_remove+0x74/0xe8 [fsl_edma] [...] ---[ end trace 0000000000000000 ]--- edma_module already unprepared WARNING: CPU: 0 PID: 418 at drivers/clk/clk.c:1059 clk_core_unprepare+0x1f8/0x220 [...] Call trace: clk_core_unprepare+0x1f8/0x220 (P) clk_unprepare+0x34/0x58 fsl_edma_remove+0x7c/0xe8 [fsl_edma] [...] ---[ end trace 0000000000000000 ]--- Fix these warnings by removing the unnecessary fsl_disable_clocks() call in fsl_edma_remove(). Fixes: a9903de3aa16 ("dmaengine: fsl-edma: refactor using devm_clk_get_enabled") Signed-off-by: Jared Kangas Reviewed-by: Frank Li Link: https://patch.msgid.link/20260113-fsl-edma-clock-removal-v1-1-2025b49e7bcc@redhat.com Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/fsl-edma-main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c index a753b7cbfa7a3..dbcdd1e683190 100644 --- a/drivers/dma/fsl-edma-main.c +++ b/drivers/dma/fsl-edma-main.c @@ -915,7 +915,6 @@ static void fsl_edma_remove(struct platform_device *pdev) of_dma_controller_free(np); dma_async_device_unregister(&fsl_edma->dma_dev); fsl_edma_cleanup_vchan(&fsl_edma->dma_dev); - fsl_disable_clocks(fsl_edma, fsl_edma->drvdata->dmamuxs); } static int fsl_edma_suspend_late(struct device *dev) -- 2.51.0