Date: Fri, 27 Feb 2026 16:17:46 -0700
From: Nathan Chancellor <nathan@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, patches@lists.linux.dev,
	Takashi Iwai <tiwai@suse.de>, Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 6.19 215/781] ALSA: pcm: Relax __free() variable
 declarations
Message-ID: <20260227231746.GA1772942@ax162>
References: <20260225012359.695468795@linuxfoundation.org>
 <20260225012404.989195256@linuxfoundation.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260225012404.989195256@linuxfoundation.org>

On Tue, Feb 24, 2026 at 05:15:24PM -0800, Greg Kroah-Hartman wrote:
> 6.19-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Takashi Iwai <tiwai@suse.de>
> 
> [ Upstream commit f3d233daf011abbad2f6ebd0e545b42d2f378a4f ]
> 
> We used to have a variable declaration with __free() initialized with
> NULL.  This was to keep the old coding style rule, but recently it's
> relaxed and rather recommends to follow the new rule to declare in
> place of use for __free() -- which avoids potential deadlocks or UAFs
> with nested cleanups.
> 
> Although the current code has no bug, per se, let's follow the new
> standard and move the declaration to the place of assignment (or
> directly assign the allocated result) instead of NULL initializations.
> 
> Fixes: ae9213984864 ("ALSA: pcm: Use automatic cleanup of kfree()")
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> Link: https://patch.msgid.link/20251216140634.171890-4-tiwai@suse.de
> Signed-off-by: Sasha Levin <sashal@kernel.org>

Please apply commit 0585c53b2154 ("ALSA: pcm: Revert bufs move in
snd_pcm_xfern_frames_ioctl()") to all branches that took this change to
fix the build with older supported versions of clang.

  https://storage.tuxsuite.com/public/clangbuiltlinux/nathan/builds/3AEpAuS5jtheTnTL9iDLNAiYTw3/build.log

Cheers,
Nathan