Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C6CE3009C7; Sun, 1 Mar 2026 01:53:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772329996; cv=none; b=b8KFb3DCsYy2iqXVYeolgi5PFnJzkHRv5qVy2pcge4oucftZF+Lh4E8N+TMnbyxq0ZUcj1yQxEDpiX+ew7SNyoL1/kYrvkdPRMF9Xft48og40baVM2m0DZNcC1xkmV60JjVzcZOU7wEC0c1KrKiLbYQJLdPbXJZb6i+3Cm5H0P4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772329996; c=relaxed/simple; bh=nwnikz7Y97S+6RINtBisdr3vqkYaqZ5m2FkQ+sicu4Q=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZDGnLKtt+8PrZKOC4ivLEWqaPkOr5VT39wLhKgsCmGEbTuTJN2HILd8qrAC0C1K4/X95qBsapOkotMbqweRxfGWHeYe2aElXaev5gF/yqpFB6wiuGS5/Ba8FMWVAwVmcTRbUQshQIp/Zry6qdBVntJwh9mfdjHKhnsUeLizQ8Mk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FPmwmDJW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FPmwmDJW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52D3FC19424; Sun, 1 Mar 2026 01:53:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772329996; bh=nwnikz7Y97S+6RINtBisdr3vqkYaqZ5m2FkQ+sicu4Q=; h=From:To:Cc:Subject:Date:From; b=FPmwmDJWtifR9D++epTFHsytCM2HBr6nwjI5RWj4kXlCXlGMBQA8xxY5vO/NB8mXq cRaNx6bkSwfGUf3lnc9+F7/MTzvb9KRr7mE2iF68a5n9jbuRXvcGOIz3oeN/Dwgdji HBKJ+lna9aclO08A0I/WozX+64iWQkP/nCoZ9xGWP1NYnSMrXQPYK0NqnponDnWt69 Pj9cHg4jHAHygasTC7fZtcmI0bPub49dpWFPYJePHjFE05LbuOlcQnVKP5X10jQ//x 3c3Esvv3u4BZajmA6f+y9Hba5ilg3rMQEuyzodJcqU5Fzj8jzpTwpp6202jsRgj27r PMUfuXjjMMWdQ== From: Sasha Levin To: stable@vger.kernel.org, schnelle@linux.ibm.com Cc: Benjamin Block , Bjorn Helgaas , Gerd Bayer , linux-pci@vger.kernel.org Subject: FAILED: Patch "PCI/IOV: Fix race between SR-IOV enable/disable and hotplug" failed to apply to 5.15-stable tree Date: Sat, 28 Feb 2026 20:53:13 -0500 Message-ID: <20260301015314.1719938-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Hint: ignore X-stable: review Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.15-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . Thanks, Sasha ------------------ original commit in Linus's tree ------------------ From a5338e365c4559d7b4d7356116b0eb95b12e08d5 Mon Sep 17 00:00:00 2001 From: Niklas Schnelle Date: Tue, 16 Dec 2025 23:14:03 +0100 Subject: [PATCH] PCI/IOV: Fix race between SR-IOV enable/disable and hotplug Commit 05703271c3cd ("PCI/IOV: Add PCI rescan-remove locking when enabling/disabling SR-IOV") tried to fix a race between the VF removal inside sriov_del_vfs() and concurrent hot unplug by taking the PCI rescan/remove lock in sriov_del_vfs(). Similarly the PCI rescan/remove lock was also taken in sriov_add_vfs() to protect addition of VFs. This approach however causes deadlock on trying to remove PFs with SR-IOV enabled because PFs disable SR-IOV during removal and this removal happens under the PCI rescan/remove lock. So the original fix had to be reverted. Instead of taking the PCI rescan/remove lock in sriov_add_vfs() and sriov_del_vfs(), fix the race that occurs with SR-IOV enable and disable vs hotplug higher up in the callchain by taking the lock in sriov_numvfs_store() before calling into the driver's sriov_configure() callback. Fixes: 05703271c3cd ("PCI/IOV: Add PCI rescan-remove locking when enabling/disabling SR-IOV") Reported-by: Benjamin Block Signed-off-by: Niklas Schnelle Signed-off-by: Bjorn Helgaas Reviewed-by: Benjamin Block Reviewed-by: Gerd Bayer Cc: stable@vger.kernel.org Link: https://patch.msgid.link/20251216-revert_sriov_lock-v3-2-dac4925a7621@linux.ibm.com --- drivers/pci/iov.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c index 7de5b18647beb..4a659c34935e1 100644 --- a/drivers/pci/iov.c +++ b/drivers/pci/iov.c @@ -495,7 +495,9 @@ static ssize_t sriov_numvfs_store(struct device *dev, if (num_vfs == 0) { /* disable VFs */ + pci_lock_rescan_remove(); ret = pdev->driver->sriov_configure(pdev, 0); + pci_unlock_rescan_remove(); goto exit; } @@ -507,7 +509,9 @@ static ssize_t sriov_numvfs_store(struct device *dev, goto exit; } + pci_lock_rescan_remove(); ret = pdev->driver->sriov_configure(pdev, num_vfs); + pci_unlock_rescan_remove(); if (ret < 0) goto exit; -- 2.51.0