Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EF87394476; Mon, 23 Mar 2026 14:44:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774277079; cv=none; b=f/MAosw8b46phkuW3+s+/v15gv/C+Uidir5vY13OBerALvdTYxCtDc9WVvIPwB3DLWamVgvB11ugnmk/HabZimkigZOmTfR3LXepyF/pkhqDwF437UxtUEJKu5/LFrT+HI0ZDjhlfG4NK0nwimMugedDFSqA5rgCZeleOBs7xyY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774277079; c=relaxed/simple; bh=3VT75q+d7nVL9zKUODLC774Orox/1hCet5mAD1w44gs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mCvp1rX8y4s2Eg9PpCticxECQsckQnf4AziYIjjo85aSuR3bXfJBIyv+DoCuJLyUrJWs32pZkDNmzaCuKYfEfeSXN4xy6zRuslXU0jlv2q1twJVUUo/pl8mBj6rK0TujKzjk/pV+b1WGiOd/lMbHrdyTPllsQoT88SVIeIApI5U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Kn3K7Yf+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Kn3K7Yf+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 260AFC4CEF7; Mon, 23 Mar 2026 14:44:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1774277079; bh=3VT75q+d7nVL9zKUODLC774Orox/1hCet5mAD1w44gs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Kn3K7Yf+mx9V7C4wINTRj6pNHTCK2zfxQcM5MouW+hbkysAx++cEsOpQ/1lKD+sNi DVer/dUwE+2LrpeUziNjcXOrP2I/MDs+juVvpBW4JEEnhrpyHpf3IDd5GXKAdsf0tG fB9sVJckKdDroUGVs6XKraowhNdqMMwRbbJxX22o= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ian Ray , Jakub Kicinski Subject: [PATCH 6.12 313/460] NFC: nxp-nci: allow GPIOs to sleep Date: Mon, 23 Mar 2026 14:45:09 +0100 Message-ID: <20260323134534.192338988@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260323134526.647552166@linuxfoundation.org> References: <20260323134526.647552166@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ian Ray commit 55dc632ab2ac2889b15995a9eef56c753d48ebc7 upstream. Allow the firmware and enable GPIOs to sleep. This fixes a `WARN_ON' and allows the driver to operate GPIOs which are connected to I2C GPIO expanders. -- >8 -- kernel: WARNING: CPU: 3 PID: 2636 at drivers/gpio/gpiolib.c:3880 gpiod_set_value+0x88/0x98 -- >8 -- Fixes: 43201767b44c ("NFC: nxp-nci: Convert to use GPIO descriptor") Cc: stable@vger.kernel.org Signed-off-by: Ian Ray Link: https://patch.msgid.link/20260317085337.146545-1-ian.ray@gehealthcare.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/nfc/nxp-nci/i2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/nfc/nxp-nci/i2c.c +++ b/drivers/nfc/nxp-nci/i2c.c @@ -47,8 +47,8 @@ static int nxp_nci_i2c_set_mode(void *ph { struct nxp_nci_i2c_phy *phy = (struct nxp_nci_i2c_phy *) phy_id; - gpiod_set_value(phy->gpiod_fw, (mode == NXP_NCI_MODE_FW) ? 1 : 0); - gpiod_set_value(phy->gpiod_en, (mode != NXP_NCI_MODE_COLD) ? 1 : 0); + gpiod_set_value_cansleep(phy->gpiod_fw, (mode == NXP_NCI_MODE_FW) ? 1 : 0); + gpiod_set_value_cansleep(phy->gpiod_en, (mode != NXP_NCI_MODE_COLD) ? 1 : 0); usleep_range(10000, 15000); if (mode == NXP_NCI_MODE_COLD)