Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E33223BF66E; Mon, 23 Mar 2026 16:27:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774283253; cv=none; b=fcH2k23FPjjNqa3E4dV8l1biALUGrRKRXCxcBWqq6FLRj9Xp74Sd3PAMqV/98V/zcIdtAjvW/bUGptmWOPBDDKiA3dGibuXgv1m/LD/JrNhNT1hyS26IiZxb7WZ/OveKsqV1fK74J35r7QmOdeqIYsMzhGQOzH2l+E2FfitQYEk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774283253; c=relaxed/simple; bh=yjER4XW7wcOIKHND+XM2PRC+t/F8AWb5cvkZEsXAa+4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MGb+MQPhrbkr1CKZoLMswWQdMPa8965ABIiY8pgXGDHrSg13LDKH54+uUH/cLLumkXJR/+vwZ2APTVQhw/StxMOHxvdIFrciv3a/43I3GauEtDV8RmbAFFfB5VgxrXeoBkoEwOvf/EEEBg24S9e0V+Yq0jJTFhR6pCmf7iuZhmo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ncWNGCU5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ncWNGCU5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA4AEC4CEF7; Mon, 23 Mar 2026 16:27:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1774283252; bh=yjER4XW7wcOIKHND+XM2PRC+t/F8AWb5cvkZEsXAa+4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ncWNGCU55oS/vBdQxD2H8MsVhQHRH86kEZjeDqM8sk5V018yR3xMGnSMfAWAF59af wMoh1LZczFYwePwtmfOhfdMkEtSikSIX1ZW1nImPRbpKPbJeBV7MtT6mtVsB7EZm61 mVZ/Gqfv3/+yxsLpPc64Edzd+hlzyUteP/fN9pTU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Heiko Carstens , Vasily Gorbik Subject: [PATCH 6.1 457/481] s390/xor: Fix xor_xc_2() inline assembly constraints Date: Mon, 23 Mar 2026 14:47:19 +0100 Message-ID: <20260323134536.350838329@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260323134525.256603107@linuxfoundation.org> References: <20260323134525.256603107@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Heiko Carstens commit f775276edc0c505dc0f782773796c189f31a1123 upstream. The inline assembly constraints for xor_xc_2() are incorrect. "bytes", "p1", and "p2" are input operands, while all three of them are modified within the inline assembly. Given that the function consists only of this inline assembly it seems unlikely that this may cause any problems, however fix this in any case. Fixes: 2cfc5f9ce7f5 ("s390/xor: optimized xor routing using the XC instruction") Cc: stable@vger.kernel.org Signed-off-by: Heiko Carstens Reviewed-by: Vasily Gorbik Link: https://lore.kernel.org/r/20260302133500.1560531-2-hca@linux.ibm.com Signed-off-by: Vasily Gorbik Signed-off-by: Greg Kroah-Hartman --- arch/s390/lib/xor.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/arch/s390/lib/xor.c +++ b/arch/s390/lib/xor.c @@ -29,8 +29,8 @@ static void xor_xc_2(unsigned long bytes " j 3f\n" "2: xc 0(1,%1),0(%2)\n" "3:\n" - : : "d" (bytes), "a" (p1), "a" (p2) - : "0", "1", "cc", "memory"); + : "+d" (bytes), "+a" (p1), "+a" (p2) + : : "0", "1", "cc", "memory"); } static void xor_xc_3(unsigned long bytes, unsigned long * __restrict p1,