Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C687126D4F9; Mon, 23 Mar 2026 14:51:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774277509; cv=none; b=H/PCmpo72oLh+PKOI0ap5t213C7PK5Xij4nq0Kd1OOGU5HTrUTBJ+7Ak4YvPhL7/S4jhDIWT7l8bzmF3wg5FVdVRUf8K672ari61dHLdy0HF7pSRUQQ4ksuIt2uVKIc3FbskLgzCw7Z8YFlYMEqkVrpAf40QyXNDQn/QEtzyg0k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774277509; c=relaxed/simple; bh=VlabTOk98ggNaKlEq6t37thx/Sbj5g018pyZKYF4jD8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Nh0Na0M64wPv04+GA1sBEtIPvEVnxjRImN7Tt1zbJEE2WQ6AoNRPXqELIhb1PWq/hIstuzE36MsjW9SJXjvbuHBJjCfbMLCq5yFD9y/aXcUTeH87ubyv5K3lav8zoKbb32URla0+o93rTjmAw9EPN8heZwc74oZl9I3oBdEJTvU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=n4L/8QGF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="n4L/8QGF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33804C4CEF7; Mon, 23 Mar 2026 14:51:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1774277509; bh=VlabTOk98ggNaKlEq6t37thx/Sbj5g018pyZKYF4jD8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=n4L/8QGF4XiBJ8PXNIp+nT4j5S8gTTSF+Aefbkw4XgTIZKHzMHWOo7gGDFkCbzc+u oI64IppXSU5kB7QL1FiPCgelSriBaEGLC+bOxAHoCARonVmO/Hp3aLTOms4++J2a0P 6eC+FTW1nVc51SR/gUeeu+8T3R5L4RFmt9VhuekU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sanman Pradhan , Guenter Roeck Subject: [PATCH 6.12 434/460] hwmon: (pmbus/mp2975) Add error check for pmbus_read_word_data() return value Date: Mon, 23 Mar 2026 14:47:10 +0100 Message-ID: <20260323134537.222862863@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260323134526.647552166@linuxfoundation.org> References: <20260323134526.647552166@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sanman Pradhan commit 19d4b9c8a136704d5f2544e7ac550f27918a5004 upstream. mp2973_read_word_data() XORs the return value of pmbus_read_word_data() with PB_STATUS_POWER_GOOD_N without first checking for errors. If the I2C transaction fails, a negative error code is XORed with the constant, producing a corrupted value that is returned as valid status data instead of propagating the error. Add the missing error check before modifying the return value. Fixes: acda945afb465 ("hwmon: (pmbus/mp2975) Fix PGOOD in READ_STATUS_WORD") Cc: stable@vger.kernel.org Signed-off-by: Sanman Pradhan Link: https://lore.kernel.org/r/20260317173308.382545-3-sanman.pradhan@hpe.com Signed-off-by: Guenter Roeck Signed-off-by: Greg Kroah-Hartman --- drivers/hwmon/pmbus/mp2975.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/hwmon/pmbus/mp2975.c +++ b/drivers/hwmon/pmbus/mp2975.c @@ -313,6 +313,8 @@ static int mp2973_read_word_data(struct case PMBUS_STATUS_WORD: /* MP2973 & MP2971 return PGOOD instead of PB_STATUS_POWER_GOOD_N. */ ret = pmbus_read_word_data(client, page, phase, reg); + if (ret < 0) + return ret; ret ^= PB_STATUS_POWER_GOOD_N; break; case PMBUS_OT_FAULT_LIMIT: