Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19A913CC9E9; Mon, 23 Mar 2026 15:20:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774279212; cv=none; b=GyRR/OwlNxbDr68ZZGpPpIiwgq/1/YbDUoKyPK58dqtGHHQMri6WUSRXuTg8SQ7BBuoSyFRTCy9xbQH0PugttMgnBP+/UiFT1qdn9UGnMMLtuRTia9es1hBZa2dhyhdVhPYSoHnSwyBfBzCu1soC5Pvu5Bax8GI7vAd6znVQ86M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774279212; c=relaxed/simple; bh=ZG2RI/yE7y3T2SbmDcVz2I3yLnhZ09ZVTRTodNEdCWA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ea5/zeqdGV6O+syTOCjReDludqwhzpUuT630+IqG0UFnMQizEgyvCrI4GWQSj+R+oMG+q9zYLIsWKVStmVjH/gIVS4oY3/J9uqCtsHXr/7bl12jYc1Kihdo9QUGdjt1Z1rF9OF+cdOpaueQvJpiCVE1rX3RT+P0JsvqzSqKOmqY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=OFajC6r0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="OFajC6r0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92C31C2BC9E; Mon, 23 Mar 2026 15:20:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1774279211; bh=ZG2RI/yE7y3T2SbmDcVz2I3yLnhZ09ZVTRTodNEdCWA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OFajC6r02MwhsrirTd/HrgES1dM/JJVIjN1DUK4PfweTa29MkR6N00se4xTe6NB6z IUfGEEY3kzD/ux2xe56dnIqCUSDn142wgIfJcziypTzZJ7rndmqd3fcx/qqNLBgb6G 0kKbJyQ8nRNYSww62wTTnxYNEQlli433TuHHVYZg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Antoniu Miclaus , Linus Walleij , Stable@vger.kernel.org, Jonathan Cameron , Sasha Levin Subject: [PATCH 6.6 468/567] iio: light: bh1780: fix PM runtime leak on error path Date: Mon, 23 Mar 2026 14:46:28 +0100 Message-ID: <20260323134545.564306673@linuxfoundation.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260323134533.749096647@linuxfoundation.org> References: <20260323134533.749096647@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Antoniu Miclaus [ Upstream commit dd72e6c3cdea05cad24e99710939086f7a113fb5 ] Move pm_runtime_put_autosuspend() before the error check to ensure the PM runtime reference count is always decremented after pm_runtime_get_sync(), regardless of whether the read operation succeeds or fails. Fixes: 1f0477f18306 ("iio: light: new driver for the ROHM BH1780") Signed-off-by: Antoniu Miclaus Reviewed-by: Linus Walleij Cc: Signed-off-by: Jonathan Cameron [ moved both pm_runtime_mark_last_busy() and pm_runtime_put_autosuspend() before the error check instead of just pm_runtime_put_autosuspend() ] Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/iio/light/bh1780.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/iio/light/bh1780.c +++ b/drivers/iio/light/bh1780.c @@ -109,10 +109,10 @@ static int bh1780_read_raw(struct iio_de case IIO_LIGHT: pm_runtime_get_sync(&bh1780->client->dev); value = bh1780_read_word(bh1780, BH1780_REG_DLOW); - if (value < 0) - return value; pm_runtime_mark_last_busy(&bh1780->client->dev); pm_runtime_put_autosuspend(&bh1780->client->dev); + if (value < 0) + return value; *val = value; return IIO_VAL_INT;