Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 113D3109E55A for ; Thu, 26 Mar 2026 05:51:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B45CA10E954; Thu, 26 Mar 2026 05:51:45 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="HYfQLWxu"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0ED2710E957 for ; Thu, 26 Mar 2026 05:51:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774504301; x=1806040301; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=vvocXmFKYkFhWWzL+TTN2OXOERyQ7eoYW/BEV4j8gEM=; b=HYfQLWxuG30/FweemEcmTD8hfC1z8rUizZ+R7EN0Y1M5Oihh51FbCcgO xqqQ/0rPUo3gixDVpZe4anxQxsrgkv8MgTxXN9kIU8mk9kUTt4gFnxpDf 7pngB1wiEtyZZZRykw6vG/9wnEQ3wv2/M/CrgyY2gLAi1CFZQidTqIL3i LY+S0VMLgw3TpagZZN29ZjyDxd6r0zyQwMFcpy5ONzR1WfKxXCnQJdFxj S+nX7usV8BLq2BBwGyA6ObFFqQlHUT5z279QT6rhm8tqba560br7+KrXs eaDLVKAkew+NXLwhOaDG+ZXPaiRG9Ncjdi/IAxpHp0Ta0Fbjn+x8LsAXl A==; X-CSE-ConnectionGUID: FF1EOSnjQ1C0NKkkQko9xA== X-CSE-MsgGUID: xvGtEMbbRGq7e2ZuUAHiDQ== X-IronPort-AV: E=McAfee;i="6800,10657,11740"; a="87031295" X-IronPort-AV: E=Sophos;i="6.23,141,1770624000"; d="scan'208";a="87031295" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2026 22:51:41 -0700 X-CSE-ConnectionGUID: +u5u2Oe4SP+sHCqI8olXfA== X-CSE-MsgGUID: D7cSyeXkTqiMSr7XrlbGEQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,141,1770624000"; d="scan'208";a="221585998" Received: from varungup-desk.iind.intel.com ([10.190.238.71]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2026 22:51:39 -0700 From: Arvind Yadav To: intel-xe@lists.freedesktop.org Cc: matthew.brost@intel.com, himal.prasad.ghimiray@intel.com, thomas.hellstrom@linux.intel.com Subject: [PATCH v8 08/12] drm/xe/bo: Block mmap of DONTNEED/purged BOs Date: Thu, 26 Mar 2026 11:21:07 +0530 Message-ID: <20260326055115.3422240-9-arvind.yadav@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260326055115.3422240-1-arvind.yadav@intel.com> References: <20260326055115.3422240-1-arvind.yadav@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Don't allow new CPU mmaps to BOs marked DONTNEED or PURGED. DONTNEED BOs can have their contents discarded at any time, making CPU access undefined behavior. PURGED BOs have no backing store and are permanently invalid. Return -EBUSY for DONTNEED BOs (temporary purgeable state) and -EINVAL for purged BOs (permanent, no backing store). The mmap offset ioctl now checks the BO's purgeable state before allowing userspace to establish a new CPU mapping. This prevents the race where userspace gets a valid offset but the BO is purged before actual faulting begins. Existing mmaps (established before DONTNEED) may still work until pages are purged, at which point CPU faults fail with SIGBUS. v6: - Split DONTNEED → -EBUSY and PURGED → -EINVAL for consistency with the rest of the series (Thomas, Matt) v7: - Move purgeable check from xe_gem_mmap_offset_ioctl() into a new xe_gem_object_mmap() callback that wraps drm_gem_ttm_mmap(). (Thomas) - Use an interruptible lock. (Thomas) v8: - Check xe_bo_lock() return value and propagate error. (Thomas and Matt) Cc: Matthew Brost Cc: Thomas Hellström Cc: Himal Prasad Ghimiray Signed-off-by: Arvind Yadav --- drivers/gpu/drm/xe/xe_bo.c | 27 ++++++++++++++++++++++++++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/xe_bo.c index da18b43650e3..c8e3a3fd4880 100644 --- a/drivers/gpu/drm/xe/xe_bo.c +++ b/drivers/gpu/drm/xe/xe_bo.c @@ -2165,10 +2165,35 @@ static const struct vm_operations_struct xe_gem_vm_ops = { .access = xe_bo_vm_access, }; +static int xe_gem_object_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma) +{ + struct xe_bo *bo = gem_to_xe_bo(obj); + int err = 0; + + /* + * Reject mmap of purgeable BOs. DONTNEED BOs can be purged + * at any time, making CPU access undefined behavior. Purged BOs have + * no backing store and are permanently invalid. + */ + err = xe_bo_lock(bo, true); + if (err) + return err; + + if (xe_bo_madv_is_dontneed(bo)) + err = -EBUSY; + else if (xe_bo_is_purged(bo)) + err = -EINVAL; + xe_bo_unlock(bo); + if (err) + return err; + + return drm_gem_ttm_mmap(obj, vma); +} + static const struct drm_gem_object_funcs xe_gem_object_funcs = { .free = xe_gem_object_free, .close = xe_gem_object_close, - .mmap = drm_gem_ttm_mmap, + .mmap = xe_gem_object_mmap, .export = xe_gem_prime_export, .vm_ops = &xe_gem_vm_ops, }; -- 2.43.0