Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A1573F787B for ; Tue, 31 Mar 2026 21:36:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774992962; cv=none; b=mp5qemjc3sTFW9JTS02kw/Ubf0fphlzAO5Mi44g3Twco3wc2HaWyH+5/yHg3HYbmt8pLlv1gUIoXPoPaSGA8fWkvF4AWtACgKvN3rJV8FGpe+HVrB+iHOIsrYVNxHAzN4DF9SdU/wlJN+rbSno9z0aM5tjFGHi9L5BaBNDkqSBs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774992962; c=relaxed/simple; bh=N0z+iOgnUpZcR0PR9xBIKBcM60dzWmlW1AX1IsrHgr0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FdNHwuMKkKlHGysenbKVI4yx//1drVGkSyqG2MAu0AO4IGd3L7QIPMjvB7k6W1C98f0eNgZ61vtHLfGFMSew7N1zM8nfVtHJEwAmS+Hi/LOZLnEVDS9EA1ALD2idP51jzJQqRMgeLmJQ/B8IVz6jkly2p1OlCyE0PH7jWDjGQ3g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qNTRVQAx; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qNTRVQAx" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-35d99031e4eso2222185a91.1 for ; Tue, 31 Mar 2026 14:36:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774992960; x=1775597760; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zVXUr8D+l0ObA6lwaJJ/rqnWu9Wd+yhlgQ59VMrWnqg=; b=qNTRVQAxLwm7OQ0zRxil/nkqBKG9FSqzF+8e5qaVdE/d5dJeQedVBKDX1pT84HGIKs 5zGv2COibogEze98bJlqFQkicOISipMwbHlORw5XyoTZ12owcigAeFAgVTe2S8b0Cigo 8a0BwlZpGOk4YM61HQzAQlrmOKIecdsON3+mKXY7c3SE6MTTIYs0KTOoQZfFeXnAUY91 LAmVxhUoafhYoqbKP/J1cVejQuaShkBy8UIHCDLGMVjIW4huDV2ElcVjDn1vibzc73cZ FgW30JYK+VELpGE06VeDmBdwUv3ZrdG9vfDGjpTec/fZcKOwqPktZG0TkkmiwkkEajLt EMmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774992960; x=1775597760; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zVXUr8D+l0ObA6lwaJJ/rqnWu9Wd+yhlgQ59VMrWnqg=; b=BR7VfZ8qveiBZgisJUbXbNP8zEp+S55J6dDze1j7pHLN90NYrrCDZVFsi1SPnyhogQ O1VWpc8Sag0eLGdrFzSQkOCLt1IlD1JAv0FISMPMXu8uc1WAU73g6upYm9S0nA0GFJBi aBr2v38aSAqqwI11px66E81dQWMVPpRcM6eW5DVsCtGYCq6XWrZLL+QJFhFFkCLRRys2 ptEGdOVx09dlGeK+pfn3YFIrpr/q+2ZmwmidM8++WT2Wobe0UadkfjsZJ8ERdyZVgjED 9hTrFjoeqAiYHAOEMDsJtuuBHd7SAG8ZD/4P+JdVmxvjiY5HtMNRgvo1/RF42jjNQTti oZMg== X-Gm-Message-State: AOJu0Yyp3wU9zPOtMWj4vKYyQTeX/1J7ZO3kqA091NhKY94G2X33O1QC 1H420jKzotgufElFzFf6amDWr4q68HeorgSV8c5dSFGz6mdXLBzLbyZEzKrB4A== X-Gm-Gg: ATEYQzzJT2B5urpT1wSNQ/2mfW+TSRDPZq3+D638NGb7942W1BZ8ExVx3JrzmzqDFBs Wf3ePYhlc8zHklFk9/FYGg6du2lDEWPVCLW1Z4dOAb7HypUa7wlYRhusoSPAkW9mjUFbXwtYIHA KpVdtO+wwKnnozQfD3xF/oLcG0yoy/dZwiVal1sLnAYxE11hs6vLD297TauIvv7gSVdR34qXtPz UaKYJ+fqWRTriKAeQNxy7ZDe7p0eG8PuFCzAYREdb8FkUlH0kJwmGo1eX98mM5Hf5SgTG4pAHAw UebqXuK8UAD1IWfvI+vUfLGkPrUzaAecwH7irMs9QEPb7YArgs6r9dRj7yrjPg8y9UVfYlW1ZJq 3H+wxcibwfak6qkNPAJAVvR7MRjxnIBN3s8i0M7NalH4IX/NdNPecvqJXO1pbIB0ZlGwTvADFBo IO+nNZCmwH1EeKOQ== X-Received: by 2002:a17:903:40cf:b0:2b0:68d1:2537 with SMTP id d9443c01a7336-2b269cf051fmr6937325ad.42.1774992960316; Tue, 31 Mar 2026 14:36:00 -0700 (PDT) Received: from localhost ([2a03:2880:ff:57::]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b242765d49sm152410715ad.54.2026.03.31.14.35.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 14:35:59 -0700 (PDT) From: Amery Hung To: bpf@vger.kernel.org Cc: alexei.starovoitov@gmail.com, andrii@kernel.org, daniel@iogearbox.net, eddyz87@gmail.com, memxor@gmail.com, yatsenko@meta.com, ameryhung@gmail.com, kernel-team@meta.com Subject: [PATCH bpf-next v2 2/5] selftests/bpf: Simplify task_local_data memory allocation Date: Tue, 31 Mar 2026 14:35:52 -0700 Message-ID: <20260331213555.1993883-3-ameryhung@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260331213555.1993883-1-ameryhung@gmail.com> References: <20260331213555.1993883-1-ameryhung@gmail.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Simplify data allocation by always using aligned_alloc() and passing size_pot, size rounded up to the closest power of two to alignment. Currently, aligned_alloc(page_size, size) is only intended to be used with memory allocators that can fulfill the request without rounding size up to page_size to conserve memory. This is enabled by defining TLD_DATA_USE_ALIGNED_ALLOC. The reason to align to page_size is due to the limitation of UPTR where only a page can be pinned to the kernel. Otherwise, malloc(size * 2) is used to allocate memory for data. However, we don't need to call aligned_alloc(page_size, size) to get a contiguous memory of size bytes within a page. aligned_alloc(size_pot, ...) will also do the trick. Therefore, just use aligned_alloc(size_pot, ...) universally. As for the size argument, create a new option, TLD_DONT_ROUND_UP_DATA_SIZE, to specify not rounding up the size. This preserves the current TLD_DATA_USE_ALIGNED_ALLOC behavior, allowing memory allocators with low overhead aligned_alloc() to not waste memory. To enable this, users need to make sure it is not an undefined behavior for the memory allocator to have size not being an integral multiple of alignment. Compared to the current implementation, !TLD_DATA_USE_ALIGNED_ALLOC used to always waste size-byte of memory due to malloc(size * 2). Now the worst case becomes size - 1 and the best case is 0 when the size is already a power of two. Signed-off-by: Amery Hung --- .../bpf/prog_tests/task_local_data.h | 60 +++++++------------ 1 file changed, 22 insertions(+), 38 deletions(-) diff --git a/tools/testing/selftests/bpf/prog_tests/task_local_data.h b/tools/testing/selftests/bpf/prog_tests/task_local_data.h index a52d8b549425..366a6739c086 100644 --- a/tools/testing/selftests/bpf/prog_tests/task_local_data.h +++ b/tools/testing/selftests/bpf/prog_tests/task_local_data.h @@ -50,16 +50,13 @@ * TLD_MAX_DATA_CNT. * * - * TLD_DATA_USE_ALIGNED_ALLOC - Always use aligned_alloc() instead of malloc() + * TLD_DONT_ROUND_UP_DATA_SIZE - Don't round up memory size allocated for data if + * the memory allocator has low overhead aligned_alloc() implementation. * - * When allocating the memory for storing TLDs, we need to make sure there is a memory - * region of the X bytes within a page. This is due to the limit posed by UPTR: memory - * pinned to the kernel cannot exceed a page nor can it cross the page boundary. The - * library normally calls malloc(2*X) given X bytes of total TLDs, and only uses - * aligned_alloc(PAGE_SIZE, X) when X >= PAGE_SIZE / 2. This is to reduce memory wastage - * as not all memory allocator can use the exact amount of memory requested to fulfill - * aligned_alloc(). For example, some may round the size up to the alignment. Enable the - * option to always use aligned_alloc() if the implementation has low memory overhead. + * For some memory allocators, when calling aligned_alloc(alignment, size), size + * does not need to be an integral multiple of alignment and it can be fulfilled + * without using round_up(size, alignment) bytes of memory. Enable this option to + * reduce memory usage. */ #define TLD_PAGE_SIZE getpagesize() @@ -68,6 +65,8 @@ #define TLD_ROUND_MASK(x, y) ((__typeof__(x))((y) - 1)) #define TLD_ROUND_UP(x, y) ((((x) - 1) | TLD_ROUND_MASK(x, y)) + 1) +#define TLD_ROUND_UP_POWER_OF_TWO(x) (1UL << (sizeof(x) * 8 - __builtin_clzl(x - 1))) + #define TLD_READ_ONCE(x) (*(volatile typeof(x) *)&(x)) #ifndef TLD_DYN_DATA_SIZE @@ -111,7 +110,6 @@ struct tld_map_value { struct tld_meta_u * _Atomic tld_meta_p __attribute__((weak)); __thread struct tld_data_u *tld_data_p __attribute__((weak)); -__thread void *tld_data_alloc_p __attribute__((weak)); #ifdef TLD_FREE_DATA_ON_THREAD_EXIT pthread_key_t tld_pthread_key __attribute__((weak)); @@ -153,12 +151,10 @@ static int __tld_init_meta_p(void) static int __tld_init_data_p(int map_fd) { - bool use_aligned_alloc = false; struct tld_map_value map_val; struct tld_data_u *data; - void *data_alloc = NULL; int err, tid_fd = -1; - size_t size; + size_t size, size_pot; tid_fd = syscall(SYS_pidfd_open, sys_gettid(), O_EXCL); if (tid_fd < 0) { @@ -166,48 +162,37 @@ static int __tld_init_data_p(int map_fd) goto out; } -#ifdef TLD_DATA_USE_ALIGNED_ALLOC - use_aligned_alloc = true; -#endif - /* * tld_meta_p->size = TLD_DYN_DATA_SIZE + * total size of TLDs defined via TLD_DEFINE_KEY() */ size = tld_meta_p->size + sizeof(struct tld_data_u); - data_alloc = (use_aligned_alloc || size * 2 >= TLD_PAGE_SIZE) ? - aligned_alloc(TLD_PAGE_SIZE, size) : - malloc(size * 2); - if (!data_alloc) { + size_pot = TLD_ROUND_UP_POWER_OF_TWO(size); +#ifdef TLD_DONT_ROUND_UP_DATA_SIZE + data = (struct tld_data_u *)aligned_alloc(size_pot, size); +#else + data = (struct tld_data_u *)aligned_alloc(size_pot, size_pot); +#endif + if (!data) { err = -ENOMEM; goto out; } /* * Always pass a page-aligned address to UPTR since the size of tld_map_value::data - * is a page in BTF. If data_alloc spans across two pages, use the page that contains large - * enough memory. + * is a page in BTF. */ - if (TLD_PAGE_SIZE - (~TLD_PAGE_MASK & (intptr_t)data_alloc) >= tld_meta_p->size) { - map_val.data = (void *)(TLD_PAGE_MASK & (intptr_t)data_alloc); - data = data_alloc; - data->start = (~TLD_PAGE_MASK & (intptr_t)data_alloc) + - offsetof(struct tld_data_u, data); - } else { - map_val.data = (void *)(TLD_ROUND_UP((intptr_t)data_alloc, TLD_PAGE_SIZE)); - data = (void *)(TLD_ROUND_UP((intptr_t)data_alloc, TLD_PAGE_SIZE)); - data->start = offsetof(struct tld_data_u, data); - } + map_val.data = (void *)(TLD_PAGE_MASK & (intptr_t)data); + data->start = (~TLD_PAGE_MASK & (intptr_t)data) + sizeof(struct tld_data_u); map_val.meta = TLD_READ_ONCE(tld_meta_p); err = bpf_map_update_elem(map_fd, &tid_fd, &map_val, 0); if (err) { - free(data_alloc); + free(data); goto out; } tld_data_p = data; - tld_data_alloc_p = data_alloc; #ifdef TLD_FREE_DATA_ON_THREAD_EXIT pthread_setspecific(tld_pthread_key, (void *)1); #endif @@ -375,9 +360,8 @@ static void *tld_get_data(int map_fd, tld_key_t key) __attribute__((unused)) static void tld_free(void) { - if (tld_data_alloc_p) { - free(tld_data_alloc_p); - tld_data_alloc_p = NULL; + if (tld_data_p) { + free(tld_data_p); tld_data_p = NULL; } } -- 2.52.0