From: Gert Doering Date: Sat, 4 Apr 2026 22:33:30 +0200 Message-ID: <20260404203335.30650-1-gert@...1296...> In-Reply-To: References: MIME-Version: 1.0 Subject: [Openvpn-devel] [PATCH v1] mtcp: Remove noop statement in multi_tcp_process_outgoing_link_ready List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: openvpn-devel@lists.sourceforge.net From: Frank Lichtenheld Assigning to a parameter here has no effect. I can see no obvious alternative statement that might have been intended. Found by cppcheck. Change-Id: I04a01cf536ee6d48d54ba623dda460c4a98859f9 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1609 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1609 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpn/mtcp.c b/src/openvpn/mtcp.c index 2eab7b7..7651b4d 100644 --- a/src/openvpn/mtcp.c +++ b/src/openvpn/mtcp.c @@ -155,10 +155,6 @@ ASSERT(mi == item.instance); mi->context.c2.to_link = item.buffer->buf; ret = multi_process_outgoing_link_dowork(m, mi, mpp_flags); - if (!ret) - { - mi = NULL; - } mbuf_free_buf(item.buffer); } return ret;