Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A86A0358D00 for ; Mon, 6 Apr 2026 22:10:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775513430; cv=none; b=q8SDNicNcUtHVilk4MVbi0HwE56X4Pb9g9umQuq1PwljQHdd1ci4GNMojIchTRcZQO6saWrPrONng2pyjYlWhBTbmPe+9UpyyW/VdUFNKNhKWCExRR5Ss7v6T1h1kVPUoG1NJE42YrveBh/kNviYDYXmd6KhmKEh25XztN09mvw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775513430; c=relaxed/simple; bh=jUJx2dHLtWVAhCD/NwIlBJWlN7aB3C76s4JEYE9cZNI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=L1W7wCvcGscELnQZ5lxJt5Zahm0fuU2TgbbGPdJu09rOGgoE0c7ciFJdMuafEyTZ43SVm4OdhLF7BzP3XfFS7vNWR3AwgEnV1zSjZFl1yK11c26IiEWo9T6ESYYk1wfbgq27j+7kxh2id7IlIZrzrabkvKrZ/CUGjkYau8qPMcs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=Ow/9r4f1; arc=none smtp.client-ip=209.85.160.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="Ow/9r4f1" Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-506a747448dso32562091cf.0 for ; Mon, 06 Apr 2026 15:10:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1775513428; x=1776118228; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jUJx2dHLtWVAhCD/NwIlBJWlN7aB3C76s4JEYE9cZNI=; b=Ow/9r4f1wgV5ET9ewP1WS/ClATq8ocs2fqttQKEix70hzKQxvjNyvcrhWNN2zeLGdu H0BjKhwg17KhhpL7XoVjoojKW5iGKOH3Tq9u/r4uzrNvz1KBkE/Wh9TaOFNZQTPuQSTT fEscO83j5mgVedCoe3sVtHjXZy193lcLl1OXmkU8O9NomBOwVUonmm7nyeqRi3B41+vZ D4QsfV1n6EJpsGwAysjkwnttiwMMh+cq4J7m0uA7E0VhwLOidbssyV7uekxdsocdqtgD Myq8QFKgcgdBWpvyKJJBGRRvDShobEoDWkgbCbLYcQm4CMzhp59OGjGyf+Wz7LJNRABB Mj/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775513428; x=1776118228; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jUJx2dHLtWVAhCD/NwIlBJWlN7aB3C76s4JEYE9cZNI=; b=XTdnOz8djJMoN9aN9BX5liKXjzoguVyzy4Q/pusn8g3vug2Bn6uZw2m4hxcxJHeozH 12xbVFwiEgjAH7HqsOKgHzP8fOL4sw8C5Mi4NY76Zn/l37PdDWxpfbaiyU16afHN9Sjv DeKOUrcIrgQgT3yPSq4u0Aoq3mCm7y9fz/9BfdndvCCUocBAIJ2D0pWFrpw+B+gUsT9l NFzNs3SrmeAET32a6dew+EFlpsW/akPcLYBetfAcD5rB8GS4j25ay693zIFlxOVMn5C9 RS1ISrNWDcC7KS/xM0ssbyhw6sXxNY7NMijhXEv05hJ8FrfyhVoscoMLIADIL5QCuAVa yZ/g== X-Forwarded-Encrypted: i=1; AJvYcCVoErXWRUpjhI1dp0HsqCJtoYDJEKeoL+QWw7FVIfyLknMdcI1fowX8jHJCP+CyirY1G0I=@vger.kernel.org X-Gm-Message-State: AOJu0YzKbZ+5DxMk2xQeod4yuPFdLCsiErsFBOvkvCRT4cieZE9nmLKc tUMUQ0k8DnIe9XmSb/CUJmA2FGerYD/6wDrPT02d0jLpv9BYsFP2TfgPCIvUgNi6oq0= X-Gm-Gg: AeBDietlGFSAriFZj08ZFcDdEb+e5US2evyduncctb3NA2riG8ivHPVcGg3yGYYKaJD Iw2ghdIQ/+RkowFQyBT8WdQT3xcQ3leKzQeaxehboabQjMY8HoSp6JtVhK0itvkZ4qeUlN48swa uCralOSS/6mFp5PK3EWqKZHGmVtVSSidsvZmwFyy6gKzjNm3EvV8juN4S8RGWrmR4m9LuVjzQQi HFwiU9f1cRMPpBLq5gvlW9H8eOdh1YcV0oprRNseVZqSutuT8KOrE7mzGJ1X2ibd3R5qari/kkT wn65DnYj9I9qEQOHk80McOVx5Le5WXn3a7F2GyGbIH3NVcSJ/yn4HbLCpPy1/a8Nm46NCUFYtqs hhByNI/vLtQ1zofgeBdCTQqKkf/EM6E7K2o10xX+iMdcsnv9i5yrW5D56ElYLhfmbl4Pd8wZ57Z ET1yl3yZJaWYKT16/EM3UsKiKwboNwZ5mBAGhODLpvS5UF3KCv7KIsRnZBoaS4IbMZBwZSUg== X-Received: by 2002:a05:622a:418b:b0:50d:89f0:9a00 with SMTP id d75a77b69052e-50d89f142e1mr93804951cf.42.1775513427598; Mon, 06 Apr 2026 15:10:27 -0700 (PDT) Received: from ziepe.ca (mctnnbsa70w-159-2-73-22.dhcp-dynamic.fibreop.nb.bellaliant.net. [159.2.73.22]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50d4b93dd10sm122148721cf.7.2026.04.06.15.10.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 15:10:26 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1w9s9J-0000000E4pT-1Nq1; Mon, 06 Apr 2026 19:10:25 -0300 Date: Mon, 6 Apr 2026 19:10:25 -0300 From: Jason Gunthorpe To: Dan Williams Cc: mhonap@nvidia.com, alwilliamson@nvidia.com, jonathan.cameron@huawei.com, dave.jiang@intel.com, alejandro.lucero-palau@amd.com, dave@stgolabs.net, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, dmatlack@google.com, shuah@kernel.org, yishaih@nvidia.com, skolothumtho@nvidia.com, kevin.tian@intel.com, ankita@nvidia.com, vsethi@nvidia.com, cjia@nvidia.com, targupta@nvidia.com, zhiw@nvidia.com, kjaju@nvidia.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v2 16/20] vfio/cxl: Register regions with VFIO layer Message-ID: <20260406221025.GH2551565@ziepe.ca> References: <20260401143917.108413-1-mhonap@nvidia.com> <20260401143917.108413-17-mhonap@nvidia.com> <69d0169115c06_1b0cc6100a5@dwillia2-mobl4.notmuch> <20260404185330.GD2551565@ziepe.ca> <69d1685538f45_556821002f@djbw-dev.notmuch> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <69d1685538f45_556821002f@djbw-dev.notmuch> On Sat, Apr 04, 2026 at 12:36:53PM -0700, Dan Williams wrote: > Then I assume it matters that memremap() sometimes silently falls back > to the direct map. The "VFIO owns" expectation needs to guard against > some helpful platform firmware mapping accelerator memory as System RAM. I don't think how memremap works under the covers matters to vfio, it takes in a phys_addr_t an gives back a KVA that is cachable kernel memory. We just have to be mindful to not allow mismatched attributes on virtual aliases. > At a minimum having VFIO fail to map in that case helps with the > argument I have been making that "no, EFI_CONVENTIONAL_MEMORY type + > EFI_SPECIFIC_PURPOSE flag" is not suitable for accelerators with private > CXL memory. Those want to be enforcing "EFI_RESERVED". Certainly it should fail the request region if something else is using it, so if those EFI flags plug it into the mm and it is plugged when VFIO starts then it should stop. The direct map isn't really "plugged into the mm" but it does raise the mismatched attributed issue. Jason