Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.117.160 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C
From: Timur Tabi <ttabi@nvidia.com>
To: Lyude Paul <lyude@redhat.com>, Dave Airlie <airlied@redhat.com>,
	<nouveau@lists.freedesktop.org>
Subject: [PATCH 1/6] drm/nouveau: check for GA100 specifically when
 calculating FRTS size
Date: Tue, 7 Apr 2026 14:21:17 -0500
Message-ID: <20260407192122.3055293-2-ttabi@nvidia.com>
In-Reply-To: <20260407192122.3055293-1-ttabi@nvidia.com>
References: <20260407192122.3055293-1-ttabi@nvidia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	Gizeh80C/8x9+B0YOOPNekoFy3OzK6tKs5Y9l2s/TBynwr+CPAHCpaW9ciKKjzzSpBOlLAifuA45uwjgzDPRnyDnIMHTBkGrJ7g/YLN8s6p2+Oan3tY1qH8g45wPZrKELhU4UjUECw0h7xcNp0xWjuSEwpEwMOdEGyQFu3/bixtDJaarOyHtfMr1NrkZTa7Hb/cWbxfIlszCyDq1e/D/PaDyKokjuQW+iX+AmawUiJvrZTtl0aJnvs1g6XcmjmSRAeM9gIi0/yv0rT/MzZhT41PmNiyxPh1Hw0qo13q3Ml+YII/flCLB5k/SWSAKoN7JVB9affO3lMuqsbLmMxeWxUA7FwxC36nvf3fFc+VrJ9LofJT4VYtJxrJxi3jPSP9moS1IYYT82MXQd8aRZU4ZIGQ/fmU9RzNk4tgfo7gqkmfVoLc3Y0JCoRigUi2TZnRq
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2026 19:21:51.6610
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 
 5f4c2d6c-3110-45d1-59ad-08de94daec16
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: 
 TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: 
	BN2PEPF000055DB.namprd21.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SAWPR12MB999139
Message-ID-Hash: HFDJFNC7JXHVWI3RDFMSHJYMX73O5XDQ
X-Message-ID-Hash: HFDJFNC7JXHVWI3RDFMSHJYMX73O5XDQ
X-MailFrom: ttabi@nvidia.com
X-Mailman-Rule-Hits: member-moderation
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency;
 loop; banned-address
X-Mailman-Version: 3.3.8
Precedence: list
List-Id: Nouveau development list <nouveau.lists.freedesktop.org>
Archived-At: 
 <https://lists.freedesktop.org/hyperkitty/list/nouveau@lists.freedesktop.org/message/HFDJFNC7JXHVWI3RDFMSHJYMX73O5XDQ/>
Archived-At: 
 <https://lore.freedesktop.org/20260407192122.3055293-2-ttabi@nvidia.com/>
List-Archive: 
 <https://lists.freedesktop.org/hyperkitty/list/nouveau@lists.freedesktop.org/>
List-Archive: <https://lore.freedesktop.org/nouveau>
List-Help: <mailto:nouveau-request@lists.freedesktop.org?subject=help>
List-Owner: <mailto:nouveau-owner@lists.freedesktop.org>
List-Post: <mailto:nouveau@lists.freedesktop.org>
List-Subscribe: <mailto:nouveau-join@lists.freedesktop.org>
List-Unsubscribe: <mailto:nouveau-leave@lists.freedesktop.org>

When booting with GSP-RM, the FRTS data region normally needs to be
allocated.  However, on GA100, this region is not used and so its
size needs to be set to zero.  The current method of looking at
device->bios is not valid, as GA100 actually does have a VBIOS.

The truth is that GA100 is just special, and the simplest way to
determine the proper FRTS data region size is to check for this
GPU specifically.

Fixes: 20e0c197802c ("drm/nouveau/gsp: add support for GA100")
Signed-off-by: Timur Tabi <ttabi@nvidia.com>
---
 drivers/gpu/drm/nouveau/nvkm/subdev/gsp/tu102.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/tu102.c b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/tu102.c
index dd82c76b8b9a..815be8d0ecf2 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/tu102.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/tu102.c
@@ -319,12 +319,12 @@ tu102_gsp_oneinit(struct nvkm_gsp *gsp)
 		return ret;
 
 	/*
-	 * Calculate FB layout. FRTS is a memory region created by the FWSEC-FRTS firmware.
-	 * FWSEC comes from VBIOS.  So on systems with no VBIOS (e.g. GA100), the FRTS does
-	 * not exist.  Therefore, use the existence of VBIOS to determine whether to reserve
-	 * an FRTS region.
+	 * Calculate FB layout. FRTS is a memory region created by running the FWSEC-FRTS
+	 * command, which writes power management data into WPR2. On GA100, the booter
+	 * firmware handles WPR2 setup directly and FRTS data is not needed, so no FRTS
+	 * region is reserved.
 	 */
-	gsp->fb.wpr2.frts.size = device->bios ? 0x100000 : 0;
+	gsp->fb.wpr2.frts.size = device->chipset == 0x170 ? 0 : 0x100000;
 	gsp->fb.wpr2.frts.addr = ALIGN_DOWN(gsp->fb.bios.addr, 0x20000) - gsp->fb.wpr2.frts.size;
 
 	gsp->fb.wpr2.boot.size = gsp->boot.fw.size;
-- 
2.53.0