Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F096333262C for ; Thu, 9 Apr 2026 19:01:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775761279; cv=none; b=MgZJ7Qu7xkVNyn3Xr1rzhsaICJsjfYRwAbCgSmpm4RIQWSKxQCGgZ+3FJnV5ysQa4thLtWpeuCj90UsOTaq09kQ498CyzI6bhDzLQN4rwGxEMSOQhyCSKlzQqLyJCV9M+rV8UD/9FKuQhWpYBncJgh0VOfI5oFk3nty0TJLmdzg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775761279; c=relaxed/simple; bh=hY0KfO1K/z022Q1PuKLkfRl6gjvByumiYd+sln7YkjI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=tCBolDBehILaBVRIzi79nNnrvmKNK8g/MLkJzeR7YYaoTcEiPeVMCIai3N5IDttZRgbCwdT6jzrEHOFyP+D/EHqDU5Ipwjmyivf5doW2bZsi9ISgqtnt1QaZnhclRahpe+kQ3SMOVZ2MtSDUIpFKGk1vGUWzoBW9VfXMIUrMJP8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dubeyko.com; spf=pass smtp.mailfrom=dubeyko.com; dkim=pass (2048-bit key) header.d=dubeyko-com.20251104.gappssmtp.com header.i=@dubeyko-com.20251104.gappssmtp.com header.b=U4+H5Moo; arc=none smtp.client-ip=209.85.128.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dubeyko.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dubeyko.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dubeyko-com.20251104.gappssmtp.com header.i=@dubeyko-com.20251104.gappssmtp.com header.b="U4+H5Moo" Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-7982c3b7dfcso12905427b3.0 for ; Thu, 09 Apr 2026 12:01:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dubeyko-com.20251104.gappssmtp.com; s=20251104; t=1775761262; x=1776366062; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=YK13ZqqjQ3wLQBdIjTUYThCV1qQdnIxPjzSA+72DBJY=; b=U4+H5Moo0wSNSVkmoo6xJ0g4fwkOXJ4+3ih7FwfzZO6gV935U5q1dyLCd4QMAmahGc k/jRp4NK0LF+GJ1O0D8+RfCr3PSmNw1noBDByluUmmnwumEFjz38Cl7/UFJcWYfAiZZC rXIXcvEZIqKbEgeFsd7yqns5ZvNSRr3fsZHLuyiCqWHaAI6FQOP/fNRXesfJ0axjF25t Hvga5ioeQh4enyuXtzq60GtelfrH/hyj9TM3REZvhyOV84AOVVzClF4bQfpa20Bvnxr6 1jcYdzmJXj8k9XpO2/SWVQZ7H2dNUXqaudzF/VbXnFjWiyXPYLc+e0Th0FUIhYkfXtzz KnXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775761262; x=1776366062; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YK13ZqqjQ3wLQBdIjTUYThCV1qQdnIxPjzSA+72DBJY=; b=d0M/xa4Xfi6JfozEJO12quTAxM8XnWZ1uMJ0X+sidMrU+lduXseW4pyTChcRHq5wD3 FP6Bakgi1eHL447YEqw0LbLtHsUGburoDvNoqp/Ykq8TjMmYysAUe5ZENOAI2TElDIfO EpmbQqgE4sTiNNm1JVgxSwWKMKb1QwWn5cYGEWFQmvs2WSlsWm0Jfrnz0OfvR8pHU8rH wcIA1CuNOLGDk2iMq5Ud9POb+rhuj0ejKD4oUuF+3gco4v7M4IDx/CF+YicVcTIDps1b X5NJX5LPDgHRc3o+p6ja59cg+HxU/Hg0zrToYt2M9hr9zDMjmjQG9mDaUN4Pzo6ooZO9 MIcw== X-Forwarded-Encrypted: i=1; AJvYcCU06tFB+X2Lpb8RY0vldzc80mFNdxKM2AQWld0/dhlJkZ6v1mrwe+vekPUgVqLjo8ErNF3uyNWiXWxf+MVO@vger.kernel.org X-Gm-Message-State: AOJu0Ywj4TsbVsbLsK01t2cPXD03VYUp8G4FZyKXKoUO7D3KjKTQbq52 SQoxRk7GvPP9y8eEl9SvPNDPKPLV9+uw6hKrBJWi+VX4nbRXcMpbmQC6odUn8AUKWpjjowYX9iW vVaw5h3s= X-Gm-Gg: AeBDievvC5kux1X4pDYBCsaLVkosfZF/7OnP2bHZhbs8DiVJc6L3mn0/a8hOMZ3MLAp fq4suCrpWuA/uSsalJeC5lKiyRB+4FQMrG9LsB30xEkbIyleKWR5OUBN8lPImEeaLgFLVUMed5o d9tYEOiyDDqOd5RtBR0f+U2VU5RoyCpP2oulqVR74ZA45SC0i8wtSWqN1dDOvu1Qg2kC5utSPuo hN1RSFYCwIJ3akRevBKnf1beEWyiFqkimVsq9kHOq6QMPrhHTLzn59Pg4izkmMUuAyZTwQGhdOM 1Q2WDdB7RdYuZe08v8Pd7Toggy9TyzgvS1GTbRtzgQabBNHGU//lXXKriv2xXSAMk3K9o7GFPjQ VQxTguQvHk4DBBi05btsGtSRT9Q2S9L21ZMb9epLwQEATkmmnD81yVd3rnMngVOdre4dDYTIhez Nkm/AGL9WxHjY72Ki5DBBwXAzAqwsJ+VBOy6s8QA3icLnpEu5RuDnUdLinw7sZjh4RqjBgYSjOj pHAepQEK7jUxDleZvMBHTAtHq/j4AM= X-Received: by 2002:a05:690c:dc5:b0:79b:cf31:9767 with SMTP id 00721157ae682-7af6ec4c6efmr1873047b3.3.1775761261647; Thu, 09 Apr 2026 12:01:01 -0700 (PDT) Received: from system76-pc.attlocal.net ([2600:1700:6476:1430:594a:e569:c7df:c654]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7af3d6a9c87sm2899607b3.22.2026.04.09.12.01.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 12:01:00 -0700 (PDT) From: Viacheslav Dubeyko To: ceph-devel@vger.kernel.org Cc: idryomov@gmail.com, linux-fsdevel@vger.kernel.org, pdonnell@redhat.com, amarkuze@redhat.com, Slava.Dubeyko@ibm.com, slava@dubeyko.com Subject: [PATCH v2] ceph: add ceph_has_realms_with_quotas() check into ceph_quota_update_statfs() Date: Thu, 9 Apr 2026 12:00:47 -0700 Message-ID: <20260409190046.317760-2-slava@dubeyko.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Viacheslav Dubeyko When MDS rejects a session, remove_session_caps() -> __ceph_remove_cap() -> ceph_change_snap_realm() clears i_snap_realm for every inode that loses its last cap. The realm is restored once caps are re-granted after reconnect. It is not a real error and thsi patch changes pr_err_ratelimited_client() on doutc(). Every quota methods ceph_quota_is_max_files_exceeded(), ceph_quota_is_max_bytes_exceeded(), ceph_quota_is_max_bytes_approaching() calls ceph_has_realms_with_quotas() check. This patch adds the missing ceph_has_realms_with_quotas() call into ceph_quota_update_statfs(). v2 Small cleanup by adding braces for multiline if-else statements and changing the comments. Signed-off-by: Viacheslav Dubeyko cc: Alex Markuze cc: Ilya Dryomov cc: Patrick Donnelly cc: Ceph Development --- fs/ceph/quota.c | 33 +++++++++++++++++++++++++-------- 1 file changed, 25 insertions(+), 8 deletions(-) diff --git a/fs/ceph/quota.c b/fs/ceph/quota.c index 4dc9426643e8..67ce1ff1a421 100644 --- a/fs/ceph/quota.c +++ b/fs/ceph/quota.c @@ -230,10 +230,17 @@ static int get_quota_realm(struct ceph_mds_client *mdsc, struct inode *inode, realm = ceph_inode(inode)->i_snap_realm; if (realm) ceph_get_snap_realm(mdsc, realm); - else - pr_err_ratelimited_client(cl, - "%p %llx.%llx null i_snap_realm\n", - inode, ceph_vinop(inode)); + else { + /* + * i_snap_realm is NULL when all caps have been released, e.g. + * after an MDS session rejection. This is a transient state; + * the realm will be restored once caps are re-granted. + * Treat it as "no quota realm found". + */ + doutc(cl, "%p %llx.%llx null i_snap_realm\n", + inode, ceph_vinop(inode)); + } + while (realm) { bool has_inode; @@ -342,10 +349,17 @@ static bool check_quota_exceeded(struct inode *inode, enum quota_check_op op, realm = ceph_inode(inode)->i_snap_realm; if (realm) ceph_get_snap_realm(mdsc, realm); - else - pr_err_ratelimited_client(cl, - "%p %llx.%llx null i_snap_realm\n", - inode, ceph_vinop(inode)); + else { + /* + * i_snap_realm is NULL when all caps have been released, e.g. + * after an MDS session rejection. This is a transient state; + * the realm will be restored once caps are re-granted. + * Treat it as "quota not exceeded". + */ + doutc(cl, "%p %llx.%llx null i_snap_realm\n", + inode, ceph_vinop(inode)); + } + while (realm) { bool has_inode; @@ -496,6 +510,9 @@ bool ceph_quota_update_statfs(struct ceph_fs_client *fsc, struct kstatfs *buf) u64 total = 0, used, free; bool is_updated = false; + if (!ceph_has_realms_with_quotas(d_inode(fsc->sb->s_root))) + return false; + down_read(&mdsc->snap_rwsem); get_quota_realm(mdsc, d_inode(fsc->sb->s_root), QUOTA_GET_MAX_BYTES, &realm, true); -- 2.53.0