Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [91.216.245.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C554248880 for ; Sat, 11 Apr 2026 21:13:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.216.245.30 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775942003; cv=none; b=T4r6KY7nTZRl6x3gQFnLG42aRVP8MdPiYUfksGHfGmSOVruxkBvl2SnAVpcFHFbthQpz85GpswOILEnHv/s8wf0ehRiS6t15QRU9ABM1zZsvUT2rz2QduVK6gxNNwen9dbN3SpiReRCM+zwuSWTLIfJWl+kgtOlRZ8SNXNLbOsA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775942003; c=relaxed/simple; bh=YY9wQ/wmEerCIGpGyAyPo+RV8dgCsMqlPJ6sTDFtMBw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=knAx/Y0iUfE1Ab3t8VpAWVgzOAl8MrxVTVnkwOkAqMwW8qIjbWdAv5TLrVztw84OYgbIpbFf0LXRXvV0WFIHiILlmyYI58aGsp+Z0toE9FEEIQWNT3Mmxa8d49WCUCzgVU/BzUCPyl0t4WEOVoNVIp/hzGVCvNAld4S4JpNJ8os= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=strlen.de; spf=pass smtp.mailfrom=Chamillionaire.breakpoint.cc; arc=none smtp.client-ip=91.216.245.30 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=strlen.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=Chamillionaire.breakpoint.cc Received: by Chamillionaire.breakpoint.cc (Postfix, from userid 1003) id 6BADE60344; Sat, 11 Apr 2026 23:13:20 +0200 (CEST) From: Florian Westphal To: Cc: Florian Westphal , Dan Carpenter Subject: [PATCH nf-next v2] netfilter: nft_set_rbtree: remove dead conditional Date: Sat, 11 Apr 2026 23:13:08 +0200 Message-ID: <20260411211313.1597912-1-fw@strlen.de> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit net/netfilter/nft_set_rbtree.c:399 __nft_rbtree_insert() warn: 'removed_end' is not an error pointer Since commit : 087388278e0f ("netfilter: nf_tables: nft_set_rbtree: fix spurious insertion failure") __nft_rbtree_insert() can no longer fail and this condition is always false. Remove it. Reported-by: Dan Carpenter Closes: https://lore.kernel.org/netfilter-devel/adjSaolTji0mPgqx@stanley.mountain/ Signed-off-by: Florian Westphal --- v2: re-target to nf-next & fix commit message. There is no bug, the condition is never true anymore. net/netfilter/nft_set_rbtree.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/netfilter/nft_set_rbtree.c b/net/netfilter/nft_set_rbtree.c index 737c339decd0..3407109d6a5c 100644 --- a/net/netfilter/nft_set_rbtree.c +++ b/net/netfilter/nft_set_rbtree.c @@ -396,9 +396,6 @@ static int __nft_rbtree_insert(const struct net *net, const struct nft_set *set, const struct nft_rbtree_elem *removed_end; removed_end = nft_rbtree_gc_elem(set, priv, rbe); - if (IS_ERR(removed_end)) - return PTR_ERR(removed_end); - if (removed_end == rbe_le || removed_end == rbe_ge) return -EAGAIN; -- 2.53.0