Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97D20F99C9B for ; Sat, 18 Apr 2026 22:37:50 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wEEFD-0007B3-17; Sat, 18 Apr 2026 18:34:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wEEEs-0006OQ-RS for qemu-arm@nongnu.org; Sat, 18 Apr 2026 18:34:15 -0400 Received: from p-east2-cluster1-host10-snip4-10.eps.apple.com ([57.103.76.123] helo=outbound.st.icloud.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wEEEq-0004zA-Fr for qemu-arm@nongnu.org; Sat, 18 Apr 2026 18:34:10 -0400 Received: from outbound.st.icloud.com (unknown [127.0.0.2]) by p00-icloudmta-asmtp-us-east-1a-100-percent-1 (Postfix) with ESMTPS id EDB591800229; Sat, 18 Apr 2026 22:34:04 +0000 (UTC) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr; s=sig1; t=1776551646; x=1779143646; bh=shO+Mw/9k0xyNmUmIAPxgO00PEUmcfuq7ZIwrGpWZBo=; h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme; b=P8ogNtW11uyTDugs6TN1DixQ9knSAh36dreSmanDPJrwJlcissnb4wW4ynTBReY8MYgxCvqdLsY43qlhLz2DF/5dCCe/xYmZGgx7ibycCrPHOj4EHg18m53euXWYBGxG/g/p1j/O0Q1YhbQlZ5ekllXyf1wr7HNGtv0JnoCYMTcZ30oI8K4Wi9LB3LBivtSoV1OVnVZ+/C2VKvTdW9KqVDv8o8LuGdrHJ7p1DZOZPa7oYm5/MhOIYPKs6Eo1hrnhFyGziFZDXQ2Gx2+0SWATY/She+ySAXHYfKil23+dd+pDq/qBv+Ht8IJFRSpxMBtykrXhRefCzNL0ufRgCAMMbA== mail-alias-created-date: 1752046281608 Received: from localhost.localdomain (unknown [17.42.251.67]) by p00-icloudmta-asmtp-us-east-1a-100-percent-1 (Postfix) with ESMTPSA id D68E618000DA; Sat, 18 Apr 2026 22:33:59 +0000 (UTC) From: Mohamed Mediouni To: qemu-devel@nongnu.org Cc: Mohamed Mediouni , "Michael S. Tsirkin" , Paolo Bonzini , Zhao Liu , Pedro Barbuda , Roman Bolshakov , qemu-arm@nongnu.org, Pierrick Bouvier , Peter Maydell , Wei Liu , Phil Dennis-Jordan Subject: [PATCH 20/38] whpx: i386: ignore vpassist when kernel-irqchip=off Date: Sun, 19 Apr 2026 00:33:02 +0200 Message-ID: <20260418223320.51330-21-mohamed@unpredictable.fr> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260418223320.51330-1-mohamed@unpredictable.fr> References: <20260418223320.51330-1-mohamed@unpredictable.fr> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: tb9FNmFn8VJuI6NQhH6jxdi83KenN05U X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE4MDIyOCBTYWx0ZWRfX7bJaz0kMqF6b FqBOHAcGdHYBCrBcfWlfKYrqxighp0hbkgwhIzgR3GvG0U+w2E3FE3cEkWHrV8ofaqUkC9KqZXL NGlQNT91rSCiUiPPUf+2ypulP+l7OafLQ6HhrvaQWjPFQ5z7K0fnSeR295bRjOds3M5n1Bb/7qA LeRQas7snBaVuzjPa5KoZG2ZqBRSScO/O0vl/sDV+xSD1FCJoNqbiEzcYLzKBmUludiKaYuVgSq PCwtT881cr5oJgukgfwnvYptV3kb0Gwrln3ckju7+Eet+PPvhz3xZgm3aOBJldQ5Bn8yOUfQnmD XAwHO2p6wleCA4S6XagyeGNYehLv6zw4L7yhm0IVx2BXcec3cPHHso2+UU1Ihc= X-Authority-Info-Out: v=2.4 cv=D8ZK6/Rj c=1 sm=1 tr=0 ts=69e406de cx=c_apl:c_pps:t_out a=YrL12D//S6tul8v/L+6tKg==:117 a=YrL12D//S6tul8v/L+6tKg==:17 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=HmN67jXOOwgiugJlUbgA:9 X-Proofpoint-ORIG-GUID: tb9FNmFn8VJuI6NQhH6jxdi83KenN05U X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-18_06,2026-04-17_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 clxscore=1030 adultscore=0 mlxlogscore=999 spamscore=0 phishscore=0 mlxscore=0 malwarescore=0 lowpriorityscore=0 classifier=spam authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2604180228 Received-SPF: pass client-ip=57.103.76.123; envelope-from=mohamed@unpredictable.fr; helo=outbound.st.icloud.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Linux tries to set vpassist even when none of the enlightenments using it are available. So ignore the page it sets. Signed-off-by: Mohamed Mediouni --- target/i386/whpx/whpx-all.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index f31eabce37..3af5f936d4 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -51,6 +51,7 @@ #define HYPERV_APIC_BUS_FREQUENCY (200000000ULL) /* for kernel-irqchip=off */ #define HV_X64_MSR_APIC_FREQUENCY 0x40000023 +#define HV_X64_MSR_VP_ASSIST_PAGE 0x40000073 static bool is_modern_os = true; @@ -2033,6 +2034,18 @@ int whpx_vcpu_run(CPUState *cpu) } } } + + /* + * Linux tries to use it anyway even when not exposed. + * Ignore the write as the VP assist page is not used. + */ + if (vcpu->exit_ctx.MsrAccess.MsrNumber == HV_X64_MSR_VP_ASSIST_PAGE + && vcpu->exit_ctx.MsrAccess.AccessInfo.IsWrite + && !whpx_irqchip_in_kernel() + && whpx->hyperv_enlightenments_enabled) { + is_known_msr = 1; + } + /* * For all unsupported MSR access we: * ignore writes -- 2.50.1 (Apple Git-155)