Date: Sun, 19 Apr 2026 16:08:50 +0200 (CEST) Message-Id: <202604191408.63JE8oiQ055898@...2054...> From: Gert Doering In-Reply-To: <20260414055900.17132-1-gert@...1296...> References: <20260414055900.17132-1-gert@...1296...> Subject: [Openvpn-devel] [PATCH applied] Re: Inlined credentials: read missing password from management interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Selva Nair Cc: openvpn-devel@lists.sourceforge.net The original commit looked so simple and straightforward, but these user-password-things never are... so thanks for fixing that omission. I have not tested it, but if Arne ACKs it - and the code looks more logical now, just using "password_from_stdin" as an indicator, not multiple nested variants. I'm not sure if this could be considered a "bug", but it's definitely irritating behaviour for GUI users ("no credentials in file" leads to "both are queried from mgmt" while "username inlined" leads to "password queried from console only") so for a low minor version number, this definitely qualified as "we want to fix this in the current release". Your patch has been applied to the master and release/2.7 branch. commit 287acce1acaad25a92f2112e967b9686418ef72a (master) commit b450414d10309575c28ce00f175e8374e0e99480 (release/2.7) Author: Selva Nair Date: Tue Apr 14 07:58:54 2026 +0200 Inlined credentials: read missing password from management interface Signed-off-by: Selva Nair Acked-by: Arne Schwabe Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1599 Message-Id: <20260414055900.17132-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36608.html Signed-off-by: Gert Doering -- kind regards, Gert Doering