Received: from mail.netfilter.org (mail.netfilter.org [217.70.190.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89D2A3BF677 for ; Wed, 22 Apr 2026 09:44:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.190.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776851094; cv=none; b=CkfldUZToLJQmgWNubFhnmW+VJwQvmcFyZua0O18z5vJGdg3zWPyMiYATOgWwTSO/VlFBRnv8/V8uyaAVVOVpq49c5ZWVwldYwewNtMJVjNf+pSXcOJzU1+qq/z6M4180MJq7d5QgLItrB50VhLccJb1K1LC2ujJCgfjB2vInYA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776851094; c=relaxed/simple; bh=cDuHU2vDd7HJQ/4drs7R7DnQRcwpAsSDE/FdsCyqVIw=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SkU9gmVqtFVMjPkLvnfXd7R9BdlC+ufCzjUP3YSsDYNWKtkLKKez3ReTyvZF9tTfg3jXpxOtQCVIERDLsoCgotlrJ8td62GHilfPfv8zlLwd2vE+HP9XerJ0IvWvrDpKjHiOBP4Npa71GJBEE/hEm0VfNrxGrMPGJZpUWN0oApI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org; spf=pass smtp.mailfrom=netfilter.org; dkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org header.b=shiVZX6y; arc=none smtp.client-ip=217.70.190.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=netfilter.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org header.b="shiVZX6y" Received: from localhost.localdomain (mail-agni [217.70.190.124]) by mail.netfilter.org (Postfix) with ESMTPSA id E88656017A for ; Wed, 22 Apr 2026 11:44:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netfilter.org; s=2025; t=1776851091; bh=B9uGnF/debDGHWsdBrNly2IQkTnji1ov9aT57vH2s2Y=; h=From:To:Subject:Date:In-Reply-To:References:From; b=shiVZX6yn0jRYRnmsbtlURccc4hdM8CXdRxW7dtpPIO6bea52XAeyJs+d6Mrg7rgR j5r3ek+x1wwxsYQOWqRza2ux73Mn91LU8miQmO+HAkEAN1KVISHs7c6xJttKI+qkiH 7bGzEwP1y9FKOe599jYw59lsFApNwcl1Rq1vckiM307E3wHdZG8ywEBBll3sKjwiVq 7HDXvWPX/CPLEisGkapml/oq/gAYVayg4Bur46MI+AOnHwyhK/iqkzlNQGUtWCMZ+h xVgdyL94Q1G50ZvNkhljsTvmLEAOV3dPUj5PW32x/lo3MaMWp53crRsr6lZp4Kk0Uy PEuJPLDVgJ/Tw== From: Pablo Neira Ayuso To: netfilter-devel@vger.kernel.org Subject: [PATCH nf,v2 2/3] netfilter: nft_fwd_netdev: drop packet if no device found when forwarding via neigh Date: Wed, 22 Apr 2026 11:44:43 +0200 Message-ID: <20260422094444.198178-2-pablo@netfilter.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260422094444.198178-1-pablo@netfilter.org> References: <20260422094444.198178-1-pablo@netfilter.org> Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The ttl field has been decremented already and evaluate of this rule would proceed, just drop this packet instead if there is no destination device to forwards this packet. This is exactly what nf_dup already does in this case. Fixes: d32de98ea70f ("netfilter: nft_fwd_netdev: allow to forward packets via neighbour layer") Signed-off-by: Pablo Neira Ayuso --- v2: no changes net/netfilter/nft_fwd_netdev.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/netfilter/nft_fwd_netdev.c b/net/netfilter/nft_fwd_netdev.c index 516287ce7f9b..95b2af3eede4 100644 --- a/net/netfilter/nft_fwd_netdev.c +++ b/net/netfilter/nft_fwd_netdev.c @@ -153,8 +153,10 @@ static void nft_fwd_neigh_eval(const struct nft_expr *expr, } dev = dev_get_by_index_rcu(nft_net(pkt), oif); - if (dev == NULL) - return; + if (dev == NULL) { + verdict = NF_DROP; + goto out; + } skb->dev = dev; skb_clear_tstamp(skb); -- 2.47.3