Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9EA24FDEE3F for ; Thu, 23 Apr 2026 20:00:25 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wG0D0-0001QS-UX; Thu, 23 Apr 2026 15:59:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wG0Cy-0001Oe-EB; Thu, 23 Apr 2026 15:59:32 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wG0Cw-0003KE-DE; Thu, 23 Apr 2026 15:59:32 -0400 Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63NJJmmo3291901; Thu, 23 Apr 2026 19:59:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=GOJ5PtGfRw9JuVE9Z GBFN43Vs8zqFtSfYXt6iC8HpHU=; b=B1KzdpI+60zY7Tq7Uext4nV33584ZGGoQ MPGnxwEu4CdQ9h+sDC2ObwKLGyp6pkg21QxjgV/Q5jHrFZ0Mm9f6J4diTaHVGL03 UwmHMzJ83KmlknzDtp71MSzhvsZgtaw2vyAzIzwMveCwByLF8hLmr37meMCRa5as mtjU0uDpEiDvLgMFKwIRPl8SRKsfpItqDzhmOQ/hXA1FS5DpC2GxZMakOpp+7JWm Upsb078LDgGsbXqmJz5fvChmQ+gdIW07rMhsJEmaXFioGr3Oo7X/KBhTpBDwV7OA Mdc/EFG7ko13mEoYPzTssQlJhlQv0fjh2PImdEuF4nq80/YHVAYDg== Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dphfrhytd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Apr 2026 19:59:26 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 63NJoU5s015642; Thu, 23 Apr 2026 19:59:25 GMT Received: from smtprelay06.wdc07v.mail.ibm.com ([172.16.1.73]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 4dpjky044e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Apr 2026 19:59:25 +0000 (GMT) Received: from smtpav04.dal12v.mail.ibm.com (smtpav04.dal12v.mail.ibm.com [10.241.53.103]) by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 63NJxNaP18481708 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 23 Apr 2026 19:59:24 GMT Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D4FBE5805E; Thu, 23 Apr 2026 19:59:23 +0000 (GMT) Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9946458052; Thu, 23 Apr 2026 19:59:23 +0000 (GMT) Received: from IBM-GLTZVH3.ibm.com (unknown [9.61.254.253]) by smtpav04.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 23 Apr 2026 19:59:23 +0000 (GMT) From: Jaehoon Kim To: qemu-devel@nongnu.org, qemu-block@nongnu.org Cc: pbonzini@redhat.com, stefanha@redhat.com, fam@euphon.net, armbru@redhat.com, eblake@redhat.com, berrange@redhat.com, eduardo@habkost.net, dave@treblig.org, sw@weilnetz.de, mjrosato@linux.ibm.com, farman@linux.ibm.com, Jaehoon Kim Subject: [PATCH v5 1/3] aio-poll: avoid unnecessary polling time computation Date: Thu, 23 Apr 2026 14:59:16 -0500 Message-ID: <20260423195918.661299-2-jhkim@linux.ibm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260423195918.661299-1-jhkim@linux.ibm.com> References: <20260423195918.661299-1-jhkim@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 08UOR9h6keNbwrCNn9yxwKWAHAO87SGT X-Proofpoint-ORIG-GUID: 08UOR9h6keNbwrCNn9yxwKWAHAO87SGT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIzMDE5MyBTYWx0ZWRfXyAE8cS0mLOBE 7tXta98eT2/jZDWFjBerCObpHqbeu6iZ99h3uvYpzorgCoaOyFbzCDEJmTGYdhdPh07SL4pYV39 FwW3RvJHdC+ArkC/G9KZURjEMN/mIlu6SPKPYsNplcryuxoSKmA8InsMeNN5TynBhRajxHNBuNI eWH5yZbi5WQRtRpLC+JoO+Qw+1T30ys5js7aCVO6R+GLqZJDPUOLhJeB84iLFgMGwFzM19M2XK2 BM/aInbw69hTIMLSDGepkthQhiPk8DBhLHLdgJKEasCKZ6lq9GKMP6/G1CnnT2r+j+mECLfAH02 mNRmmHV+e0JVDMVbp0MgGc7k4u9eV2WOI9cD+11AIfOnrV5gw6+m8Vo1lxwWwsH3TRKKjsrQo/e Jdp38Q/tdBpCR02aZTcT0AklYmkTprRMtewLzDt1BM3r0rD+tjcgjp76/UaIxafaWIoJPImJgJh 4Oyw0iVQpdkJhGGO7hQ== X-Authority-Analysis: v=2.4 cv=SJxykuvH c=1 sm=1 tr=0 ts=69ea7a1e cx=c_pps a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=uAbxVGIbfxUO_5tXvNgY:22 a=VnNF1IyMAAAA:8 a=20KFwNOVAAAA:8 a=6MqEkq6nHlEWUoCmaegA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 malwarescore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 adultscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230193 Received-SPF: pass client-ip=148.163.156.1; envelope-from=jhkim@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Nodes are no longer added to poll_aio_handlers when adaptive polling is disabled, preventing unnecessary try_poll_mode() calls. This avoids iterating over all nodes to compute max_ns unnecessarily when polling is disabled. Signed-off-by: Jaehoon Kim Reviewed-by: Stefan Hajnoczi --- util/aio-posix.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/util/aio-posix.c b/util/aio-posix.c index 488d964611..351847c6fb 100644 --- a/util/aio-posix.c +++ b/util/aio-posix.c @@ -307,9 +307,8 @@ static bool aio_dispatch_handler(AioContext *ctx, AioHandler *node) * fdmon_supports_polling(), but only until the fd fires for the first * time. */ - if (!QLIST_IS_INSERTED(node, node_deleted) && - !QLIST_IS_INSERTED(node, node_poll) && - node->io_poll) { + if (ctx->poll_max_ns && !QLIST_IS_INSERTED(node, node_deleted) && + !QLIST_IS_INSERTED(node, node_poll) && node->io_poll) { trace_poll_add(ctx, node, node->pfd.fd, revents); if (ctx->poll_started && node->io_poll_begin) { node->io_poll_begin(node->opaque); @@ -631,7 +630,7 @@ static void adjust_polling_time(AioContext *ctx, AioPolledEvent *poll, bool aio_poll(AioContext *ctx, bool blocking) { AioHandlerList ready_list = QLIST_HEAD_INITIALIZER(ready_list); - bool progress; + bool progress = false; bool use_notify_me; int64_t timeout; int64_t start = 0; @@ -656,7 +655,9 @@ bool aio_poll(AioContext *ctx, bool blocking) } timeout = blocking ? aio_compute_timeout(ctx) : 0; - progress = try_poll_mode(ctx, &ready_list, &timeout); + if (ctx->poll_max_ns != 0) { + progress = try_poll_mode(ctx, &ready_list, &timeout); + } assert(!(timeout && progress)); /* -- 2.50.1