Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15952376494 for ; Thu, 23 Apr 2026 22:43:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776984203; cv=none; b=T1CwlddlpXEpL9Hx6UKtvv2tK9VHdYP8usMNNnpNGnWlyhE4w/aMJY8maMoTrdb10PZOB/oNV2MWneIM6aBb7/r+chLe3MNhcii2BpwrNnMEHCHldOH+ia1UfOwSxzEdstlUxmVpjj0wR8qleXyAthh3FMtiJiS2/Bo2uaQfdsA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776984203; c=relaxed/simple; bh=CBu0C4Gbw+eSGJTiQmDn0Va7Mzdh0sn3nL6uhqMgdYo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RA72qPfpaRG3a9WqJIWT0fMWsuZR2GU9LjPHYJyZgCgYbHZkM7ZEScU8fqUOwvJVrwGED2/gQOeaHnMW/I2LMd0gKk0VzM5DfDpWpY6+CcxMauaq687fu1XpdR0DEqUc2k8OnDBarSXze6lCSiXxrQtnsVMYyBvjVsZJ4Iq7tDM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=l10uGW8s; arc=none smtp.client-ip=209.85.222.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="l10uGW8s" Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-8cb5c9ba82bso1107507685a.2 for ; Thu, 23 Apr 2026 15:43:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1776984200; x=1777589000; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/T0GTDRuU/Ml1Jl3QzhDeR+2ndhb6qBdCM6HZ+ROdk0=; b=l10uGW8sVZ8GA/RVM9bHlmnoNVIRO4fesH7ENC7WZqX28+xQ6lA9OTdNSun1R92Np0 kz/05V1SXajZZZ2aoiHurnL6F/2r279b5Xobm5UU+UiV/N5cCHihVD8MEfmVtMy3EIv8 Sn/eOTVo4/FZP3e6A7/jJ0xLZiHp0szU47ex2SRqK8a4TEJrGwsnud+crNTbLf6F3gAE bEEDXoNlVHVfFB1pqh1D6PWGIZ/yHTlpL02jpEuxu3YU3DomtF5hArDtS+fvycYcqzDH 2spQ4F4p9BYHvQDTrEC4oBOEr4s2bowiwYIaksYQ3nfiV5nl2vpUprNowrM6fqlebtFl vovg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776984200; x=1777589000; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/T0GTDRuU/Ml1Jl3QzhDeR+2ndhb6qBdCM6HZ+ROdk0=; b=Q/ZLkzmQeY721/CmDgSV2tpM4aPP7FNWrThgKTcckKI0ky+sjpkJiumfF/AjfhCztp Fn34/eI6kaWbqQ3Xy5862B2QdqHkhuK4iN20DEcBssdDerMLjvEw5E7NRKLKDyasL2Cr PVwEz9Cveufni9FMN2RpgR1ToGhdTE1hsFqUk3w1t7KeAG59IFILcVcD27Z7s3oUj8oW I3m1HjQneOh+A0TCNDPX6QdizeQUMCkdm/WrefjWf5smZSxB+0tiK1QcQWvX1UTEj4Qs DJQtZYZUIyosObfKKu82koH+v4lQfFRZHFKDHqA/lx3gFnFEu/voYXMxIdipvA54khRv eYQA== X-Forwarded-Encrypted: i=1; AFNElJ+5+epap6t9sS5oX0awHE+rBW648e1s92WxP2eRE0zZlX+T4v3hc39WXr0ZcuhVu8AAcIY7nu8O24gPctU=@lists.linux.dev X-Gm-Message-State: AOJu0Yzrbsy4Pv2BUTe8JVWIRzpdsCC/XlGZWBZsB9LMHWE3NevUfBlK MgRBQLRWT6sHO1oQTpQmHx/K6xI6KpnDIxOaa/N3f4qCRD6t3JfvxZ1X5ITyZFDT9NM= X-Gm-Gg: AeBDiet2vEq/gQbIYYw1EXxsU9bLXmakq4SXjrujuDYt4vvpdK38tSIwDIq0Dnmug79 c3zj/1SuuzxenC6HuxWXvfAFlybpKMtXEabcQAVXzJ8r1Yf/P3qwWVKdtILCf0fULSO8cKguhXQ 5XoeTfhxJvmS6ow+n4xl60xT483cNt4gN1dBDbzRyI6kcEUao8VOjDmS1oOMr7KYHqkxHnzb7yS hdsCQjmJS3m4GL7vJgS2V8dmmmq7KvHenxOi9e3PDRVXSjiR+3OUgdSeIDkI6u0Nb3rAQqI67OX b64mJmcoddZd62H19I0JIJemOXNsmHNP6iAFxmcuwzN8+4Bw8QLaJU33JO5unCbt477S7HGDdJQ bFxCCLxqDdN7JRKL02Btq1xyPg6DNld2thE3izwTzq0voqusNb/TZRWn5ZVCNDmiKaMEWNM5FUD DVevt7ZlHnEvuqI52H4RRW3aNTty87M8m29UDo/TJmbOT/dNv6g0v/Lw0nPrzN7uxTq1A6ToNzC 4hgTXyvm1QNqTsGkrD55TBU2FI= X-Received: by 2002:a05:620a:3187:b0:8f0:7516:da99 with SMTP id af79cd13be357-8f07516e40bmr1047695085a.60.1776984199901; Thu, 23 Apr 2026 15:43:19 -0700 (PDT) Received: from ziepe.ca (crbknf0213w-47-54-130-67.pppoe-dynamic.high-speed.nl.bellaliant.net. [47.54.130.67]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8b02aec3a3bsm169316686d6.49.2026.04.23.15.43.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 15:43:19 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wG2lS-0000000GLHD-1ruw; Thu, 23 Apr 2026 19:43:18 -0300 Date: Thu, 23 Apr 2026 19:43:18 -0300 From: Jason Gunthorpe To: Vidya Sagar Cc: rafael@kernel.org, lenb@kernel.org, saket.dumbre@intel.com, lpieralisi@kernel.org, guohanjun@huawei.com, sudeep.holla@kernel.org, will@kernel.org, catalin.marinas@arm.com, joro@8bytes.org, robin.murphy@arm.com, nicolinc@nvidia.com, praan@google.com, vsethi@nvidia.com, sdonthineni@nvidia.com, kthota@nvidia.com, sagar.tv@gmail.com, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, acpica-devel@lists.linux.dev, iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH V1 1/3] ACPICA: IORT: Add Root Complex PASID Flags field Message-ID: <20260423224318.GT3611611@ziepe.ca> References: <20260423191417.2031652-1-vidyas@nvidia.com> <20260423191417.2031652-2-vidyas@nvidia.com> Precedence: bulk X-Mailing-List: acpica-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260423191417.2031652-2-vidyas@nvidia.com> On Fri, Apr 24, 2026 at 12:44:15AM +0530, Vidya Sagar wrote: > The IORT spec, Issue E.c (ARM DEN 0049E.c, January 2022), bumps the > Root Complex Node to revision 4 and adds two PASID descriptors: > > - PASID Capabilities at byte offset 33 (2 bytes), bits[4:0] of which > report the Max PASID Width supported by the Root Complex. > - Flags at byte offset 36 (4 bytes), bit 0 of which reports whether > the Root Complex itself supports PASID. This is distinct from the > existing ATS Attribute bit 2 (at offset 24) that only reports > whether the RC forwards PASID information on translated > transactions. > > The ACPICA struct in include/acpi/actbl2.h was updated for the E.c > PASID Capabilities descriptor (offset 33) but stops short with a > trailing 'u8 reserved[]' flexible array, so the new Flags field at > offset 36 is unreachable and the existing ACPI_IORT_PASID_* > definitions have no consumer. > > Replace the trailing flexible array with a fixed 'u8 reserved[1]' > followed by 'u32 flags' so the struct fully covers RC node revision 4, > and add the ACPI_IORT_RC_PASID_SUPPORTED mask for bit 0 of the new > field. With #pragma pack(1) in effect for actbl2.h, this lands the new > field at the spec-mandated absolute offset 36. > > Signed-off-by: Vidya Sagar > --- > include/acpi/actbl2.h | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) There is a whole process to change this file, I went through it once for canwbs.. https://lore.kernel.org/acpica-devel/2-v3-e2e16cd7467f+2a6a1-smmuv3_nesting_jgg@nvidia.com/ You have to make a pull request here: https://github.com/acpica/acpica/pulls And then use the generate/linux/make-patches.sh -u Script to make this patch for linux in the perscribed format. I think, something like that Jason