Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50727FED3C3 for ; Fri, 24 Apr 2026 13:28:47 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wGGaF-0005ng-1r; Fri, 24 Apr 2026 09:28:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wGGaD-0005jj-VT for qemu-devel@nongnu.org; Fri, 24 Apr 2026 09:28:37 -0400 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wGGaC-0001hX-CR for qemu-devel@nongnu.org; Fri, 24 Apr 2026 09:28:37 -0400 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id B7158600AE; Fri, 24 Apr 2026 13:28:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4B21C2BCB2; Fri, 24 Apr 2026 13:28:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777037314; bh=pRFq87+S/2GHoFTTwGzGYtiaLb0u0S7BL4zKXOaqYx4=; h=From:To:Cc:Subject:Date:From; b=sTyR4ZSfjl3Tt109E1Z3CTQ6+iHGGtde1MV5mmZfBo4DvxY44TDSgxDPa8M0IykW3 bPK0CgQPaGTCgngMEJUMVAhlMqWFmvAaVq/L6mMRCoOnWWI51ebgqunLtOAJcAD7sY LEGTP5nD/gjvxs3J/aRvlg09m7I0Jsc7UZlu0Ocw98zICNUozHAU2oN5p1lLPnGkj3 zFjCMPnWvQRM7sKr/BTK/bbkjJ3QEy2tYGpwDBrnH3eSZqFJQjNoJ3+3rFzxLeQfip hwjpX6T6zu5Vk05c28p/z1YBi5z/d9JhLhtbxoqGMHrHOIP1uPJVp+atNsvf9PS04a xhn7vKVYLMuFw== From: Helge Deller To: qemu-devel@nongnu.org Cc: Helge Deller Subject: [PATCH] linux-user: Fix CLONE_PARENT_SETTID when using fork-like clone Date: Fri, 24 Apr 2026 15:28:24 +0200 Message-ID: <20260424132824.27733-1-deller@kernel.org> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2600:3c04:e001:324:0:1991:8:25; envelope-from=deller@kernel.org; helo=tor.source.kernel.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org From: Helge Deller The CLONE_PARENT_SETTID option requires the implementation to store the child thread ID at the location pointed to by parent_tid in the parent's memory. Fix our implementation and move the code from the client side (where fork returned 0), to the parent side and store the return value from the fork call (which is the client TID) in the parent_tid pointer. Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3340 Signed-off-by: Helge Deller --- linux-user/syscall.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index d0390e04b4..910a4da0a6 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -7050,8 +7050,6 @@ static int do_fork(CPUArchState *env, unsigned int flags, abi_ulong newsp, the child process gets its own copy of the lock. */ if (flags & CLONE_CHILD_SETTID) put_user_u32(sys_gettid(), child_tidptr); - if (flags & CLONE_PARENT_SETTID) - put_user_u32(sys_gettid(), parent_tidptr); ts = get_task_state(cpu); if (flags & CLONE_SETTLS) cpu_set_tls (env, newtls); @@ -7059,6 +7057,8 @@ static int do_fork(CPUArchState *env, unsigned int flags, abi_ulong newsp, ts->child_tidptr = child_tidptr; } else { cpu_clone_regs_parent(env, flags); + if (flags & CLONE_PARENT_SETTID) + put_user_u32(ret, parent_tidptr); if (flags & CLONE_PIDFD) { int pid_fd = 0; #if defined(__NR_pidfd_open) && defined(TARGET_NR_pidfd_open) -- 2.53.0