Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D009E3DB622 for ; Fri, 24 Apr 2026 14:05:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777039538; cv=none; b=Jg8CM2UX9TLu093qHukkKj/P3ct6KRtJ7NOzAkCHzqPfvAn6bokmAJoZPky3E9syNuydpZ0ZQ3Bl9iI6cGEHssEFo+X7pgYVMwsSnOWz+rhobw/kDqoAmnSYqak1MLpO+yiOpPDIJEumk5FALqxh2CK/c2NnOqsFc77UDlpG2NA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777039538; c=relaxed/simple; bh=wBhRpjye2WypgbrjZXWpZgiiWh+In3Z/vmDl7DbHZWo=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AdXgmuiOwLJDiRAtv09RHI1kxSIWBG/uWwyZDsFzCXB/XOQvxljLuNNhe/Hc06buvh2uVR7aq/PvLFGPA99Nfxk2IrSoDpCG7pN8ZGHi0nICBFBCLhDqCxh+EXtWbf5ryBq/I5ISevmPl4AjQjquvGCJ6iDNqChVNleW47bjMZ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=permerror header.from=versity.com; spf=pass smtp.mailfrom=versity.com; dkim=pass (2048-bit key) header.d=versity.com header.i=@versity.com header.b=Dnj/ji5m; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=permerror header.from=versity.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=versity.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=versity.com header.i=@versity.com header.b="Dnj/ji5m" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-676fec7e946so4533647a12.3 for ; Fri, 24 Apr 2026 07:05:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=versity.com; s=google; t=1777039535; x=1777644335; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=+TKxRXgJjBsABC1dSVSsyu/IX1Ne0jCJikgPBQoiPWo=; b=Dnj/ji5mYkUUopB+fawDCna8sQaC4A+b21/lpoaRZljidp1PbpxTTt20kq2w4ChNl9 KxP7+pm4gF5jncrgrxoKYpc6q5dBpJRZmoTG1qdBjaiGQR2KNqivWDTjNGVi+clSsvrT VLPzaOum/4e3yUpdaf++BOOPKaysY7NPumSjFVFZNNRbMcPnPsIb6w/YZ3FqsFxmVZ/7 TQxOxdIE57/TQowqa9qRk9lpReGOk4P0oT2qZf3W0gcCalypuvzpNdXs1DZ0zjNLmiLU zcovkOlyoTCVppoJUHg0UJGpNsgAEWVGHvT5nqz3+QsZSYk27m6szfTq9SR/6K+B3F34 fokg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777039535; x=1777644335; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=+TKxRXgJjBsABC1dSVSsyu/IX1Ne0jCJikgPBQoiPWo=; b=T8dgCiAtHxJmPlJSttytGvnE4n4V0ABBHprf4EaSalA7TZYW2YJH0u0okTXfy+Tz9J XTQLLW4R2vpTFqfG+gvKwiujqe5MSx6v158UxKqmmCVYekBl85F4rAkktlOWRkPEC/p0 bWDp6hg+9jG1vYgVG5FnSjbn2TqkOnwQ66UPIgEEonv+Qcu45z5sPWhWZDsMdXtQuAaK X67ZxhxfO8cY8g7g+8Uxvr95Ee8i4KC78xwOn5zEA59KxmLaM0yEnF9590S0keBKpvvm o+Y4O/XJsb/DuqgznonWgaiIR4VD9ouHioIfDswdJbyHv040OGeQpCnJ+NLTf2ckA32l aSqw== X-Gm-Message-State: AOJu0YwUBV5+qkj8eM1ej9e/JtzC3eTiIh0wHwO8lzVHHaPRFm+VKaiT b/hqtxCBoyLDHahGpOA9t7YEPLhTdsK9d5OTsq21LsgXDhe0awIKHsJ9ykJOcvkM3NwJRtSO/HN +c9kP X-Gm-Gg: AeBDievA/zEju5sZIgFbb4lkG09dQpcnLAFfr7I7jS+Tp1REg0p9TQWYtWLQVqHHCWp qvacXKmN7THLeBuU1Ciexh0tx83UXGEm4rJyvo7ojI9QL3dyrT6cNkmOamml2bwbOi6LEQUF+RZ vIvFQwDVtKAOUNT9kmdlWRro7rwdiA82hz1VOpPVXpRXekiGiQI+jo0Xo1w9sjrNUihmtqVNiIg 6ZvaTfhvy6DQNxXa57F+ySlhOpcBuE2kgWYIeXnpR2lz8i49rn9192f/fDY2phtJ1H69AzqXhK1 KwDi8o4vbjnD81eHBHHXq3DS+TILNH1fZImgNpapc9v1Muxef16yXojqc/M4WCPFOS+MeVHGU/6 02ZpDRnOJgqAA8PScIgZUfiOZp6x/j87Wj2l3tmDsgwpj4tK7So4Zz08V5QTqRas2jcRVj42xwC U9qKj5tGxVFXtRNc5N6ahWXNCjCQNhSHDky8dlRIxU+OGzGEEy2bZv0KEjJAD83Pv5RXKhz6vgB vf1wPXWvVb/rCYNLDHNlMwoOJu7+NS+HS0uPw== X-Received: by 2002:a17:906:4fc6:b0:bab:f5c7:23ca with SMTP id a640c23a62f3a-babf5c7241amr495038466b.38.1777039535128; Fri, 24 Apr 2026 07:05:35 -0700 (PDT) Received: from localhost.localdomain (46-117-212-87.ftth.glasoperator.nl. [87.212.117.46]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ba454d1bbb1sm766348966b.38.2026.04.24.07.05.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Apr 2026 07:05:34 -0700 (PDT) From: Valerie Aurora To: rpdfs-devel@lists.linux.dev Subject: [PATCH 4/8] rpdfs: add inode change debugging routine Date: Fri, 24 Apr 2026 16:05:16 +0200 Message-ID: <20260424140520.3443624-5-val@versity.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20260424140520.3443624-1-val@versity.com> References: <20260424140520.3443624-1-val@versity.com> Precedence: bulk X-Mailing-List: rpdfs-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit print_inode_change() can be added to copy_vfs_inode_to_rinode() to log what has changed since the last inode update. --- fs/rpdfs/inode.c | 38 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/fs/rpdfs/inode.c b/fs/rpdfs/inode.c index 428c9081fd75..7abd2c58373f 100644 --- a/fs/rpdfs/inode.c +++ b/fs/rpdfs/inode.c @@ -82,6 +82,44 @@ static void copy_rinode_to_vfs_inode(struct inode *inode, struct rpdfs_inode *ri ri->xattr_creates = rinode->xattr_creates; } +__always_unused +static inline void print_diff64(char *name, u64 new, u64 old) +{ + old = le64_to_cpu(old); + + if (old != new) + rpdfs_prd("%s: %llu -> %llu (%lld)", name, old, new, new - old); +} + +__always_unused +static void print_inode_change(struct inode *inode, struct rpdfs_inode *rinode) +{ + struct rpdfs_inode_info *ri = RPDFS_I(inode); + struct timespec64 ts; + + rpdfs_prd("copying inode %lu to rinode", inode->i_ino); + + print_diff64("ino", ri->ig.ino, rinode->ig.ino); + print_diff64("gen", ri->ig.gen, rinode->ig.gen); + print_diff64("i_size", i_size_read(inode), rinode->size); + print_diff64("nlink", inode->i_nlink, rinode->nlink); + print_diff64("uid", i_uid_read(inode), rinode->uid); + print_diff64("gid", i_gid_read(inode), rinode->gid); + print_diff64("mode", inode->i_mode, rinode->mode); + + ts = inode_get_atime(inode); + print_diff64("atime", timespec64_to_ns(&ts), rinode->atime_nsec); + ts = inode_get_ctime(inode); + print_diff64("ctime", timespec64_to_ns(&ts), rinode->atime_nsec); + ts = inode_get_mtime(inode); + print_diff64("mtime", timespec64_to_ns(&ts), rinode->atime_nsec); + print_diff64("crtime", ri->crtime_nsec, rinode->crtime_nsec); + + print_diff64("dirents", ri->dirents.ref.bnr, rinode->dirents.ref.bnr); + print_diff64("xattrs", ri->xattrs.ref.bnr, rinode->xattrs.ref.bnr); + print_diff64("xattr_creates", ri->xattr_creates, rinode->xattr_creates); +} + static __le64 cpu_ts64_to_le64_ns(struct timespec64 ts) { return cpu_to_le64(timespec64_to_ns(&ts)); -- 2.49.0