Received: from smtp-out.kfki.hu (smtp-out.kfki.hu [148.6.0.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5589C377029 for ; Mon, 27 Apr 2026 07:34:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.6.0.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777275283; cv=none; b=mUWSnS+UnIeMxM4Cr/8H8O/jyVXXE6uC4e8svsEhsmGab4mdymN18CWpewLJSio0WTRIlxbt6C0xwbFuTwqs+zlpt6fyy/Or/z9QSTUsU+7aXD6qj0wJ4qGvWZwcU6MphzerWgpZUsXiYrsUk9CJW4++aYWjrpEzfXhraz0DoF8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777275283; c=relaxed/simple; bh=4wu5LlKk2/f9u8cRyU+65DvVW7p02wWn6Zhm/6S8c9w=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=p7mAFcFvk0EdtstF3Dtz17hfnS4yWWlswlD7JhRmY1/Eihpp1XdtZ3EnXIJ1OC6jIag4T+id7n4pc9cs+MTbY5JScHA22Mh7ZBkw5OfWYBChRdTdDc6B686QNIHXTKP5ajEgJJCaRk6wzdnAXD4iyrzsP90BkpuoesoD6IpN3ro= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org; spf=pass smtp.mailfrom=blackhole.kfki.hu; dkim=pass (1024-bit key) header.d=blackhole.kfki.hu header.i=@blackhole.kfki.hu header.b=D3nmZ+SX; arc=none smtp.client-ip=148.6.0.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=blackhole.kfki.hu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=blackhole.kfki.hu header.i=@blackhole.kfki.hu header.b="D3nmZ+SX" Received: from localhost (localhost [127.0.0.1]) by smtp0.kfki.hu (Postfix) with ESMTP id 4g3wLV6ns6z3sbBc; Mon, 27 Apr 2026 09:34:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= blackhole.kfki.hu; h=mime-version:references:in-reply-to :x-mailer:message-id:date:date:from:from:received:received :received; s=20151130; t=1777275265; x=1779089666; bh=PUxz9zUZ66 /vcQ+IhgStDNSiyI/OowhsPncAIBiVeag=; b=D3nmZ+SXqk1moGoS/y8PUPR/ko pF1scqilbEbqNy4R8fv6VfoDrKzXyCj6fr0fTgBHidTruFv0PPRwoOHV6hp6XW6V Aeyyat/IIfM9mTtPFGAkVOv6YrUVy3pIQbh7ZH6cCACOw8i36LRUMVSs5i0Pfoju nO/RcH9gVQVXYdsNU= X-Virus-Scanned: Debian amavis at smtp0.kfki.hu Received: from smtp0.kfki.hu ([127.0.0.1]) by localhost (smtp0.kfki.hu [127.0.0.1]) (amavis, port 10026) with ESMTP id fVIyqxmZBrlm; Mon, 27 Apr 2026 09:34:25 +0200 (CEST) Received: from mentat.rmki.kfki.hu (254C0B05.nat.pool.telekom.hu [37.76.11.5]) (Authenticated sender: kadlecsik.jozsef@wigner.hu) by smtp0.kfki.hu (Postfix) with ESMTPSA id 4g3wLT043wz3sb8d; Mon, 27 Apr 2026 09:34:24 +0200 (CEST) Received: by mentat.rmki.kfki.hu (Postfix, from userid 1000) id 8304B140B4D; Mon, 27 Apr 2026 09:34:24 +0200 (CEST) From: Jozsef Kadlecsik To: netfilter-devel@vger.kernel.org Cc: Pablo Neira Ayuso Subject: [PATCH 1/5] netfilter: ipset: Fix data race between add and list header in all hash types Date: Mon, 27 Apr 2026 09:34:20 +0200 Message-Id: <20260427073424.573672-2-kadlec@netfilter.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260427073424.573672-1-kadlec@netfilter.org> References: <20260427073424.573672-1-kadlec@netfilter.org> Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-deepspam: maybeham 2% Content-Transfer-Encoding: quoted-printable The "ipset list -terse" command is actually a dump operation which may run parallel with "ipset add" commands, which can trigger an internal resizing of the hash type of sets just being dumped. However, dumping just the header part of the set was not protected against underlying resizing. Fix it by protecting the header dumping part as well. Signed-off-by: Jozsef Kadlecsik --- net/netfilter/ipset/ip_set_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_s= et_core.c index a2fe711cb5e3..2cc04da95afd 100644 --- a/net/netfilter/ipset/ip_set_core.c +++ b/net/netfilter/ipset/ip_set_core.c @@ -1648,13 +1648,13 @@ ip_set_dump_do(struct sk_buff *skb, struct netlin= k_callback *cb) if (cb->args[IPSET_CB_PROTO] > IPSET_PROTOCOL_MIN && nla_put_net16(skb, IPSET_ATTR_INDEX, htons(index))) goto nla_put_failure; + if (set->variant->uref) + set->variant->uref(set, cb, true); ret =3D set->variant->head(set, skb); if (ret < 0) goto release_refcount; if (dump_flags & IPSET_FLAG_LIST_HEADER) goto next_set; - if (set->variant->uref) - set->variant->uref(set, cb, true); fallthrough; default: ret =3D set->variant->list(set, skb, cb); --=20 2.39.5