Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1BD99FF8860 for ; Mon, 27 Apr 2026 17:05:57 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHPP2-0007Y0-9E; Mon, 27 Apr 2026 13:05:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHPP0-0007U0-1e for qemu-devel@nongnu.org; Mon, 27 Apr 2026 13:05:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHPOy-0006NE-KU for qemu-devel@nongnu.org; Mon, 27 Apr 2026 13:05:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777309543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=zGre//01tH2c35nomgMy5ZkAJ2hN3fs8V+xTYufnCEk=; b=NUKfexdqVSnxQEqtBawLcpNUAIBkqthjmZ++0v70OQRrCKBlx5Z1drY//MYeZzeknR1aGc NOwUX70kLmFDxqomUu9cJsi9SXmRRRIlnfePrsyxxYMOHW2nTPGV36H6v8vq2hPh/KOJ0i phzEMUddlgs85UwH2RMxpj+gJcO1MEg= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-421-K8iLuBRbM_2UTbEIT5v4CA-1; Mon, 27 Apr 2026 13:05:40 -0400 X-MC-Unique: K8iLuBRbM_2UTbEIT5v4CA-1 X-Mimecast-MFC-AGG-ID: K8iLuBRbM_2UTbEIT5v4CA_1777309539 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2C72B19560AB; Mon, 27 Apr 2026 17:05:39 +0000 (UTC) Received: from merkur.fritz.box (unknown [10.44.49.22]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D1838180047F; Mon, 27 Apr 2026 17:05:36 +0000 (UTC) From: Kevin Wolf To: qemu-block@nongnu.org Cc: kwolf@redhat.com, hreitz@redhat.com, den@openvz.org, stefanha@redhat.com, qemu-stable@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH 0/4] qcow2: Fix corruption on discard during write with COW Date: Mon, 27 Apr 2026 19:05:16 +0200 Message-ID: <20260427170520.101242-1-kwolf@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass client-ip=170.10.129.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org This is an alternative fix for the corruption problem reported by Denis: https://patchew.org/QEMU/20260421155628.3600671-1-den@openvz.org/ I think it really is a qcow2 level bug and should be fixed on the qcow2 level. The test is also more targeted than just doing random I/O for a while, and therefore runs faster and documents the problem better. Kevin Wolf (4): commit: Drain nodes across all of bdrv_commit() qemu-io: Add 'aio_discard' command qcow2: Fix corruption on discard during write with COW iotests/046: Test that discard/write_zeroes wait for dependencies block/commit.c | 10 +++- block/qcow2-cluster.c | 52 ++++++++++++++++- qemu-io-cmds.c | 113 +++++++++++++++++++++++++++++++++++++ tests/qemu-iotests/046 | 46 +++++++++++++++ tests/qemu-iotests/046.out | 36 ++++++++++++ 5 files changed, 252 insertions(+), 5 deletions(-) -- 2.53.0