Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C9463191C8 for ; Mon, 27 Apr 2026 22:22:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777328523; cv=none; b=hx2cMJC0+mv01rFpglV5oL6ogFFSlWFsLD6pn3RKYtbWW48YeWoeoArXS2K2x0MLTC+/VnW8+LylW2LdVTiYFb5sLLfEZ6AXRgMNrGPMbho9B90hVp+7QCnkFdtXKk6OxbnugjRJl/8KY7TCeobSi5kDEE5c7nDv3s9SuHu1YHY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777328523; c=relaxed/simple; bh=dM960t7ooMMiVCDvqcJedG4gtT7V4D/S9UNW9BzQUGw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YTePbpa9teu+vA/fR7Eo/bV+ZWT1vwWnUkqk1Q+w02PZ+61Y8vdYNyBThITdkul+VthY6/kFBWqDD+yIMwdn+YpE2SBUM3kfvJbZ3GsulKTNqwAaaxkxqRIHWJSBtfDHfMtxS7WYt2tU5k4thjl+Ao+dALH81qbMw/tpxQDje3s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=zabbo.net; spf=pass smtp.mailfrom=zabbo.net; dkim=pass (1024-bit key) header.d=zabbo.net header.i=@zabbo.net header.b=WSRJ3216; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=zabbo.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=zabbo.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=zabbo.net header.i=@zabbo.net header.b="WSRJ3216" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-35fc258aaa4so6683568a91.2 for ; Mon, 27 Apr 2026 15:22:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zabbo.net; s=google; t=1777328521; x=1777933321; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pRSM27InFki2GqRy/e9Me696BCOFh34dG7jm91eww0g=; b=WSRJ32168is/H3ymE+Lfxz1S63uUk1mu/uA+avZ6AHlD1qZf9PRPjB/7GT1S+MA1j6 MkYrq2yDjJqbP47Um/gUdnP6KvJXCAwUwOc4tNYahddOdQjoje3HyB37DZDsGEBeerWF rDR4uAOFJwiXNHTADqWDrKj9TziKjQOs2va7g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777328521; x=1777933321; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pRSM27InFki2GqRy/e9Me696BCOFh34dG7jm91eww0g=; b=e7awyS4L02g0MrKIj6e5CFKR7/lYdyxupZLPTMmKXCBhpy0utStulPE4A0dD8IeWZL bWZRK5ze9OB5jkMWzfK01WSZpjHnhft0Je64PIsdf1Lh527O4RGXnKuGUTgPRFLJVfIr yk62tle/qbglq91jCQ9yDzZfG1yIHRe1oHZc6Rl19Z842H7J4ec5DvkgeFyBOg9r3rzp 06x6INRnewt0IXQmRialFVN/OyRBEbTXElarOybQSRmg9APf/scVQRETcr9prhHRud7J sakEyOsC9gst1A8La96IqKrmp4aClip2uSzF/Ku4ZYZbxJp1IFUoBRvwPNbbxPcdJIMI v39Q== X-Gm-Message-State: AOJu0Yy6+xpDctGCbVt8AAp8uyFZmel4qL1Dj04N0oE0S/69GeDlrfmD r84pQA6hiAoHSUq6P4hC6+FrSbm/MZ4BAPUaoZASjZrF/clZCIW/IAJCNOvbgvwAxQI= X-Gm-Gg: AeBDiesxVVejI2cPI2yyQhX+Q0zDtt6wNkFnVV+SZKw7xLvK1MW7W3btAPmvyyACO3A dEn9zdiQyD18gq1lzVSnTu3R+0LbuHjDOhxXbe6SztLV5DJn2byG0/7hHjVh/0f6EEOwjXOzoRU atY/wHgvsqq0FNpSYJoUdzADxeSKz773SoSjBat67lpHmE/u6XEkbKKjDu3ppFKtV5A825KdrsA 8uJRopIKqgzxJMy7/SLESkHFS+KguL6ns9AgY4cRVIelHauZdZiObCO/bG8F8dHIZh/dhkUxpZD xU0vvrJhyM0Zws7GvsbJRm4QWjc/JWX6FSPnNKHALoEYWAEbpEVXRx7o8lGDPprVUTwR2ggTzbe Kw7EYb8sxst8dA6ybzJFz5yJhCi3+i7BQgRApuG97Hbdnbii5QclTsdX4A6EECqvjDAzO0/nnLU sVxe2uWNeQt0FV8se+/JYH X-Received: by 2002:a17:90b:3bcd:b0:359:855f:ff96 with SMTP id 98e67ed59e1d1-3649204d60fmr398616a91.17.1777328521569; Mon, 27 Apr 2026 15:22:01 -0700 (PDT) Received: from localhost ([50.39.133.72]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36490c24d5asm201655a91.5.2026.04.27.15.22.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 15:22:01 -0700 (PDT) Date: Mon, 27 Apr 2026 15:22:00 -0700 From: Zach Brown To: Valerie Aurora Cc: rpdfs-devel@lists.linux.dev Subject: Re: [PATCH 2/8] rpdfs: add rpdfs_file_llseek Message-ID: <20260427222200.GB3280715@localhost.localdomain> References: <20260424140520.3443624-1-val@versity.com> <20260424140520.3443624-3-val@versity.com> Precedence: bulk X-Mailing-List: rpdfs-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260424140520.3443624-3-val@versity.com> On Fri, Apr 24, 2026 at 04:05:14PM +0200, Valerie Aurora wrote: > Use generic_file_llseek to implement file seek. > +static loff_t rpdfs_file_llseek(struct file *file, loff_t offset, int whence) > +{ > + return generic_file_llseek(file, offset, whence); > +} This needs to refresh the inode. It'd use the same pattern as getattr of acquiring a block handle with the inode around its operation. - z