Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 037262EF652 for ; Mon, 27 Apr 2026 22:25:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777328713; cv=none; b=n6lZ2GTUXHWXR3s+Sa9YEeVw+4T3jio9OquZLW8okr2xkdIxi+LNLwNsKVSkK68ClFwK9zRXCYgLK/St3zjfIMKl5d/lJVmkJC2qbCsB5xMF/6dDBFNMMymX2Vn5k87jziANeLFy2EcTcWKync93/8RjrZc+Mz0NpWLRZX0GAlI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777328713; c=relaxed/simple; bh=8VAWM3aosPwZG8B4FXCJWWmQqS6v2nJIL1SRJ7lOt3E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bLe41SjdWykh3lDNzY/7p2zU789HoPCIrfHS+lfgW6ifW/51pfpK25ecE8mLjk0NyvIDmWI97e5jINOM2vdcdDdu2fIKhOn5nh2zJQ9pefkErNgm4Tlq0AlerTxazRedSfoSuu85iutp80tP0SWKz/MLH5bkEQ5fK35tCtWWgJA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=zabbo.net; spf=pass smtp.mailfrom=zabbo.net; dkim=pass (1024-bit key) header.d=zabbo.net header.i=@zabbo.net header.b=DEsz2A7l; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=zabbo.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=zabbo.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=zabbo.net header.i=@zabbo.net header.b="DEsz2A7l" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-c70fb6aa323so3743706a12.3 for ; Mon, 27 Apr 2026 15:25:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zabbo.net; s=google; t=1777328711; x=1777933511; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qgGp9IOS5RB+gnJu3sGCU8qHiG8IUYibrmg35J+xXms=; b=DEsz2A7lgn24RU3K4k6S5VgsudJ5NrnXv7xIrovMq5wU5mE54V5ty6JVM1zAKLppyI Uku+NcDqdLQv2sPJ8DyhZNOenWJ8MMAspkJK7rBrf/BW62LmFHehOugo1yZKiFB/brf2 rn07zwOhU5x8dtcR86ttisjZ00DrAe6w8QWko= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777328711; x=1777933511; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qgGp9IOS5RB+gnJu3sGCU8qHiG8IUYibrmg35J+xXms=; b=LITTSgFFGhrKPb3j6eJWMo+DpLigqONzsRxCcgMkDO2uKeaMDa0jHteTobsbnz4hJC x8SjHojifERm4fRYEIsyaed/8+v1ZEX1mbu0S2jtlsl/MBatqI1zalw6GYIOLnlJpbHE LipskvN1v2EGrmMUFJQOw6Vp7Ue3lmiZFLto8/IXNZyZ6t6QTohp5Wi0zQC5WoGTe509 4KZ+qItfhW8huusxlXvS+XAtg3I+dnA8MA33gyVI0B6NZa5Cfs9qF1cgKKTFadwm4zNa 8lL0f4L+iy79WOdy/EwQo1MYpfkzqlxb9EFgOfNiJQ5/XIdxn97Xy5r11hRB0p+fo282 8C0Q== X-Gm-Message-State: AOJu0YyO4zymtdKtW63EfSndRuFFWSZerAlfH4hzYWxk7Pj1oBsryc4Q hKUsqVCI2dB3YfXg29c03OuLF2gSi0BhK06LoKxuneNUd0xjMXgRLPqFZoYVCV45MqdD4esNBQC QmMOs X-Gm-Gg: AeBDieuJlphFdeFZNto25EawdP8BUd9Nbx3tNJd6dIxd3dbdybmikknPkmvqDvpaKzF Siq/4RH5Y7fLUXlgUxxPZeoTT7oVL+x+qKmlSObTaCLx+HvWPI+/ld4MlgcADhwGUON6WmOgOpg NXEcxnxPEXZ5DOCU3hGwq2FvaShnFCTRNF7LolTcaUjuNRWNIt5Ols6en6Uepl5413cDLAzrCVX qhyLpDsLewJIcJZQBDFLcd7Bz99gEtgmekhLwz/J+HTdCyZ0FVFt2ZyRCRJ5xFdo/nF91RjjAEq okJhMow+c5T8JyXVYu4QCp25SWxBsEY/nHdBwEC0D8YkAnpL3bnQMJBpXHqL/xeYCGKuh2lkgOh nMpJpm6mTGRfSccJPS3jjlQJh4mLt0thKpg8fWCjJ+jFV81gUi8sx76O9Nyy9lRK3Tz8VPCAJ4D o0tremyJtJ/qRcVFrvoXorpphLHka1pU4= X-Received: by 2002:a05:6a20:914e:b0:3a2:bd1d:d68c with SMTP id adf61e73a8af0-3a39c2cc569mr566523637.50.1777328711263; Mon, 27 Apr 2026 15:25:11 -0700 (PDT) Received: from localhost ([50.39.133.72]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c7fc299eac8sm268718a12.3.2026.04.27.15.25.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 15:25:10 -0700 (PDT) Date: Mon, 27 Apr 2026 15:25:10 -0700 From: Zach Brown To: Valerie Aurora Cc: rpdfs-devel@lists.linux.dev Subject: Re: [PATCH 4/8] rpdfs: add inode change debugging routine Message-ID: <20260427222510.GD3280715@localhost.localdomain> References: <20260424140520.3443624-1-val@versity.com> <20260424140520.3443624-5-val@versity.com> Precedence: bulk X-Mailing-List: rpdfs-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260424140520.3443624-5-val@versity.com> On Fri, Apr 24, 2026 at 04:05:16PM +0200, Valerie Aurora wrote: > print_inode_change() can be added to copy_vfs_inode_to_rinode() to > log what has changed since the last inode update. > +static inline void print_diff64(char *name, u64 new, u64 old) > +{ > + old = le64_to_cpu(old); Hmm, not building with sparse bitwise checking (C=2)? There a few more of these in the rest of the series but I won't call them out. With that fixed this'd be fine. - z