Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0D794CB5B for ; Mon, 27 Apr 2026 22:36:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777329367; cv=none; b=I1YN2ClVxrPSoL8NT6MzRFZdltzjybkvEe2+iHbEQeX43Logws3kwvmSXYx/ditsg7XMeJ05Cahv5BmT9zfviBd5fFRSBPu1dGwoNdXjuaHPoYnE2lToO5JV50l+QwzPpAjSGsNw3rZz2xrtOAixkkLS8rtueGjk7OeT/7AFZoc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777329367; c=relaxed/simple; bh=35/ralrh7U8H6iueifPMbqz+u1D8hmo3jzPB0jwgUaE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cQBpSaFJ6VnUc8LH1iI7ijNxvF402IUAyL7jnV9UnEc795LkzjShV0BalotM6pm79L9RQUNwnVuba7f/2TNyoAHp1MmyDCf/YqTVn9ZZ7HXEv1BYdFWggT0NBKuTVyfTFwUos0ZS0g44cgdFWkrf+HtZ1WO57/3YFYyfkosTzYs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=zabbo.net; spf=pass smtp.mailfrom=zabbo.net; dkim=pass (1024-bit key) header.d=zabbo.net header.i=@zabbo.net header.b=fYNaWEHU; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=zabbo.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=zabbo.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=zabbo.net header.i=@zabbo.net header.b="fYNaWEHU" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-c79467f11abso7206725a12.2 for ; Mon, 27 Apr 2026 15:36:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zabbo.net; s=google; t=1777329365; x=1777934165; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=E6NcvzW6YrinCKEcd6DyYeGeR53TmrpDtSykadm0gLM=; b=fYNaWEHUWySIEsuPw6KqF4rk4aeJUaF45yrN9yCXJ6Fo18NnvCGs6FqAOt2okdcNcL iWmvgebOY9h00Qh+qYrYYQ/CWiHdMGogR9RSsBpzwpmt+I0xkLk/pOFnY7ttrC/KRE+r +4Zp6kCvYm3r3i00Pj+dJHXlPWzfsMRpfv5P0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777329365; x=1777934165; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E6NcvzW6YrinCKEcd6DyYeGeR53TmrpDtSykadm0gLM=; b=M5tRJeM2fsCDcZNbO6ers1GTRlTcvHd8rCfKtF935Tza8ORbPFfci0i9JcsIfXU0CC nJ1rst73cxRSwCQydAwspJuB+VjDClnRshOOVg8FZ9krjHRlZgWBThz9H5OPRPNKhdeX nmgGZcqpUV5K0WGr81CPOMu1IAjOWMFW0uSwVh6EHDUndW5tLWi1w11pez4DMsGbD3N9 XceJzahV86tLc+v2f+G1YsDD91vxODBFSheSYEDy6HUr1NKfAWQblMB2Z4cI5/tR6S5T jrMOG8ubHJTIgCWbbpEMHnAMeretXgIdQCauYf4KIBQq7vWLRYeLE0FTchn5i7ztLOEf 5Q6w== X-Gm-Message-State: AOJu0YygdRdVgMPlzrGM5pWqAj7phgXoyGJQKoiteMfU3gTiHd2ivfsn q70WcywXQtIuVJhXMujtE8J3rt6Ljy8nUqCjLfsnEsOcLukEx7nRCFz8vEooxm9lGfRMQm5y6UQ 9GBGx X-Gm-Gg: AeBDiesBxlql44A8CwFFtYZDVLWyCCcmh9X5AVjfBCWHz7B1SwvSGMybklMWKf4fwat bnhhUpYe2+wrILKh8BeDVyLbn6nAgLqm7QZ6DI16r4VPbqZV9iPoHG5uVFfzbY/8Zc6PL/jXdKX OmjaWHjLTi+p0Tld72agVjmc+Xk2UwrJIjQEispqh+3Soybi5EfKvMe9GtIwBXRgcEtHEhgPTWv 3Hb/zNhBUawaMEZtoqxlhyXZBYijZCMC3O5inSgnjSuVnfFQ+aJmh4NCrQ7zApJqmk/tzBFJHmZ /qjkgWopAS01O4zwzBWiYyRxJtCfixRQ/B39Y5+t3KodHMabUvZZK3H1dvnMcevvgADdvF3R6nH Wzqg/ajKJtcHQnMpJNd0LHYg/TrXTimCbb0giiinjoPT68h4a/pT7ZdEtTlJ2nATgXGpmnwiyAO Ehde3TRz1cshX5u5tpc0IxzH5P6MVoOR0= X-Received: by 2002:a05:6a20:430a:b0:3a2:dd7d:b8aa with SMTP id adf61e73a8af0-3a39c1be6c8mr623626637.20.1777329365192; Mon, 27 Apr 2026 15:36:05 -0700 (PDT) Received: from localhost ([50.39.133.72]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c7fc299eaf5sm305009a12.5.2026.04.27.15.36.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 15:36:04 -0700 (PDT) Date: Mon, 27 Apr 2026 15:36:04 -0700 From: Zach Brown To: Valerie Aurora Cc: rpdfs-devel@lists.linux.dev Subject: Re: [PATCH 5/8] rpdfs: add basic file data initialization Message-ID: <20260427223604.GE3280715@localhost.localdomain> References: <20260424140520.3443624-1-val@versity.com> <20260424140520.3443624-6-val@versity.com> Precedence: bulk X-Mailing-List: rpdfs-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260424140520.3443624-6-val@versity.com> On Fri, Apr 24, 2026 at 04:05:17PM +0200, Valerie Aurora wrote: > Initialize the file data root, plus a few simple routines to calculate > mapping block levels. Rename the field in the inode from "data" to > "data_root" to avoid confusion with the "data" member of struct > rpdfs_block_handle. > +/* > + * Calculate the index of the block reference for this logical block > + * within an mapping block at this level (1 = pointers to data blocks). > + */ > +static u32 calc_ref_ind(u64 lblk, int level) > +{ > + u32 ind; > + int i; > + > + BUG_ON(level < 1); > + > + for (i = 1; i < level; i++) > + lblk >>= RPDFS_DATA_REFS_PER_BLK_SHIFT; > + > + ind = lblk & (RPDFS_DATA_REFS_PER_BLK - 1ULL); This could be a much smaller ">> ((level - 1) * shift) & mask". And let's have a specific _MASK define instead of the -1 by hand. > +static u8 height_from_lblk(u64 lblk) > +{ > + u8 height = 2; > + > + if (lblk == 0) > + return 1; > + > + while (lblk >>= RPDFS_DATA_REFS_PER_BLK_SHIFT) > + height++; > + > + return height; Similarly, this could be something involving "fls() / _SHIFT" while being careful with the various +1/-1 fenceposts. - z